Re: [Patch] Fix 675 caption behaviour

2006-12-20 Thread Martin Vermeer
On Wed, 2006-12-20 at 13:01 +0100, Abdelrazak Younes wrote: > Georg Baum wrote: > > Am Dienstag, 19. Dezember 2006 16:16 schrieb Abdelrazak Younes: > > > >> The patch does not apply cleanly... > > > > I put an updated one in bugzilla. It was partly applied already, and I > > applied one pure for

Re: [Patch] Fix 675 caption behaviour

2006-12-20 Thread Abdelrazak Younes
Georg Baum wrote: Am Dienstag, 19. Dezember 2006 16:16 schrieb Abdelrazak Younes: The patch does not apply cleanly... I put an updated one in bugzilla. It was partly applied already, and I applied one pure formatting change, too, so it is now really small. I now have "Senseless!" instead o

Re: [Patch] Fix 675 caption behaviour

2006-12-20 Thread Abdelrazak Younes
Georg Baum wrote: Am Dienstag, 19. Dezember 2006 16:16 schrieb Abdelrazak Younes: The patch does not apply cleanly... I put an updated one in bugzilla. It was partly applied already, and I applied one pure formatting change, too, so it is now really small. Good, I'll try it! Thanks, Abdel

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Georg Baum
Am Dienstag, 19. Dezember 2006 20:32 schrieb Martin Vermeer: > Does it do the job? I don't have time to check this right now (need to fix a bug in my own code :-( ) Georg

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
On Tue, Dec 19, 2006 at 07:51:33PM +0100, Georg Baum wrote: > Am Dienstag, 19. Dezember 2006 16:16 schrieb Abdelrazak Younes: > > > The patch does not apply cleanly... > > I put an updated one in bugzilla. It was partly applied already, and I > applied one pure formatting change, too, so it is n

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Georg Baum
Am Dienstag, 19. Dezember 2006 16:16 schrieb Abdelrazak Younes: > The patch does not apply cleanly... I put an updated one in bugzilla. It was partly applied already, and I applied one pure formatting change, too, so it is now really small. Georg

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
On Tue, Dec 19, 2006 at 04:16:49PM +0100, Abdelrazak Younes wrote: > Martin Vermeer wrote: > >On Tue, 2006-12-19 at 13:07 +0100, Georg Baum wrote: > >>Martin Vermeer wrote: > >> > >>>Yes, and a working patch to take it into use is found under the Bugzilla > >>>item (at least is _was_ working then..

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Abdelrazak Younes
Martin Vermeer wrote: On Tue, 2006-12-19 at 13:07 +0100, Georg Baum wrote: Martin Vermeer wrote: Yes, and a working patch to take it into use is found under the Bugzilla item (at least is _was_ working then... even tested it). Great, I did not know that. I am open to both solutions, but be

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
On Tue, 2006-12-19 at 13:07 +0100, Georg Baum wrote: > Martin Vermeer wrote: > > > Yes, and a working patch to take it into use is found under the Bugzilla > > item (at least is _was_ working then... even tested it). > > Great, I did not know that. > > > I am open to both solutions, but be aware

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Georg Baum
Martin Vermeer wrote: > Yes, and a working patch to take it into use is found under the Bugzilla > item (at least is _was_ working then... even tested it). Great, I did not know that. > I am open to both solutions, but be aware of the risks doing this close > to a release. And of course, lyx2lyx

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
On Tue, 2006-12-19 at 12:25 +0100, Georg Baum wrote: > Michael Gerz wrote: > > > Martin Vermeer schrieb: > >> This bug was classified as major and retargeted for 1.5.0. A proper fix, > >> by switching to caption inset, is not an option now during the freeze. > >> > > I think this depends on whe

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Georg Baum
Michael Gerz wrote: > Martin Vermeer schrieb: >> This bug was classified as major and retargeted for 1.5.0. A proper fix, >> by switching to caption inset, is not an option now during the freeze. >> > I think this depends on whether the caption inset is easy to implement. It does exist already

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
On Tue, 2006-12-19 at 10:48 +0100, Michael Gerz wrote: > Martin Vermeer schrieb: > > This bug was classified as major and retargeted for 1.5.0. A proper fix, > > by switching to caption inset, is not an option now during the freeze. > > > I think this depends on whether the caption inset is easy

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Michael Gerz
Martin Vermeer schrieb: This bug was classified as major and retargeted for 1.5.0. A proper fix, by switching to caption inset, is not an option now during the freeze. I think this depends on whether the caption inset is easy to implement. LyXText::breakParagraph() is a tricky (note that it

Re: [Patch] Fix 675 caption behaviour

2006-12-19 Thread Abdelrazak Younes
Martin Vermeer wrote: Attached the patch posted on Bugzilla that makes the caption in table and figure insets slightly better behaved. It covers the most common use cases. As correctly remarked on Bugzilla, this is something that many starting LyX users stumble on. This bug was classified as ma

[Patch] Fix 675 caption behaviour

2006-12-19 Thread Martin Vermeer
Attached the patch posted on Bugzilla that makes the caption in table and figure insets slightly better behaved. It covers the most common use cases. As correctly remarked on Bugzilla, this is something that many starting LyX users stumble on. This bug was classified as major and retargeted for 1