Re: [PATCH] stupid stuff that breaks things

2002-11-28 Thread Andre Poenitz
On Tue, Nov 26, 2002 at 05:34:57PM +0100, Lars Gullik Bjønnes wrote: > Did you say why > > class MathStream : public ostream { > MathStream(ostream & os) { > ostream::rdbuf(os.rdbuf()); > } > }; > > did not work? Probably not as I never tried that. Andre' -- Those who

Re: [PATCH] stupid stuff that breaks things

2002-11-27 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Yes, but we aready use + 'c' with string, my patch only makes us Lars> use it a bit more. So if there are problems with this, we Lars> already have the problem. OK, let's try it, then. JMarc

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 26, 2002 at 04:13:48PM +0100, Lars Gullik Bjønnes wrote: >> | Yes, the math streams. Currently they wrap an ostream and implement >> | operator<< individually to delegate work. >> >> yes... the operator<< for string is missing... > | It's in

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> I realize that... but to soothe you a bit... I do not really add | Lars> anything new, I just makes it more consistent. > | Lars> f.ex. we use sometimes find("c") and sometim

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> I realize that... but to soothe you a bit... I do not really add Lars> anything new, I just makes it more consistent. Lars> f.ex. we use sometimes find("c") and sometimes find('c'), both Lars> work, but find('c') is faster and

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Andre Poenitz
On Tue, Nov 26, 2002 at 04:13:48PM +0100, Lars Gullik Bjønnes wrote: > | Yes, the math streams. Currently they wrap an ostream and implement > | operator<< individually to delegate work. > > yes... the operator<< for string is missing... It's in another header as it is rarely used. > | This shou

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Andre Poenitz
On Tue, Nov 26, 2002 at 04:11:30PM +0100, Lars Gullik Bjønnes wrote: > f.ex. we use sometimes find("c") and sometimes find('c'), both work, > but find('c') is faster and has smaller mem-footprint. same goes for > << "c" vs. << 'c' and + "c" vs. + 'c'. Nobody opposes the proposed change on techni

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 26, 2002 at 03:21:38PM +0100, Lars Gullik Bjønnes wrote: >> >> Please have a quick glance and come with objections. >> > >> | The math outputstream stuff is still a bit fragile. I've not seen anything >> | in the patch that is likely to break

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> No specifics? Bad for you arguments then... > | I'm not giving arguments, just warnings. I know that you are going to | apply your patch anyway, so I am covering my ass. I be

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> No specifics? Bad for you arguments then... I'm not giving arguments, just warnings. I know that you are going to apply your patch anyway, so I am covering my ass. I bet you can already here be yell "I told you so!". JMarc

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Andre Poenitz
On Tue, Nov 26, 2002 at 03:21:38PM +0100, Lars Gullik Bjønnes wrote: > >> Please have a quick glance and come with objections. > > > | The math outputstream stuff is still a bit fragile. I've not seen anything > | in the patch that is likely to break something, but _I_ would not apply > | perl -pi

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 26, 2002 at 02:50:06PM +0100, Lars Gullik Bjønnes wrote: >> Please have a quick glance and come with objections. > | The math outputstream stuff is still a bit fragile. I've not seen anything | in the patch that is likely to break something,

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > | Lars> Please have a quick glance and come with objections. > | I would be surprised if it did not create obscure bugs here and | there. I'd be surprised if it creaded obsucre bugs

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Please have a quick glance and come with objections. I would be surprised if it did not create obscure bugs here and there. There have been cases in the past where we had to use "" instead of '' to avoid wrong interpretation of

Re: [PATCH] stupid stuff that breaks things

2002-11-26 Thread Andre Poenitz
On Tue, Nov 26, 2002 at 02:50:06PM +0100, Lars Gullik Bjønnes wrote: > Please have a quick glance and come with objections. The math outputstream stuff is still a bit fragile. I've not seen anything in the patch that is likely to break something, but _I_ would not apply perl -pi style changes ther

[PATCH] stupid stuff that breaks things

2002-11-26 Thread Lars Gullik Bjønnes
Please have a quick glance and come with objections. charstr-1.diff.gz Description: GNU Zip compressed data -- Lgb