Andre Poenitz <[EMAIL PROTECTED]> writes: | On Tue, Nov 26, 2002 at 03:21:38PM +0100, Lars Gullik Bjønnes wrote: >> >> Please have a quick glance and come with objections. >> > >> | The math outputstream stuff is still a bit fragile. I've not seen anything >> | in the patch that is likely to break something, but _I_ would not apply >> | perl -pi style changes there. >> >> I have no idea what "perl -pi style changes" are? > | Things like running perl -pi -e 's:"([a-zA-Z 0-9])":'\1':g' *.[Ch] | modulo proper quoting.
I did all the changes manually, and skip all parts where I was not sure (or farily so) about correctness. >> | This part probably should be reworked to use streambufs properly, but I do >> | not know how to do it. >> >> The math streams? > | Yes, the math streams. Currently they wrap an ostream and implement | operator<< individually to delegate work. yes... the operator<< for string is missing... | This should be done using | streambufs which is said to be the Right Solution. yes, and it is not even hard... -- Lgb