Re: [PATCH] new Ref dialog for GTK frontend

2005-03-11 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > | I'm not discouraged or anything by your feedback. It's ok. The Gnome > | HIG has its point when recommending instant apply. I myself aggree to > | it. However, if the lyx design requires it another way, I have to abide > | by the rules. I'll change that, and the glade

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-11 Thread Lars Gullik Bjønnes
Andreas Klostermann <[EMAIL PROTECTED]> writes: | I'm not discouraged or anything by your feedback. It's ok. The Gnome HIG | has its point when recommending instant apply. I myself aggree to it. | However, if the lyx design requires it another way, I have to abide by | the rules. I'll change that,

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-11 Thread Andreas Klostermann
I'm not discouraged or anything by your feedback. It's ok. The Gnome HIG has its point when recommending instant apply. I myself aggree to it. However, if the lyx design requires it another way, I have to abide by the rules. I'll change that, and the glade problems too. Also, the glade file isn't y

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread John Spray
On Thu, 2005-03-10 at 18:06 +0100, Andreas Klostermann wrote: > Other than that, it seems to work quite fine. I made it an instant apply > dialog to keep in touch with the gnome way of doing things. Now I think > it would be better to have a "revert changes" button... Andreas, Good start. As I s

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread John Spray
Angus, Now I've looked at the cross reference dialog, I don't know why Andreas made it instant apply: it's for inserting new refs as well as editing existing ones. So in this case I'd say okay/cancel is the appropriate button setup. This will go in that thread in a moment. More general comments

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread Angus Leeming
John Spray wrote: > On Thu, 2005-03-10 at 17:26 +, Angus Leeming wrote: >> Nice try but not quite there yet. The LyX dialogs aren't "instant >> apply". Instead, you press the Ok or Apply buttons. > In this context, instant apply means that changes in a dialog are > reflected in the document im

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread John Spray
On Thu, 2005-03-10 at 17:26 +, Angus Leeming wrote: > Nice try but not quite there yet. The LyX dialogs aren't "instant apply". > Instead, you press the Ok or Apply buttons. In this context, instant apply means that changes in a dialog are reflected in the document immediately, rather than hav

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread Juergen Spitzmueller
Andreas Klostermann wrote: > One issue that remains is, that my code still sets the buffer > combobox to the first entry, though I tried to find the correct index > via the current buffer's name... QRef.C (update()) has: // restore the buffer combo setting for new insets if (param

Re: [PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread Angus Leeming
Andreas Klostermann wrote: > Hi all, > This is my first contribution to lyx. I wrote a Ref dialog for the GTK > frontend. One issue that remains is, that my code still sets the buffer > combobox to the first entry, though I tried to find the correct index > via the current buffer's name... > Other

[PATCH] new Ref dialog for GTK frontend

2005-03-10 Thread Andreas Klostermann
Hi all, This is my first contribution to lyx. I wrote a Ref dialog for the GTK frontend. One issue that remains is, that my code still sets the buffer combobox to the first entry, though I tried to find the correct index via the current buffer's name... Other than that, it seems to work quite fine.