John Spray wrote: > On Thu, 2005-03-10 at 17:26 +0000, Angus Leeming wrote: >> Nice try but not quite there yet. The LyX dialogs aren't "instant >> apply". Instead, you press the Ok or Apply buttons. > In this context, instant apply means that changes in a dialog are > reflected in the document immediately, rather than having the user > compose changes in the dialog and then apply or cancel them. A number > of the lyx-gtk dialogs already are instant apply. > > The reason for doing a manual dispatchParams in the dialog code rather > than just triggering the apply method is that these signals represent an > interactive process: it should be as streamlined as possible, rather > than reading all the parameters out of the dialog just to apply a change > to one.
Nonsense. You're updating the state of a single inset. That's conceptually a single piece of information. Explain to me what is wrong with the UI of the QRef or XRef dialogs and how the GRef dialog does things better and I might buy it. However, the Controller does a heap of internal accountancy stuff when its told that the Apply Button has been pressed. It doesn't *just* call GRef::apply. You're subverting all of that by invoking dispatch directly. In fact, I have no idea *why* dispatch() is visible to the outside world. I'm very tempted to change that to stop you all breaking my beautiful design ;-) Angus (off to San Diego tomorrow, so probably a bit stirr-crazy) > Note that I haven't fully reviewed Andreas' work yet.
