On Thu, 2005-03-10 at 18:06 +0100, Andreas Klostermann wrote: > Other than that, it seems to work quite fine. I made it an instant apply > dialog to keep in touch with the gnome way of doing things. Now I think > it would be better to have a "revert changes" button...
Andreas, Good start. As I said in IRC¹, this dialog is unfortunately cannot be made instant-apply, since it serves not only for editing existing references, but also for inserting new ones. For this reason, it needs an OK/Cancel type interface. In the present version, when once goes to insert a reference, a new one is created each time one clicks on a different label in the list. The idea of having a "Back" button along with the "jump to" is cool. One problem: right now the "jump to" remains disabled until back is clicked: it should become enabled when the user selects a different label in the list. I think it would be good to make it so that when the user double clicks on a label in the list, it is equivalent to selecting the label and then clicking "Apply". A few issues with the glade: - Labels associated with editables should be capitalised, and end with colons: "Label:" instead of "label". They should also include mnemonics, so in fact "_Label:". Don't forget to set the "Focus Target" property when putting a mnemonic on such a label. - The scrolledwindow should probably have "H Policy" and "V Policy" set to "Automatic" rather than "Always", to display the scrollbars only when needed. - I would put the "Jump to" on the right and the "Back" button immediately to the left of it (rather than leaving a gap), since "Jump to" is the primary action - GNOME standard is to use title capitalisation on button labels, so it should be "Jump To" rather than "Jump to". - I would probably change "in document" to be just "Document:". But maybe that's debatable. Either way, it needs some spacing between the label and the combobox, 6 or 12 pixels. Thanks! Please don't be discouraged by my picky feedback. John 1. Mar 06 19:20:51 <elTigre> it's the same dialog for editing an existing reference Mar 06 19:21:02 <jcs> oh, is it? Doh. Mar 06 19:21:42 <jcs> Actually, there's the same problem with the vspace dialog: I made that "Insert" before I realised it was also for editing. I'll change that back. Mar 06 19:21:54 <elTigre> in the qt frontend there's apply and ok in both cases. Just that clicking ok in the first inserts the reference and the other one applies changes Mar 06 19:24:20 <jcs> hmm. I'd still just go with "OK" and "Cancel". The apply button is only useful in the case of changes that become visible in the background when you click it, and the cross references just show which label you've selected, as the dialog already does.
