Re: [PATCH] gtk Paragraph dialog

2004-10-01 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Regarding the spacingadj_ pointer, it turned out that it was not | necessary to create one anyway, one came with the spinbutton. > | Requested changes to spacing etc have been made. > | Patch to Makefile.am, Dialogs.C from previous message still applies. J

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: >> > Revised glade file makes dialog modal. >> I don't know what this means. No GUI expert me. > A modal dialog blocks all input to its parent window until it is > dismissed. In this case the dialog's contents become invalid if the > user selects another paragraph, so I prevent t

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 21:28, Angus Leeming wrote: > > Revised glade file makes dialog modal. > I don't know what this means. No GUI expert me. A modal dialog blocks all input to its parent window until it is dismissed. In this case the dialog's contents become invalid if the user selects another p

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Regarding the spacingadj_ pointer, it turned out that it was not | necessary to create one anyway, one came with the spinbutton. > | Requested changes to spacing etc have been made. > | Patch to Makefile.am, Dialogs.C from previous message still applies. >

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Angus Leeming
John Spray wrote: > Revised glade file makes dialog modal. I don't know what this means. No GUI expert me. > This would not be necessary if I > could get a signal each time the cursor in the workarea changes position > (to load the present paragraph's settings into the dialog), but that > would

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. > >> drop the if. (and change to use a smart pointer) | Confession time: I have

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: >> Two newlines between functions please. | That one doesn't seem to be in the Rules document, maybe you should add | it. I probably should :-) Anyhow this is done everywhere else in the code. > >> d

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
Regarding the spacingadj_ pointer, it turned out that it was not necessary to create one anyway, one came with the spinbutton. Requested changes to spacing etc have been made. Patch to Makefile.am, Dialogs.C from previous message still applies. Attached is also an addition to GViewBase: update(

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
On Wed, 2004-09-29 at 15:25, Lars Gullik Bjønnes wrote: > Two newlines between functions please. That one doesn't seem to be in the Rules document, maybe you should add it. > drop the if. (and change to use a smart pointer) Confession time: I have no idea about smart pointers. I've looked at the

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | class ControlParagraph; > | /** This class provides a gtk implementation of the paragraph dialog. | */ | class GParagraph | : public GViewCB { | Gtk::Adjustment * spacingadj_; Do you really need it to be a pointer at all? -- Lgb

Re: [PATCH] gtk Paragraph dialog

2004-09-29 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | /** | * \file GParagraph.C | * This file is part of LyX, the document processor. | * Licence details can be found in the file COPYING. | * | * \author John Spray | * | * Full author contact details are available in file CREDITS. | */ > | #include >

[PATCH] gtk Paragraph dialog

2004-09-29 Thread John Spray
Hi, The paragraph dialog. Note that this is the first instant-apply dialog I've done: hopefully that should all work okay. John Index: ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/gtk/ChangeLog,v retrieving revision 1.62