Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Martin Vermeer
On Wed, Nov 02, 2005 at 02:41:24PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> It looks like this then. OK to commit? > > Yes. > > JMarc Done. - Martin pgpTpb1fNSI1Y.pgp Description: PGP signature

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> It looks like this then. OK to commit? Yes. JMarc

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Martin Vermeer
On Wed, Nov 02, 2005 at 12:51:38PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> OK, that's easy. There is an LColor::red in insetcharstyle > Martin> too; shall I change it as well? > > Yes, please. > > JMarc It looks like this the

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> OK, that's easy. There is an LColor::red in insetcharstyle Martin> too; shall I change it as well? Yes, please. JMarc

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Martin Vermeer
On Wed, Nov 02, 2005 at 11:32:29AM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> However, the attached displays the inset as undefined upon > Martin> reloading the document, which is the most important situation > Martin> where a warn

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-11-02 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> However, the attached displays the inset as undefined upon Martin> reloading the document, which is the most important situation Martin> where a warning is called for. Does not look bad. However, please avoid to use explicit col

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> However, the attached displays the inset as undefined upon Martin> reloading the document, which is the most important situation Martin> where a warning is called for. OK. JMarc

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Georg Baum
Martin Vermeer wrote: > On Wed, 2005-10-26 at 10:42 +0200, Georg Baum wrote: >> Yes. And the inset should be set to the undefined state immediately after >> a branch is deleted and after a copy from a different document. Is that >> difficult to implement? > > Doesn't appear to be straightforward.

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Martin Vermeer
On Wed, 2005-10-26 at 10:42 +0200, Georg Baum wrote: ... > > We have to somehow handle the situation where a branch inset is in a > > document for which the branch is not defined. In CharStyle you created a > > method setUndefined, which prefixed the button text with "Undef:" > > Did I? I don't

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Georg Baum
Martin Vermeer wrote: > I mean: (1) define a branch, (2) insert a branch inset of that branch, > and (3) delete the branch definition again. OK, now I understand. IMHO (3) should not be possible if there are still branch insets, or it should at least ask for confirmation. > Hmmm, one can call th

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg> Can you explain what you mean by 'from underneath'? IMO the > Georg> general problem here is that a child document does not know if > Georg> it has a parent and which document that parent actually is. We > Georg> see the same problem with citations and cross re

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Martin Vermeer
On Wed, 2005-10-26 at 09:00 +0200, Georg Baum wrote: > Martin Vermeer wrote: > > > On Tue, Oct 25, 2005 at 05:06:40PM +0200, Jean-Marc Lasgouttes wrote: > >> Of course, then if you load the child document alone, the branches > >> will not be known and will display black... > > > > A special case

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> Martin Vermeer wrote: >> On Tue, Oct 25, 2005 at 05:06:40PM +0200, Jean-Marc Lasgouttes >> wrote: >>> Of course, then if you load the child document alone, the branches >>> will not be known and will display black... >> A special case

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-26 Thread Georg Baum
Martin Vermeer wrote: > On Tue, Oct 25, 2005 at 05:06:40PM +0200, Jean-Marc Lasgouttes wrote: >> Of course, then if you load the child document alone, the branches >> will not be known and will display black... > > A special case of a more general problem. Insert branch insets of a > branch and t

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> What do you think. Should I apply this? Martin> Yes, I think so. Done. JMarc

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Martin Vermeer
On Tue, Oct 25, 2005 at 06:08:48PM +0300, Martin Vermeer wrote: > On Tue, Oct 25, 2005 at 02:20:53PM +0200, Jean-Marc Lasgouttes wrote: > The attached additional patch places the master doc's branches at least > on the menu tree within the child. > > - Martin Ignore this :-) - Martin pgpuL1

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Martin Vermeer
On Tue, Oct 25, 2005 at 05:06:40PM +0200, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Yes, this seems to work... at least when outputting to LaTeX. > > Martin> The funny thing is, you have to independently define the > Martin> branches in

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Martin Vermeer
On Tue, Oct 25, 2005 at 02:20:53PM +0200, Jean-Marc Lasgouttes wrote: > > Another bug that is not too difficult to fix. The only remaining > problem I see is that the brach list that is seen in the child > document settings is not the right one. This is a general problem with > child documents and

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Yes, this seems to work... at least when outputting to LaTeX. Martin> The funny thing is, you have to independently define the Martin> branches in the child document (as you say), and then create Martin> branch insets there. But

Re: [PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Martin Vermeer
On Tue, Oct 25, 2005 at 02:20:53PM +0200, Jean-Marc Lasgouttes wrote: > > Another bug that is not too difficult to fix. The only remaining > problem I see is that the brach list that is seen in the child > document settings is not the right one. This is a general problem with > child documents and

[PATCH] bug 2092: branches not propagated to child documents

2005-10-25 Thread Jean-Marc Lasgouttes
Another bug that is not too difficult to fix. The only remaining problem I see is that the brach list that is seen in the child document settings is not the right one. This is a general problem with child documents and buffer settings, anyway. Martin, could you take a quick look please? JMarc I