> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> It didn't apply cleanly: apparently fr.po was already
Bennett> modified in svn. (I checked and fr.po seems to include the
Bennett> right translations.)
Bennett> In any case, the LyX menu still comes up in English when I
Bennett>
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> I see -- more evidence you're working on a secret rewrite of
Bennett> LyX as a Cocoa app with proper Services support. ;)
There is little chance to see me do that, since I hate building dialogs.
>> So, your vote is?
Bennett> P
On Feb 27, 2007, at 9:30 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Ah -- that's what happens when I just apply automatically
Bennett> without looking. I think Reconfigure naturally belongs in the
Bennett> LyX menu.
Yes, that was my reasonin
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Ah -- that's what happens when I just apply automatically
Bennett> without looking. I think Reconfigure naturally belongs in the
Bennett> LyX menu.
Yes, that was my reasoning.
Bennett> I do see a potential problem with offerin
On Feb 26, 2007, at 3:33 PM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, no translation again. But now "Reconfigure" (in
Bennett> English) shows up in the LyX menu (and not in the Outils
Bennett> menu). I don't see any other changes.
... to the list this time
On Feb 26, 2007, at 3:21 PM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, and no translation. Looks like what you intended.
On the translation front, what happens with the following patch? Note
that I ad
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, no translation again. But now "Reconfigure" (in
Bennett> English) shows up in the LyX menu (and not in the Outils
Bennett> menu). I don't see any other changes.
That was the goal. Now the question: do you think it is
On Feb 26, 2007, at 2:59 PM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, and no translation. Looks like what you intended.
Thanks, I implemented it. Now I would be surprised to know whether
this patch is a good idea. Could you test?
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, and no translation. Looks like what you intended.
On the translation front, what happens with the following patch? Note
that I added some translations for french, so this is what you should
try to test.
JMarc
Inde
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> No crashes, and no translation. Looks like what you intended.
Thanks, I implemented it. Now I would be surprised to know whether
this patch is a good idea. Could you test?
JMarc
Index: src/frontends/qt4/QLMenubar.C
===
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> Thanks, I implemented it. Now I would be surprised to know
Hmpf
s/implemented/committed/
s/surprised/interested/
At least I did not forget to attach the patch.
JMarc
On Feb 22, 2007, at 11:49 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Yes -- it does. The menus seem to be in the right spots,
Bennett> though in the LyX menu, "About LyX" and "Preferences" are
Bennett> untranslated. Worse, selecting either o
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Yes -- it does. The menus seem to be in the right spots,
Bennett> though in the LyX menu, "About LyX" and "Preferences" are
Bennett> untranslated. Worse, selecting either one produces a crash.
Bennett> Here's the backtrace (same
... To the list, this time
On Feb 16, 2007, at 1:20 PM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Nope -- at least not completely!
OK, I guess this time it will at least compile!
Yes -- it does. The menus seem to be in the right spots,
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Nope -- at least not completely!
OK, I guess this time it will at least compile!
JMarc
Index: src/frontends/qt4/Action.C
===
--- src/frontends/qt4/Action.C (rév
On Feb 14, 2007, at 12:25 PM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Next...:
Is this better?
JMarc
Nope -- at least not completely!
Bennett
if /bin/sh ../../../libtool --tag=CXX --mode=compile g++ -
DHAVE_CONFIG_H -I
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> Next...:
Is this better?
JMarc
Index: src/frontends/qt4/QLMenubar.C
===
--- src/frontends/qt4/QLMenubar.C (revision 17186)
+++ src/frontends/qt4/QLMenubar.C (work
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Instead of working around this Qt hack why not just rename
Abdelrazak> our menu item to "LyX Preferences", "LyX About", etc? Then
Abdelrazak> in en.po (which does not exist now but could be created),
Abdelrazak> we jus
On Feb 13, 2007, at 10:01 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> On Feb 13, 2007, at 6:27 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> On Feb 13, 2007, at 6:27 AM, Jean-Marc Lasgouttes wrote:
>>> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
>>
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the ori
On Feb 13, 2007, at 9:20 AM, Abdelrazak Younes wrote:
Compile error:
QLMenubar.C:167: error: 'MenuRole' has not been declared
#include in this file...
That doesn't do it: same error.
Bennett
Bennett Helm wrote:
On Feb 13, 2007, at 6:27 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm
<[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Hmm, I th
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> This seems wrong to me. IIRC, a new Action object is
Abdelrazak> instantiated each time a popup menu is unrolled (one for
Abdelrazak> each menu item). So you are going to setMenuRole() every
Abdelrazak> time. I am not
On Feb 13, 2007, at 6:27 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Hmm, I think I know why it hap
Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm
<[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Hmm, I think I know why it happens
Jean-Marc Lasgouttes wrote:
+# if QT_VERSION >= 0x040200
/* The qt/mac menu code has a very silly hack that moves some
menu entries that it recognizes by name (e.g.
"Preferences...") to the "LyX" menu. This feature can only
I have an idea, I am not sure this is fe
Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Hmm, I think I know why it happens: a menu with a role can o
Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Bennett> The first time the Tools and Help menus are opened,
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Hmm, I think I know why it happens: a menu with a role can only be
recognized once...
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This patch has some strange behaviors -- which I'm now
Bennett> noticing are problems with the original patch (as modified by
Bennett> Abdel).
Bennett> The first time the Tools and Help menus are opened, they are
Bennett> what t
[I neglected to send my reply to the list, and I guess Jean-Marc
didn't notice and send his revised patch only to me. Here's his e-
mail ... and my reply.]
On Feb 12, 2007, at 10:40 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
[the same with the pat
>> Your patch does not compile (missing 'if' in Action.C), here is an
>> updated patch.
Doh!
JMarc
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
>> Your patch does not compile (missing 'if' in Action.C), here is an
>> updated patch.
Bennett> Abdel's version compiles fine, though the LyX menu is still
Bennett> in English.
But do the different menus show up at the right place? Th
On Feb 12, 2007, at 7:56 AM, Abdelrazak Younes wrote:
Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
If this does not work, we may have to use qt 4.2 support for mac
menu. Do you see a problem with requiring qt 4.2 on the mac? Or
should we keep 4.1 support as
Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
If this does not work, we may have to use qt 4.2 support for mac
menu. Do you see a problem with requiring qt 4.2 on the mac? Or
should we keep 4.1 support as backup solution?
Bennett> I don't see why 4.2 would
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
>> If this does not work, we may have to use qt 4.2 support for mac
>> menu. Do you see a problem with requiring qt 4.2 on the mac? Or
>> should we keep 4.1 support as backup solution?
Bennett> I don't see why 4.2 would be a problem sinc
On Mon, Feb 05, 2007 at 06:03:29PM +0100, Abdelrazak Younes wrote:
> What I'm afraid of is that Qt does it for you... But in principle we
> should be safe because Qt needs a non-null parent to do this
> automatically and you did not create a constructor. Still you have a
> memory leak.
Depends
On Feb 6, 2007, at 10:03 AM, Jean-Marc Lasgouttes wrote:
"Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This second version creates a new "special" menu between the
Bennett> LyX and (in French) Fichier menus, and contains only one
Bennett> item: "Préférences" (which has no keyb
On Mon, Feb 05, 2007 at 04:36:01PM +0100, Abdelrazak Younes wrote:
> Jean-Marc Lasgouttes wrote:
> >
> >+
> >+// Mac specific stuff goes here...
> >+#ifdef Q_WS_MACX
> >+
> >+class MenuTranslator : public QTranslator {
> >+
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> This second version creates a new "special" menu between the
Bennett> LyX and (in French) Fichier menus, and contains only one
Bennett> item: "Préférences" (which has no keybinding, but properly
Bennett> brings up the preferences
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes:
Bennett> I should also add: upon closing LyX (after sending the
Bennett> message), I noticed the following output in the Terminal
Bennett> window from which I had launched it. (I don't get this
Bennett> without the patch.)
Bennett> Menu
On Feb 5, 2007, at 1:16 PM, Bennett Helm wrote:
On Feb 5, 2007, at 12:10 PM, Jean-Marc Lasgouttes wrote:
"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> Updated patch attached.
Argh!
JMarc
This second version creates a new "special" menu between the LyX
and
On Feb 5, 2007, at 12:10 PM, Jean-Marc Lasgouttes wrote:
"Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> Updated patch attached.
Argh!
JMarc
This second version creates a new "special" menu between the LyX and
(in French) Fichier menus, and contains only one
Jean-Marc Lasgouttes wrote:
Index: src/frontends/qt4/GuiApplication.C
===
[...]
+#ifdef Q_WS_MAC
This #ifdef is fine and needed.
+ // This allows to translate the strings that appear in the LyX menu.
+ addMenuTra
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
Jean-Marc> Updated patch attached.
Argh!
JMarc
Index: src/frontends/qt4/GuiApplication.C
===
--- src/frontends/qt4/GuiApplication.C (revision 17053)
+++ src/fro
Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> I don't see where in your patch
Abdelrazak> MenuTranslator::translate() is called. If this is called
Abdelrazak> internally by Qt, then I suggest to add a virtual
Abdelrazak> destructor to Menu
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> I don't see where in your patch
Abdelrazak> MenuTranslator::translate() is called. If this is called
Abdelrazak> internally by Qt, then I suggest to add a virtual
Abdelrazak> destructor to MenuTranslator.
This is inde
Jean-Marc Lasgouttes wrote:
+
+// Mac specific stuff goes here...
+#ifdef Q_WS_MACX
+
+class MenuTranslator : public QTranslator {
+ virtual QString translate(const char * context,
+ const char * sourceText,
+ co
Bennett,
The following patch should fix the last problem with the LyX menu: the
entries are in English.
Could you try it out?
JMarc
Index: src/frontends/qt4/GuiApplication.C
===
--- src/frontends/qt4/GuiApplication.C (revision 1
49 matches
Mail list logo
