Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Richard Heck
Jürgen Spitzmüller wrote: >> Is what's troubling you the lack of margin? >> > Yes. Your screenshot looks good. Committed. Richard -- == Richard G Heck, Jr Professor of Philosophy Brown University http://frege.brown.edu/heck/ =

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Jürgen Spitzmüller
Richard Heck wrote: > I committed the grid version, so that's probably what you're seeing. Yes. > Is what's troubling you the lack of margin? Yes. > I agree that looks less than > perfect and would be happy to add some, thus: > > screenshot Your screenshot looks good. I wonder, though, why

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Richard Heck
I committed the grid version, so that's probably what you're seeing. Is what's troubling you the lack of margin? I agree that looks less than perfect and would be happy to add some, thus: Richard Jürgen Spitzmüller wrote: Richard Heck wrote: Try the attached. It retains the ex

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-13 Thread Jürgen Spitzmüller
Richard Heck wrote: > Try the attached. It retains the existing layout but sets a different > size policy. But I can do a grid if you prefer. I'd prefer a grid. I've attached a screenshot of how it looks like now. Jürgen lyx1.png Description: PNG image

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-12 Thread Richard Heck
Try the attached. It retains the existing layout but sets a different size policy. But I can do a grid if you prefer. rh Jürgen Spitzmüller wrote: > Richard Heck wrote: > >> Attached is a patch fixing bug 1550. It pre-empts my previous effort, >> using radio buttons, as suggested by Abdel a

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-12 Thread Jürgen Spitzmüller
Richard Heck wrote: > Attached is a patch fixing bug 1550. It pre-empts my previous effort, > using radio buttons, as suggested by Abdel and JMarc, among others, > rather than a combo box, as previously. Could you please layout the dialog in a grid? As it is now, it can be shrinked to almost zero

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting Richard Heck <[EMAIL PROTECTED]>: > [EMAIL PROTECTED] wrote: > >> One question: I would have preferred to make QParagraph::radioMap const > >> but couldn't, because it can only be populated after the dialog is > >> created. Any other ideas? > >> > > I think we don't really need this QPRadi

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread Richard Heck
[EMAIL PROTECTED] wrote: >> One question: I would have preferred to make QParagraph::radioMap const >> but couldn't, because it can only be populated after the dialog is >> created. Any other ideas? >> > I think we don't really need this QPRadioMap. We have only 4 radio buttons, > why > don't

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting [EMAIL PROTECTED]: > Quoting [EMAIL PROTECTED]: > > > > I propose that you commit your patch (taking into account my comments > below) > > with the modal dialog. Then, I'll help you fixing this update issue. > > Here's a cleanup patch based on yours. The patch. ParagraphDialog_abdel.di

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Quoting [EMAIL PROTECTED]: > I propose that you commit your patch (taking into account my comments below) > with the modal dialog. Then, I'll help you fixing this update issue. Here's a cleanup patch based on yours. Abdel.

Re: [PATCH] New Paragraph Dialog with Radio Buttons

2007-04-11 Thread younes . a
Richard Heck wrote: > Attached is a patch fixing bug 1550. It pre-empts my previous effort, > using radio buttons, as suggested by Abdel and JMarc, among others, > rather than a combo box, as previously. Very good work Richard! Thanks for doing this. > > This patch makes the dialog modal, for the

[PATCH] New Paragraph Dialog with Radio Buttons

2007-04-10 Thread Richard Heck
Attached is a patch fixing bug 1550. It pre-empts my previous effort, using radio buttons, as suggested by Abdel and JMarc, among others, rather than a combo box, as previously. This patch makes the dialog modal, for the present. This is not the ideal solution, but the ideal solution is still not