Re: [PATCH] Fix crash with mathed

2006-10-19 Thread Abdelrazak Younes
Michael Gerz wrote: Abdelrazak Younes wrote: I've done enough cleanups for 1.5 ;-) Does it mean that you won't do any other major cleanups for 1.5? I guess so yes. Well, unless 1.5 is still far away that is :-) But if those guys in Denmark fix all remaining issues about unicode, chances ar

Re: [PATCH] Fix crash with mathed

2006-10-19 Thread Michael Gerz
Abdelrazak Younes wrote: I've done enough cleanups for 1.5 ;-) Does it mean that you won't do any other major cleanups for 1.5? Actually, I wondering about what needs to be done/is intended to be done for 1.5 besides adding unicode support. Isn't it time to set up some kind of roadmap? IMHO

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> I agree that these things should be moved out of insets. Abdelrazak> I've done enough cleanups for 1.5 ;-) We'll see :) JMarc

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: In the new getPos, you pass 3 parameters that all should com from one cursor. This is wrong, especially since the method os useful to find the position of a cursor. Abdelrazak> IMHO, what is wrong reall

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> In the new getPos, you pass 3 parameters that all should com from >> one cursor. This is wrong, especially since the method os useful to >> find the position of a cursor. Abdelrazak> IMHO, what is wrong really is this cursorPo

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Nothing wrong per see. But Andre (and I think I agree with Abdelrazak> him) thinks that we should decorrelate the model and the Abdelrazak> view. Passing a BufferView (the view) and a DocIterat

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Nothing wrong per see. But Andre (and I think I agree with Abdelrazak> him) thinks that we should decorrelate the model and the Abdelrazak> view. Passing a BufferView (the view) and a DocIterator Abdelrazak> (the model

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Abdelrazak Younes
Georg Baum wrote: Am Dienstag, 17. Oktober 2006 17:06 schrieb Abdelrazak Younes: Hi, This crash was due to an invalid CursorSlice::text() null pointer accessed in InsetMathNest::cursorPos(): CoordCache & coord_cache = sl.text()->bv()->coordCache(); As you can see, I used this indire

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hi, This crash was due to an invalid CursorSlice::text() Abdelrazak> null pointer accessed in InsetMathNest::cursorPos(): Abdelrazak> CoordCache & coord_cache = Abdelrazak> sl.text()->bv()->c

Re: [PATCH] Fix crash with mathed

2006-10-18 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> Hi, This crash was due to an invalid CursorSlice::text() Abdelrazak> null pointer accessed in InsetMathNest::cursorPos(): Abdelrazak> CoordCache & coord_cache = Abdelrazak> sl.text()->bv()->coordCache(); Abdelraz

Re: [PATCH] Fix crash with mathed

2006-10-17 Thread Georg Baum
Am Dienstag, 17. Oktober 2006 17:06 schrieb Abdelrazak Younes: > Hi, > > This crash was due to an invalid CursorSlice::text() null pointer > accessed in InsetMathNest::cursorPos(): > > CoordCache & coord_cache = sl.text()->bv()->coordCache(); > > As you can see, I used this indirection to

Re: [PATCH] Fix crash with mathed

2006-10-17 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hi, This crash was due to an invalid CursorSlice::text() null pointer accessed in InsetMathNest::cursorPos(): CoordCache & coord_cache = sl.text()->bv()->coordCache(); As you can see, I used this indirection to access the BufferView::CoordCache(). Bad luck, the

[PATCH] Fix crash with mathed

2006-10-17 Thread Abdelrazak Younes
Hi, This crash was due to an invalid CursorSlice::text() null pointer accessed in InsetMathNest::cursorPos(): CoordCache & coord_cache = sl.text()->bv()->coordCache(); As you can see, I used this indirection to access the BufferView::CoordCache(). Bad luck, the passed CursorSlice was