>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> Nothing wrong per see. But Andre (and I think I agree with
Abdelrazak> him) thinks that we should decorrelate the model and the
Abdelrazak> view. Passing a BufferView (the view) and a DocIterator
Abdelrazak> (the model independent from the view) make explicit the
Abdelrazak> fact that we need both in this function. Passing Cursor
Abdelrazak> would hide that fact.

No, passing a cursor exactly shows that we need both the model and the
view. I would rather aggressively change LCursor to DocIterator in all
methods that are not buffervew-dependent, so that passing LCursor is a
clear indication that we depend on the view.

In the new getPos, you pass 3 parameters that all should com from one
cursor. This is wrong, especially since the method os useful to find
the position of a cursor.

JMarc

Reply via email to