Georg Baum wrote:
Am Dienstag, 17. Oktober 2006 17:06 schrieb Abdelrazak Younes:
Hi,

This crash was due to an invalid CursorSlice::text() null pointer accessed in InsetMathNest::cursorPos():

        CoordCache & coord_cache = sl.text()->bv()->coordCache();

As you can see, I used this indirection to access the BufferView::CoordCache(). Bad luck, the passed CursorSlice was not completely valid inside a mathed inset, hence the crash. My solution is to pass BufferView to InsetBase::cursorPos() and all its derivative.

Objections?

If you mean by "not completely valid" something else than "sl.text() is 0 inside math" then please explain.

No that's exactly what I meant.

Otherwise the patch is fine with me.

Thanks,
Abdel.

Reply via email to