Re: [PATCH] CollapseStatus

2003-12-13 Thread Martin Vermeer
On Sat, Dec 13, 2003 at 06:08:34PM +0100, Michael Schmitt spake thusly: > >> - In the "edit" menu, we add a submenu to toggle between all possible > >> modes. > > > > ...so as to be able to postpone this chore a little. > > Hmmm... What does that mean? Do you like the idea - or not? I

Re: [PATCH] CollapseStatus

2003-12-13 Thread Michael Schmitt
Martin Vermeer wrote: - Each inset type has a predefined default "open" mode - Left button on button label: Toggle between default open mode and close You might make this cycle through all four modes. I think this is not a good idea. IMHO the common user typically opens an inset to have a

Re: [PATCH] CollapseStatus

2003-12-12 Thread Martin Vermeer
On Fri, Dec 12, 2003 at 03:15:42PM +0100, Michael Schmitt spake thusly: > Concerning the mouse clicks - well, currently the right button invokes > the inset dialog. The left button (on the button label) opens/closes the > inset. > > Since there are collapsable insets which have their own dialog

Re: [PATCH] CollapseStatus

2003-12-12 Thread Martin Vermeer
On Fri, Dec 12, 2003 at 02:28:33PM +0100, Andre Poenitz spake thusly: > > On Fri, Dec 12, 2003 at 03:29:05PM +0200, Martin Vermeer wrote: > > Yes, apparently... but do you really need metrics() and draw() for > > that? E.g., insetcharstyle does it without... just > > InsetCharStyle::getDrawFont()

Re: [PATCH] CollapseStatus

2003-12-12 Thread Andre Poenitz
On Fri, Dec 12, 2003 at 04:16:27PM +0100, Michael Schmitt wrote: > Hi Andre, > > I think you broke some part of my patch. Looks like I mis-merged something. Sorry. Andre'

[PATCH] CollapseStatus

2003-12-12 Thread Michael Schmitt
Hi Andre, I think you broke some part of my patch. Please have a look at the attachment. Thanks, Michael Index: insetcollapsable.C === RCS file: /cvs/lyx/lyx-devel/src/insets/insetcollapsable.C,v retrieving revision 1.223 diff -u -r

Re: [PATCH] CollapseStatus

2003-12-12 Thread Jose' Matos
On Friday 12 December 2003 14:15, Michael Schmitt wrote: > > This, of course, are dreams of the future. First, I would like to see my > patch accepted (or rejected) so that I can continue (nowadways, the > inset files change quite rapidly) Then the lyx2lyx converter, then the > CharStyle unificatio

Re: [PATCH] CollapseStatus

2003-12-12 Thread Michael Schmitt
Martin Vermeer wrote: Otherwise, this looks like going in the right direction. But what about adding a fourth display mode, Labelbelow, to the set? Is that your next step? And where does the right mouse click (that toggles this with Inlined) go in that case? My next step is to move the CharStyle

Re: [PATCH] CollapseStatus

2003-12-12 Thread Andre Poenitz
On Fri, Dec 12, 2003 at 12:48:32PM +0100, Michael Schmitt wrote: > Please have a look at the patch. If you like it, please apply it. Done. Andre' PS: Mind whitespace. > + st = "inlined"; > + break; > + } > + os << "status "<< st << "\n"; > + > +inset.text

Re: [PATCH] CollapseStatus

2003-12-12 Thread Andre Poenitz
On Fri, Dec 12, 2003 at 03:29:05PM +0200, Martin Vermeer wrote: > Yes, apparently... but do you really need metrics() and draw() for > that? E.g., insetcharstyle does it without... just > InsetCharStyle::getDrawFont(). Is this used anywhere? void InsetCharStyle::metrics(MetricsInfo & mi,

Re: [PATCH] CollapseStatus

2003-12-12 Thread Martin Vermeer
On Fri, Dec 12, 2003 at 02:04:45PM +0100, Michael Schmitt spake thusly: > > Andre Poenitz wrote: > > On Fri, Dec 12, 2003 at 12:48:32PM +0100, Michael Schmitt wrote: > > > >>BTW: Why does insetert need metrics(...) & draw(...)? If they are really > >>needed, then we have to fix insetcollapsable

Re: [PATCH] CollapseStatus

2003-12-12 Thread Michael Schmitt
Andre Poenitz wrote: On Fri, Dec 12, 2003 at 12:48:32PM +0100, Michael Schmitt wrote: BTW: Why does insetert need metrics(...) & draw(...)? If they are really needed, then we have to fix insetcollapsable instead. They change the font to 'red typewriter', don't they? So, this is the code to ch

Re: [PATCH] CollapseStatus

2003-12-12 Thread Andre Poenitz
On Fri, Dec 12, 2003 at 12:48:32PM +0100, Michael Schmitt wrote: > BTW: Why does insetert need metrics(...) & draw(...)? If they are really > needed, then we have to fix insetcollapsable instead. They change the font to 'red typewriter', don't they? Andre'

[PATCH] CollapseStatus

2003-12-12 Thread Michael Schmitt
Hello, this patch moves all code for 'CollapseStatus' from insetert to insetcollapsable. Insetcollapsable has three states now just like ERTs before. You get into the "Inlined" mode, if you press CTRL-I inside an open inset. Please have a look at the patch. If you like it, please apply it. The