Otherwise, this looks like going in the right direction.
But what about adding a fourth display mode, Labelbelow, to the set? Is that your next step? And where does the right mouse click (that toggles this with Inlined) go in that case?
My next step is to move the CharStyle modes (which I like very much) to InsetCollapse. One of them will effectively replace the "inlined" mode.
Concerning the mouse clicks - well, currently the right button invokes the inset dialog. The left button (on the button label) opens/closes the inset.
Since there are collapsable insets which have their own dialog, we must assume that the right mouse button is not longer available for toggling.
Thus, in the future, I prefer the following solution:
- Each inset type has a predefined default "open" mode - Left button on button label: Toggle between default open mode and close - In the "edit" menu, we add a submenu to toggle between all possible modes.
This, of course, are dreams of the future. First, I would like to see my patch accepted (or rejected) so that I can continue (nowadways, the inset files change quite rapidly) Then the lyx2lyx converter, then the CharStyle unification, then ...
Have a nice weekend, Michael