Re: [PATCH] BibTeX annotation support

2005-03-21 Thread Jean-Marc Lasgouttes
> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> --- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: >> Another possibility would be to just output the content of the >> field without any label: + if (!annote.empty()) + result << "\n\n" >> << annote; >> Eitan> Good enough for me... I

Re: [PATCH] BibTeX annotation support

2005-03-20 Thread Angus Leeming
Eitan Frachtenberg wrote: > Hi Angus. > I've resubscribed to the list with my latest email account. Please use > this email address on the blanket file (sky8an () gmail ! com), which > actually does show my family name (Frachtenberg). Thanks, > --Eitan. Got it. Thanks, Eitan. -- Angus

Re: [PATCH] BibTeX annotation support

2005-03-20 Thread Eitan Frachtenberg
> Hi, Eitan.The entry in blanket-permissions.txt would currently appear as: > > Eitan > See lyx-devel list message entitled "BibTeX annotation support" of 18 > March 2005. > > I think it would be better if you had a family name. (Rather, it would be > better if you told us what your family

Re: [PATCH] BibTeX annotation support

2005-03-19 Thread Angus Leeming
Eitan wrote: >> Fine, and do I have your permission to release this code and later >> contribution to LyX under the term of the GPL v2 or later? > > Certainly. And I hope to have more contributions coming soon :) Hi, Eitan.The entry in blanket-permissions.txt would currently appear as: Eitan

Re: [PATCH] BibTeX annotation support

2005-03-19 Thread Angus Leeming
[EMAIL PROTECTED] wrote: > On Thu, 17 Mar 2005, Jean-Marc Lasgouttes wrote: > >> Eitan, >> >> I modified your patch a bit (removed rfind usage, tweaked display of >> annotation). >> >> I will commit this soon (to 1.3.x too). > > Maybe you should ask him about that general GPL thingy that Angus

Re: [PATCH] BibTeX annotation support

2005-03-18 Thread Eitan
> Fine, and do I have your permission to release this code and later > contribution to LyX under the term of the GPL v2 or later? Certainly. And I hope to have more contributions coming soon :) __ Do you Yahoo!? Yahoo! Small Business - Try our n

Re: [PATCH] BibTeX annotation support

2005-03-18 Thread Jean-Marc Lasgouttes
> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> --- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: >> Another possibility would be to just output the content of the >> field without any label: + if (!annote.empty()) + result << "\n\n" >> << annote; >> Eitan> Good enough for me... Fi

Re: [PATCH] BibTeX annotation support

2005-03-18 Thread Eitan
--- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Another possibility would be to just output the content of the field > without any label: > + if (!annote.empty()) > + result << "\n\n" << annote; > Good enough for me... __ Do

Re: [PATCH] BibTeX annotation support

2005-03-18 Thread Jean-Marc Lasgouttes
> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> --- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: >> I modified your patch a bit (removed rfind usage, tweaked display >> of annotation). Eitan> At the risk of sounding petty, changing "Annote: " to "Note: " Eitan> might conflict in the

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Eitan
--- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > I modified your patch a bit (removed rfind usage, tweaked display of > annotation). At the risk of sounding petty, changing "Annote: " to "Note: " might conflict in the future if we decide display the BibTeX note field as well. > > I will co

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Eitan
--- Jean-Marc Lasgouttes <[EMAIL PROTECTED]> wrote: > Shouldn't the test be > + if (idx == 0 || dummy[idx - 1] != '\\') > ? > Of course - I wasn't even aware that C++ strings have a [] operator (serves me right for not having used c++ in years :)

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread chr
On Thu, 17 Mar 2005, Jean-Marc Lasgouttes wrote: > Eitan, > > I modified your patch a bit (removed rfind usage, tweaked display of > annotation). > > I will commit this soon (to 1.3.x too). Maybe you should ask him about that general GPL thingy that Angus (or was it Andre?) did a little while

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> Second try, this time with contextual diff and a changelog. Eitan> + // Check if this is really a comment or just "\%" + if (idx Eitan> == 0 || dummy.rfind('\\',idx) !=

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: > | Eitan> Second try, this time with contextual diff and a changelog. > | Eitan> + // Check if this is really a comment or just "\%" | Eitan> + if (idx == 0 || dummy.rfind('\\',idx) !=

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Lars, these change seem very reasonable to me, especially the check > for \% is a real bug fix. I agree. Unfortunately the homegrown bibtex parser has some more errors, and we should replace it by something reasonable after 1.4. Georg

Re: [PATCH] BibTeX annotation support

2005-03-17 Thread Jean-Marc Lasgouttes
> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> Second try, this time with contextual diff and a changelog. Eitan> +// Check if this is really a comment or just "\%" Eitan> +if (idx == 0 || dummy.rfind('\\',idx) != idx - 1) Eitan> +dummy.erase(idx, strin

Re: [PATCH] BibTeX annotation support

2005-03-16 Thread Eitan
Second try, this time with contextual diff and a changelog. __ Do you Yahoo!? Yahoo! Small Business - Try our new resources site! http://smallbusiness.yahoo.com/resources/ Index: src/frontends/controllers/ChangeLog ==

Re: [PATCH] BibTeX annotation support

2005-03-16 Thread Jean-Marc Lasgouttes
> "Eitan" == Eitan <[EMAIL PROTECTED]> writes: Eitan> Friends, I have used LyX for ages now, but this is my first Eitan> patch, so please be kind (i.e., instuctional) if I'm doing this Eitan> entirely wrong. Eitan> I'm attaching a tiny patch that will show a BibTeX's entry Eitan> annotation

[PATCH] BibTeX annotation support

2005-03-14 Thread Eitan
Friends, I have used LyX for ages now, but this is my first patch, so please be kind (i.e., instuctional) if I'm doing this entirely wrong. I'm attaching a tiny patch that will show a BibTeX's entry annotation text in the citation preview dialog. Myself and several other researcher I know annota