Re: [patch] counters 3

2003-09-18 Thread Angus Leeming
Lars Gullik Bjønnes wrote: >>> and you should have kept the changes in separate patches. >> > | That is a case of "the pot calling the kettle black" if ever I > | heard one. Witness Garst's request for the lyx2lyx temporary file > | patch to be backported to 1.3.x. A 5 line patch wrapped up in a >

Re: [patch] counters 3

2003-09-18 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | Lars Gullik Bjønnes wrote: > >> Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> | On Mon, Sep 15, 2003 at 04:16:37PM +0200, Lars Gullik Bjønnes >> | wrote: | Not from me. Too much effort than I can afford right now. Then _why_ did you be

Re: [patch] counters 3

2003-09-18 Thread Angus Leeming
Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | On Mon, Sep 15, 2003 at 04:16:37PM +0200, Lars Gullik Bjønnes > | wrote: >>> | Not from me. Too much effort than I can afford right now. >>> >>> Then _why_ did you begin cleanup at all? >> > | The same reason why I star

Re: [patch] counters 2

2003-09-16 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Would work, but I _really_ don't see the benefit compared to Andre> the current working solution The really interesting part is not with sections (which I did not complain about) but rather chapters. We have somehow to switch from

Re: [patch] counters 3

2003-09-15 Thread Martin Vermeer
On Mon, Sep 15, 2003 at 05:51:23PM +0200, Andre Poenitz spake thusly: > I have about 10 versions, partial trees and messed up patches now. > > > I got this from CVS. Updated, and still there. > > Yes, CVS is broken. > > I'll just commit what seems to be the difference between CVS and old CVS

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 06:58:55PM +0300, Martin Vermeer wrote: > On Mon, Sep 15, 2003 at 05:36:51PM +0200, Andre Poenitz spake thusly: > > > On Mon, Sep 15, 2003 at 06:47:56PM +0300, Martin Vermeer wrote: > > > Simple things... it's the message, not the patch. > > > > Yes, but that's from a pre

Re: [patch] counters 3

2003-09-15 Thread Martin Vermeer
On Mon, Sep 15, 2003 at 05:36:51PM +0200, Andre Poenitz spake thusly: > On Mon, Sep 15, 2003 at 06:47:56PM +0300, Martin Vermeer wrote: > > Simple things... it's the message, not the patch. > > Yes, but that's from a preliminary version of the patch I did not intend > to apply (even if the fix i

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 06:47:56PM +0300, Martin Vermeer wrote: > Simple things... it's the message, not the patch. Yes, but that's from a preliminary version of the patch I did not intend to apply (even if the fix is obvious...) Andre' -- Those who desire to give up Freedom in order to gain S

Re: [patch] counters 3

2003-09-15 Thread Martin Vermeer
On Mon, Sep 15, 2003 at 05:26:06PM +0200, Andre Poenitz spake thusly: > > On Mon, Sep 15, 2003 at 06:38:36PM +0300, Martin Vermeer wrote: > > Current CVS does not quite... I need the attached. > > Sigh. > > I already complete broke that patch > > Andre' Simple things... it's the message, n

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 06:38:36PM +0300, Martin Vermeer wrote: > Current CVS does not quite... I need the attached. Sigh. I already complete broke that patch Andre'

Re: [patch] counters 3

2003-09-15 Thread Martin Vermeer
On Mon, Sep 15, 2003 at 10:27:01AM +0200, Andre Poenitz spake thusly: > > Andre' > > PS: Martin: It works. > Current CVS does not quite... I need the attached. - Martin -- Martin Vermeer [EMAIL PROTECTED] Helsinki University of Technology Dept. of Surveying, Inst. of Geodesy P.O. Box 12

Re: [patch] counters 3

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Sep 15, 2003 at 04:16:37PM +0200, Lars Gullik Bjønnes wrote: >> | Not from me. Too much effort than I can afford right now. >> >> Then _why_ did you begin cleanup at all? > | The same reason why I start cleaning the flat the day before an exam.

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 04:16:37PM +0200, Lars Gullik Bjønnes wrote: > | Not from me. Too much effort than I can afford right now. > > Then _why_ did you begin cleanup at all? The same reason why I start cleaning the flat the day before an exam. I don't want to learn for the exam, so I do somethi

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 03:04:09PM +0200, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > > is it now possible to have headings without counters in the navigate > > > menu? (like koma's addchaps and addsecs which have no counters but appear > > > in the toc). > > > > > > Would be great. > >

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 02:30:10PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | The most controversial bit in the patch should be the removal of some > | 'ObsoletedBy' entries. I believe this is the realm of lyx2lyx now for > | the distributed .layouts. [I.e.

Re: [patch] counters 3

2003-09-15 Thread Juergen Spitzmueller
Andre Poenitz wrote: > > is it now possible to have headings without counters in the navigate > > menu? (like koma's addchaps and addsecs which have no counters but appear > > in the toc). > > > > Would be great. > > I'd guess so. Simply adding a 'TocDepth 2' or similar to the layout > should do.

Re: [patch] counters 3

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | The most controversial bit in the patch should be the removal of some | 'ObsoletedBy' entries. I believe this is the realm of lyx2lyx now for | the distributed .layouts. [I.e. the facility as such should be kept to | enable the user to use it in his priv

Re: [patch] counters 3

2003-09-15 Thread Martin Vermeer
On Mon, Sep 15, 2003 at 10:27:01AM +0200, Andre Poenitz spake thusly: > PS: Martin: It works. :-) - Martin pgp0.pgp Description: PGP signature

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 11:46:27AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | So far I've only seen proposals that make the layout files bigger. > > And why is that bad in itself? It is not. But if you replace a working short version with a not-yet-impl

Re: [patch] counters 2

2003-09-15 Thread Alfredo Braunstein
Andre Poenitz wrote: > [BTW what's the official way to create one, I use M-x appendix, but I > doubt that's the newbie version?] Document->Start appendix here > I have a general aversion against physically removing items from menus. > [I.e. greying out is fine with me, but not removing] You neve

Re: [patch] counters 2

2003-09-15 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> (and I do not really care about the syntax for this, but "$$foo" Lars> might have some problems since it is not quite clear where the Lars> variable name ends. $$foobar) Sure. I do not know of a good syntax either :) Lars> | I

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | So far I've only seen proposals that make the layout files bigger. And why is that bad in itself? We are after all trying to be more explicit and to remove hardcoded stuff from the core. -- Lgb

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 11:34:22AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Implementationwise this is handled by a single 'if' in the core. Can't > | get much easier than that as there is a difference. > > then we stick witht the single counter idea. >

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Sep 15, 2003 at 11:06:45AM +0200, Jean-Marc Lasgouttes wrote: >> Andre> This would work in this case but not differ much from what we >> Andre> have. Moreover, I cannot imagine how to make this work with >> >> [appendix example] >> >> Andre> H

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Implementationwise this is handled by a single 'if' in the core. Can't | get much easier than that as there is a difference. then we stick witht the single counter idea. | The only real option I see here is to have separate Styles for 'Section | in App

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 11:06:45AM +0200, Jean-Marc Lasgouttes wrote: > Andre> This would work in this case but not differ much from what we > Andre> have. Moreover, I cannot imagine how to make this work with > > [appendix example] > > Andre> How would you do that? > > What about > >Count

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 11:05:22AM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > | Ok, I figured out you might mean something like > | > | Counter > | Name theorem > | LabelString"\arabic{theorem}" > | End

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 11:00:56AM +0200, Jean-Marc Lasgouttes wrote: > Andre> Imagine a counter 'theorem' used for both theorems and > Andre> definitions (i.e. standard AMS article behaviour). What should > Andre> the counter's 'String' look like? > > Andre> 'Theorem \arabic{theorem}:' ? > And

Re: [patch] counters 2

2003-09-15 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> This would work in this case but not differ much from what we Andre> have. Moreover, I cannot imagine how to make this work with [appendix example] Andre> How would you do that? What about Counter Name

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | Ok, I figured out you might mean something like | | Counter | Name theorem | LabelString"\arabic{theorem}" | End | | Style Theorem | LabelStyle Counter |

Re: [patch] counters 2

2003-09-15 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Sat, Sep 13, 2003 at 11:26:24PM +0200, Jean-Marc Lasgouttes Andre> wrote: >> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> Andre> On Fri, Sep 12, 2003 at 06:40:57PM +0200, Jean-Marc Lasgouttes Andre> wrote: What

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Mon, Sep 15, 2003 at 10:11:31AM +0200, Lars Gullik Bjønnes wrote: >> | We should make a policy that '80% good patches' can go in >> | without too much nitpicking during the development phase. >> >> and what usually happens is that 80% ends up being

Re: [patch] counters 3

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 10:46:09AM +0200, Juergen Spitzmueller wrote: > Andre Poenitz wrote: > > The depth at which a certain layout appears in the Navigate menu is now > > explicitly defined in the .layout file with the new 'TocLevel' tag. > > This method is not only more robust but also more flex

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 10:32:50AM +0200, Andre' Poenitz wrote: > Please fill in the following template for me to see what exactly it > would look like. > > Currently we have > > Counter > Name theorem > End > > Style Theorem > LabelSty

Re: [patch] counters 3

2003-09-15 Thread Juergen Spitzmueller
Andre Poenitz wrote: > The depth at which a certain layout appears in the Navigate menu is now > explicitly defined in the .layout file with the new 'TocLevel' tag. > This method is not only more robust but also more flexible than the > previously method based on 'educated guessing' (see last chunk

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Mon, Sep 15, 2003 at 10:11:31AM +0200, Lars Gullik Bjønnes wrote: > | We should make a policy that '80% good patches' can go in > | without too much nitpicking during the development phase. > > and what usually happens is that 80% ends up being 100% of the work > done... If the direction is r

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sat, Sep 13, 2003 at 11:26:24PM +0200, Jean-Marc Lasgouttes wrote: >> > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> >> Andre> On Fri, Sep 12, 2003 at 06:40:57PM +0200, Jean-Marc Lasgouttes >> Andre> wrote: What else do you want? >> >>

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Lars Gullik Bjønnes) writes: | Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > | | - I think the appearance of the counter should be defined in the label | | like latex does, because this is good encapsulation. If I redefine | | chapters to use roman numbers, I should not

Re: [patch] counters 2

2003-09-15 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | - I think the appearance of the counter should be defined in the label | like latex does, because this is good encapsulation. If I redefine | chapters to use roman numbers, I should not have to modify the | section layout. Actually, it is th

Re: [patch] counters 2

2003-09-15 Thread Andre Poenitz
On Sat, Sep 13, 2003 at 11:26:24PM +0200, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> On Fri, Sep 12, 2003 at 06:40:57PM +0200, Jean-Marc Lasgouttes > Andre> wrote: What else do you want? > >> Nothing. It's friday. > > Andre> Fine. > > In

Re: [patch] counters 2

2003-09-13 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Fri, Sep 12, 2003 at 06:40:57PM +0200, Jean-Marc Lasgouttes Andre> wrote: What else do you want? >> Nothing. It's friday. Andre> Fine. In case you're interested: - I like 95% of this patch. We need something like that. - I t

Re: [patch] counters 2

2003-09-12 Thread Martin Vermeer
On Fri, Sep 12, 2003 at 07:14:08PM +0200, Andre Poenitz spake thusly: ... > 'Final' patch attached for the curious. > > Note that most of the infrastructure for 'living' itemize bullets is > also there > > Andre' This is what I envisaged (more or less; not the template idea, great!) but

Re: [patch] counters 2

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 06:40:57PM +0200, Jean-Marc Lasgouttes wrote: > Andre> What else do you want? > > Nothing. It's friday. Fine. 'Final' patch attached for the curious. Note that most of the infrastructure for 'living' itemize bullets is also there Andre' Index: lib/layouts/article.l

Re: [patch] counters 2

2003-09-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> What else do you want? Nothing. It's friday. I have to go now, but I'll answer in a saner manner monday. JMarc

Re: [patch] counters 2

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 06:28:33PM +0200, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> In this case, the section label string should be defined as > > Andre> Chapter: "Chapter \arabic{chapter}" > Andre> Section: "\arabic{chapter}.\arabic{s

Re: [patch] counters 2

2003-09-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> In this case, the section label string should be defined as Andre> Chapter: "Chapter \arabic{chapter}" Andre> Section: "\arabic{chapter}.\arabic{section}" Andre> Subsection: "@[EMAIL PROTECTED]" Andre> Subsubsection: "@[EMAIL

Re: [patch] counters 2

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 05:31:06PM +0200, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> Not my invention. > > Andre> But \Alpha is fine with me. > > Unfortunately, LaTeX uses \alph and \Alph because \alpha means > something else... So what

Re: [patch] counters 2

2003-09-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> Not my invention. Andre> But \Alpha is fine with me. Unfortunately, LaTeX uses \alph and \Alph because \alpha means something else... >> Also what does the @Section@ thing do? Return the whole >> Labelstring? Andre> Of the 'Sec

Re: [patch] counters 2

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 05:01:25PM +0200, Jean-Marc Lasgouttes wrote: > > "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: > > Andre> This seems to work except for \itemize. > > Andre> I don't see how this worked before and I don't see how I broke > Andre> this. > > What is this \Latin t

Re: [patch] counters 2

2003-09-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> This seems to work except for \itemize. Andre> I don't see how this worked before and I don't see how I broke Andre> this. What is this \Latin thing? Shouldn't it be \Alph? If you use latex syntax, you might as well keep the macro

[patch] counters 2

2003-09-12 Thread Andre Poenitz
This seems to work except for \itemize. I don't see how this worked before and I don't see how I broke this. Any ideas? Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...) ? 1.dif

Re: [patch] counters

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 04:21:54PM +0200, Lars Gullik Bjønnes wrote: > Andre Poenitz <[EMAIL PROTECTED]> writes: > > >> Here $$the(foo) is the String output of counter foo. > > > >> Of course, this is a bit ugly because I followed closely the latex > >> spec. We could also define in the counter wh

Re: [patch] counters

2003-09-12 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: >> Here $$the(foo) is the String output of counter foo. > >> Of course, this is a bit ugly because I followed closely the latex >> spec. We could also define in the counter whether it should use >> arabic, latin, etc. We will though have a problem with app

Re: [patch] counters

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 03:57:17PM +0200, Jean-Marc Lasgouttes wrote: > > "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: > > Jean-Marc> A typical latex example is > > Jean-Marc> \def\thechapter{\arabic{chapter}} > Jean-Marc> \def\thesection{\thechapter.\arabic{section}} > Jea

Re: [patch] counters

2003-09-12 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> A typical latex example is Jean-Marc> \def\thechapter{\arabic{chapter}} Jean-Marc> \def\thesection{\thechapter.\arabic{section}} Jean-Marc> \def\subsection{\thesection.\arabic{subsection}} To follow up on my proposa

Re: [patch] counters

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 03:48:14PM +0200, Lars Gullik Bjønnes wrote: > John Levon <[EMAIL PROTECTED]> writes: > > | My eyes hurt. > > > | if (n < 1 || n > 26) > | return '?'; > | return 'a' + n - 1; > > In this case I agree... there are too many short tokes to parse > easily.

Re: [patch] counters

2003-09-12 Thread Andre Poenitz
On Fri, Sep 12, 2003 at 03:41:52PM +0200, Jean-Marc Lasgouttes wrote: > A typical latex example is > > \def\thechapter{\arabic{chapter}} > \def\thesection{\thechapter.\arabic{section}} > \def\subsection{\thesection.\arabic{subsection}} We need a simpler syntax until we have the tex parser in the

Re: [patch] counters

2003-09-12 Thread Lars Gullik Bjønnes
John Levon <[EMAIL PROTECTED]> writes: | My eyes hurt. > | if (n < 1 || n > 26) | return '?'; | return 'a' + n - 1; In this case I agree... there are too many short tokes to parse easily. -- Lgb

Re: [patch] counters

2003-09-12 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> This is a preliminary patch to finish the counter work. Andre> I am not that happy about the .layout syntax and there must be Andre> away to have shorter LabelString definitions but apart from Andre> that it seems to work rather we

Re: [patch] counters

2003-09-12 Thread John Levon
On Fri, Sep 12, 2003 at 03:27:42PM +0200, Andre Poenitz wrote: > Not to mention that the new version saves more than 100 lines... What, by making things less readable ? > char loweralphaCounter(int n) > { > - if (n < 1 || n > 26) > - return '?'; > - else > - ret

Re: [patch] counters

2003-09-12 Thread Jose' Matos
On Friday 12 September 2003 14:27, Andre Poenitz wrote: > This is a preliminary patch to finish the counter work. > > I am not that happy about the .layout syntax and there must be away to > have shorter LabelString definitions but apart from that it seems to > work rather well. > > Not to mention

[patch] counters

2003-09-12 Thread Andre Poenitz
This is a preliminary patch to finish the counter work. I am not that happy about the .layout syntax and there must be away to have shorter LabelString definitions but apart from that it seems to work rather well. Not to mention that the new version saves more than 100 lines... Comments? Andre

Re: [PATCH]: counters

2002-08-10 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | On Friday 09 August 2002 1:53 pm, Lars Gullik Bjønnes wrote: | > Angus Leeming <[EMAIL PROTECTED]> writes: | > | +void Counters::reset() | > | +{ | > | + CounterList::iterator it = counterList.begin(); | > | + CounterList::iterator end = counterList.en

Re: [PATCH]: counters

2002-08-09 Thread Angus Leeming
On Friday 09 August 2002 8:41 pm, Martin Vermeer wrote: > Hmmm yes, why not? This should work. It might even fix the floats > problem as a side effect. But how would you set up the Buffer Counters? > I just didn't see how to do that. Well, a Counter, owned by a Paragraph would have type

Re: [PATCH]: counters

2002-08-09 Thread Martin Vermeer
> So your paragraph would only touch the section counter from the buffer-wide > array, assign it to its own counter after stepping (incrementing) it. > Yes that works. Actually even better: I don't think that a paragraph should have its own counter at all. Just the buffer-wide counter array, use

Re: [PATCH]: counters

2002-08-09 Thread Martin Vermeer
On Fri, Aug 09, 2002 at 08:09:19PM +0100, Angus Leeming wrote: > > On Friday 09 August 2002 7:24 pm, Martin Vermeer wrote: > > Float counters fail to count, but that is quite unrelated to this: I > > believe it is due to float captions not being part of the same > > linked list of paragraphs (as

Re: [PATCH]: counters

2002-08-09 Thread Angus Leeming
On Friday 09 August 2002 7:24 pm, Martin Vermeer wrote: > Float counters fail to count, but that is quite unrelated to this: I > believe it is due to float captions not being part of the same > linked list of paragraphs (as linear text with sectioning headers, or > even nested enumerated lists, ar

Re: [PATCH]: counters

2002-08-09 Thread Martin Vermeer
On Fri, Aug 09, 2002 at 06:55:22PM +0100, Angus Leeming wrote: > On Friday 09 August 2002 6:50 pm, Martin Vermeer wrote: > > On Fri, Aug 09, 2002 at 01:05:04PM +0100, Angus Leeming wrote: > > > I believe that this makes more sense (and in the case of copy is probably > > > correct too ;-) than t

Re: [PATCH]: counters

2002-08-09 Thread Angus Leeming
On Friday 09 August 2002 6:50 pm, Martin Vermeer wrote: > On Fri, Aug 09, 2002 at 01:05:04PM +0100, Angus Leeming wrote: > > I believe that this makes more sense (and in the case of copy is probably > > correct too ;-) than the current code. > > I believe it is correct, though I had to re-read you

Re: [PATCH]: counters

2002-08-09 Thread Martin Vermeer
On Fri, Aug 09, 2002 at 01:05:04PM +0100, Angus Leeming wrote: > > I believe that this makes more sense (and in the case of copy is probably > correct too ;-) than the current code. I believe it is correct, though I had to re-read your use of *this's it->second a few times before actually belie

Re: [PATCH]: counters

2002-08-09 Thread Angus Leeming
On Friday 09 August 2002 1:53 pm, Lars Gullik Bjønnes wrote: > Angus Leeming <[EMAIL PROTECTED]> writes: > | +void Counters::reset() > | +{ > | + CounterList::iterator it = counterList.begin(); > | + CounterList::iterator end = counterList.end(); > | + > | + for (; it != end; ++it) { > | +

Re: [PATCH]: counters

2002-08-09 Thread Lars Gullik Bjønnes
Angus Leeming <[EMAIL PROTECTED]> writes: | +void Counters::reset() | +{ | + CounterList::iterator it = counterList.begin(); | + CounterList::iterator end = counterList.end(); | + | + for (; it != end; ++it) { | + it->second.reset(); | + } | +} So my std::memfun didn

[PATCH]: counters

2002-08-09 Thread Angus Leeming
I believe that this makes more sense (and in the case of copy is probably correct too ;-) than the current code. Martin, since I don't know the code at all or even fully understand what it is meant to be doing, perhaps you could have a look at the patch and ascertain that it is doing what you