Re: [patch] counters

[John Levon]

On Fri, Sep 12, 2003 at 03:27:42PM +0200, Andre Poenitz wrote:

> Not to mention that the new version saves more than 100 lines...

What, by making things less readable ?

>  char loweralphaCounter(int n)
>  {
> -     if (n < 1 || n > 26)
> -             return '?';
> -     else
> -             return 'a' + n - 1;
> +     return (n < 1 || n > 26) ? '?' : 'a' + n - 1;

My eyes hurt.

        if (n < 1 || n > 26)
                return '?';
        return 'a' + n - 1;

regards
john