Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-30 Thread Abdelrazak Younes
On 30/09/2008 21:11, Andre Poenitz wrote: On Tue, Sep 30, 2008 at 07:50:59AM +0800, hzluo wrote: I'd like to see a somewhat more verbose explanation than 'does not work sometimes' before introducing a platform specific monstrosity like that into LyX sources. Is this related or unrelated?

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-30 Thread Andre Poenitz
On Tue, Sep 30, 2008 at 07:50:59AM +0800, hzluo wrote: >> >> >> I'd like to see a somewhat more verbose explanation than 'does not work >> sometimes' before introducing a platform specific monstrosity like that >> into LyX sources. >> >> >> Is this related or unrelated? > > This patch just expired.

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread hzluo
I'd like to see a somewhat more verbose explanation than 'does not work sometimes' before introducing a platform specific monstrosity like that into LyX sources. Is this related or unrelated? This patch just expired. We now has much better patch for Qt 4.4. Regards, Hangzai

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Andre Poenitz
On Sun, Sep 28, 2008 at 06:18:55PM +0200, Abdelrazak Younes wrote: > On 28/09/2008 18:18, Abdelrazak Younes wrote: >> >> The patch from Hangzai is attached. > The patch... > > Abdel. > > Index: DetourCapIntf.cpp > === > --- DetourCapI

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread hzluo
I just checked and at least the latin1 subset is properly displayed in my console on Vista. It's because UTF-8's latin1 subset happen to follow your locale codepage. On different locale settings, even latin1 may be in chaose. Hangzai

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 13:04, Jean-Marc Lasgouttes wrote: "hzluo"<[EMAIL PROTECTED]> writes: For all error messages, the absFilename() is used to print filenames. It is always UTF-8. However, on the Windows console, UTF-8 strings can't be displayed properly if it has non-ASCII chars. So any messages

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 13:00, hzluo wrote: FYI, I merged the two methods now: Author: younes Date: Mon Sep 29 11:35:13 2008 New Revision: 26615 URL:http://www.lyx.org/trac/changeset/26615 Log: Merge FileFileName::Private::checksum() into FileFileName::checksum(). I have an off-topic, but related quest

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Jean-Marc Lasgouttes
"hzluo" <[EMAIL PROTECTED]> writes: > For all error messages, the absFilename() is used to print filenames. > It is always UTF-8. However, on the Windows console, > UTF-8 strings can't be displayed properly if it has non-ASCII chars. > So any messages directing to console may have chaose chars. In

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread hzluo
FYI, I merged the two methods now: Author: younes Date: Mon Sep 29 11:35:13 2008 New Revision: 26615 URL:http://www.lyx.org/trac/changeset/26615 Log: Merge FileFileName::Private::checksum() into FileFileName::checksum(). I have an off-topic, but related question. For all error messages, the ab

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread hzluo
FYI, I merged the two methods now: Author: younes Date: Mon Sep 29 11:35:13 2008 New Revision: 26615 URL:http://www.lyx.org/trac/changeset/26615 Log: Merge FileFileName::Private::checksum() into FileFileName::checksum(). Looks good to me. I believe it will work even if I havn't tested it. Han

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 02:38, hzluo wrote: Yes, the fact that this code _is not used_, provided that you use Qt4.4. And we _will_ use Qt4.4 on Windows for 1.6.x. This code is meant to disappear when we finally switch to 4.4, but this is not very important. The other issue is much more important. Yes,

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread hzluo
I would have thought that this kind of thing is only handled in the GUI and that the LyX format would use SI conventions (which I think is 1.23). So, if I am right, putting this in tex2lyx won't harm us, would it? Abdel. JMarc's concern may be true, I'm not quite sure. I tested a less aggre

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 09:51, Jean-Marc Lasgouttes wrote: Abdelrazak Younes<[EMAIL PROTECTED]> writes: setlocale(LC_ALL,""); I have tested on Windows and it works. The attached patch will add this call at proper position. Looks like a sane solution. Be very careful with that. It wi

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> setlocale(LC_ALL,""); >> >> I have tested on Windows and it works. The attached patch >> will add this call at proper position. > > Looks like a sane solution. Be very careful with that. It will mean for example that double variables will use 1,23 i

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 04:21, hzluo wrote: Friends, I have taken complete examination and test for this problem, found the following information: 1. Qt 4.4 has fixed several locale related problems, so now lyx is able to handle any files with non-ASCII chars in filename. That's good news! This is

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-29 Thread Abdelrazak Younes
On 29/09/2008 02:38, hzluo wrote: Yes, the fact that this code _is not used_, provided that you use Qt4.4. And we _will_ use Qt4.4 on Windows for 1.6.x. This code is meant to disappear when we finally switch to 4.4, but this is not very important. The other issue is much more important. Yes,

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-28 Thread hzluo
Friends, I have taken complete examination and test for this problem, found the following information: 1. Qt 4.4 has fixed several locale related problems, so now lyx is able to handle any files with non-ASCII chars in filename. This is true on Windows XP systems. I do not know the effect on o

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-28 Thread hzluo
Yes, the fact that this code _is not used_, provided that you use Qt4.4. And we _will_ use Qt4.4 on Windows for 1.6.x. This code is meant to disappear when we finally switch to 4.4, but this is not very important. The other issue is much more important. Yes, I know that. I can fully understand

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-28 Thread Abdelrazak Younes
On 28/09/2008 18:18, Abdelrazak Younes wrote: The patch from Hangzai is attached. The patch... Abdel. Index: DetourCapIntf.cpp === --- DetourCapIntf.cpp (revision 0) +++ DetourCapIntf.cpp (revision 0) @@ -0,0 +1,55 @@ +/** +

Re: [Bug 5252] LyX can't handle files with multi-byte chars in path

2008-09-28 Thread Abdelrazak Younes
Hello Hangzai, > I know, I wrote the API ;-) I did not do this because it is not > accessible, being a private method. But this doesn't matter if you > use Qt4.4 anyway. You put this function in Filename::Private, but IMHO it belongs to Filename class. Is there any special consideration for y