On Sun, Sep 28, 2008 at 06:18:55PM +0200, Abdelrazak Younes wrote:
> On 28/09/2008 18:18, Abdelrazak Younes wrote:
>>
>> The patch from Hangzai is attached.
> The patch...
>
> Abdel.
>

> Index: DetourCapIntf.cpp
> ===================================================================
> --- DetourCapIntf.cpp (revision 0)
> +++ DetourCapIntf.cpp (revision 0)
> @@ -0,0 +1,55 @@
> +/**
> + * \file DetourCapIntf.cpp
> + * This file implement a detour-like DLL-call capture.
> + * Licence details can be found in the file COPYING.
> + *
> + * \author Hangzai Luo
> + *
> + * Full author contact details are available in file CREDITS.
> + */
> +#include <windows.h>
> +//---------------------------------------------------------------------------
> +#include "DetourCapIntf.h"
> +#include "ModuleLoader.h"
> +//---------------------------------------------------------------------------
> +extern "C"
> +{
> +//---------------------------------------------------------------------------
> +void PatchCode(void *dst,void *newCode,int len)
> +{
> +     DWORD OldProtect;
> +    VirtualProtect(dst,len,PAGE_READWRITE,&OldProtect);
> +    memcpy(dst,newCode,len);
> +    VirtualProtect(dst,len,OldProtect,&OldProtect);
> +}
> [...]


> +namespace lyx {
> +namespace support {
> +
> +// Fix Qt problem: QFile::encodeName sometime can't properly detect local 
> codepage


I'd like to see a somewhat more verbose explanation than 'does not work
sometimes' before introducing a platform specific monstrosity like that
into LyX sources.

> +// Fix VC STL Lib problem: can't open files with non-ASCII chars in name
> +
> +_Filet * __cdecl My_Fiopen(const char * path,ios_base::openmode mode, int 
> val)

Is this related or unrelated?

Andre'

Reply via email to