Hello Hangzai,
> I know, I wrote the API ;-) I did not do this because it is not
> accessible, being a private method. But this doesn't matter if you
> use Qt4.4 anyway.
You put this function in Filename::Private, but IMHO it belongs to
Filename class. Is there any special consideration for your
arrangement?
Yes, the fact that this code _is not used_, provided that you use Qt4.4.
And we _will_ use Qt4.4 on Windows for 1.6.x. This code is meant to
disappear when we finally switch to 4.4, but this is not very important.
The other issue is much more important.
I have made the patch and tested. I moved your function to Filename
class and renamed to checksum_real().
As I said, those mofification are irrelevant for 1.6 on Windows. You
also moved the rest of the code outside the #ifdef for Qt which I've put
them explicitly so that it is still checked to compile even if you use
Qt4.4.
I am moving this discussion to the development list as this needs the
input of others. As I say in bugzilla, I don't know what to do with this
patch. I suspect that we might achieve the same functionality using
iconv in a cross-platform way, but I am not sure and don't really have
the time to investigate. Anyone who knows something about this, please
chime in.
The patch from Hangzai is attached.
Abdel.
