Fwd: [LyX/master] Add comment about coverity #23335.

Anyone have any thoughts about this? I'm not terribly familiar with this part of the code. Richard Forwarded Message Subject:[LyX/master] Add comment about coverity #23335. Date: Sun, 12 Jun 2016 06:46:44 +0200 (CEST) From: Richard Heck Reply-To: lyx-devel@l

Fwd: [LyX/master] Add comment about coverity #102061.

This is a fairly serious bug picked up by coverity. This will crash if we try to go to a bookmark without a document being displayed, which is possible. Richard Forwarded Message Subject:[LyX/master] Add comment about coverity #102061. Date: Sun, 12 Jun 2016 06:46:44

Re: [LyX/master] Add missing includes after change to boost signals2

Am 11.06.2016 um 22:30 schrieb Pavel Sanda : > > Stephan Witt wrote: >> commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 >> Author: Stephan Witt >> Date: Sat Jun 11 09:56:35 2016 +0200 >> >>Add missing includes after change to boost signals2 >> >> diff --git a/src/Server.h b/src/Server.h >

Re: [LyX/master] unique_ptr and make_unique

Le 09/06/2016 15:23, Guillaume Munch a écrit : diff --git a/configure.ac b/configure.ac index 3353df4..52da6ce 100644 --- a/configure.ac +++ b/configure.ac @@ -130,6 +130,9 @@ AC_C_BIGENDIAN # Nice to have when an assertion triggers LYX_CHECK_CALLSTACK_PRINTING +# C++14 only +LYX_CHECK_DEF(m

Re: LyX 2.2.0 Linux Compilation Error

On 06/11/2016 12:32 AM, Guillaume Munch wrote: > Le 11/06/2016 04:40, Joel Kulesza a écrit : >> On Fri, Jun 10, 2016 at 3:56 PM, Richard Heck > > wrote: >> >> You could try adding: >> >> #include >> >> to support/filetools.cpp. >> >> >> Richard, thanks for the *q

Merge 2.2.2-staging?

If anyone would like to go ahead and merge 2.2.2-staging into 2.2.x, feel free to do so. I'd do it myself but am about to be away for a week for a conference and may not have the time. Richard

Re: [LyX/master] Correct path names were to look for RPM based dictionaries for hunspell on Linux.

On 06/11/2016 06:11 AM, Stephan Witt wrote: > Am 29.05.2016 um 23:56 schrieb Richard Heck : >> commit 3a2fc1595b316e0847d25b0604ec9188d953af01 >> Author: Stephan Witt >> Date: Tue May 10 18:06:48 2016 +0200 >> >>Correct path names were to look for RPM based dictionaries for hunspell >> on L

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

On Sat, Jun 11, 2016 at 07:30:55PM -0400, Scott Kostyshak wrote: > On Sun, Jun 12, 2016 at 12:23:18AM +0200, Kornel Benko wrote: > > Am Samstag, 11. Juni 2016 um 18:12:20, schrieb Scott Kostyshak > > > > > > Attached is the diff to my config.h > > > > There are clearly differences. > > > > For in

Re: [PATCH] unique_ptr and some clean-up

Le 12/06/2016 00:58, Pavel Sanda a écrit : Guillaume Munch wrote: I do not clearly see the situation wrt gcc 4.6. Which are the distributions that currently lack gcc > 4.6 ? this is ubuntu 12.04.p I see. I has assumed g++-4.7 was there since there is gcc-4.7. How does clang fare?

Re: [PATCH] unique_ptr and some clean-up

Guillaume Munch wrote: > I do not clearly see the situation wrt gcc 4.6. Which are the > distributions that currently lack gcc > 4.6 ? this is ubuntu 12.04.p

Re: [PATCH] unique_ptr and some clean-up

Le 11/06/2016 21:05, Pavel Sanda a écrit : Jean-Marc Lasgouttes wrote: Le 07/06/2016 ?? 19:05, Guillaume Munch a écrit : It says that it picked the wrong constructor for the pair, that requires a copyable object. Which precise version of g++ 4.6 do you have? In 4.6.3 pairs accept movable objec

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

On Sun, Jun 12, 2016 at 12:23:18AM +0200, Kornel Benko wrote: > Am Samstag, 11. Juni 2016 um 18:12:20, schrieb Scott Kostyshak > > > > Attached is the diff to my config.h > > > There are clearly differences. > > > For instance the dest directory has to be "LYX_INSTALLED", not > > > "/usr/local/l

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

Am Samstag, 11. Juni 2016 um 18:12:20, schrieb Scott Kostyshak > > Attached is the diff to my config.h > > There are clearly differences. > > For instance the dest directory has to be "LYX_INSTALLED", not > > "/usr/local/lyx-master". > > I would check (with message(STATUS ...)) where this value

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

On Sat, Jun 11, 2016 at 11:20:34PM +0200, Kornel Benko wrote: > Am Samstag, 11. Juni 2016 um 16:57:40, schrieb Scott Kostyshak > > > On Sat, Jun 11, 2016 at 10:47:18PM +0200, Kornel Benko wrote: > > > Am Samstag, 11. Juni 2016 um 16:07:42, schrieb Scott Kostyshak > > > > > > > On Wed, Jun 08, 2

Re: Shorcut clashing Menu vs dialog in Qt5.6

Am Samstag, 11. Juni 2016 um 22:08:41, schrieb Jean-Pierre Chrétien > Le 11/06/2016 16:14, Kornel Benko a écrit : > > Am Samstag, 11. Juni 2016 um 15:24:32, schrieb Jean-Pierre Chrétien > > > > >> The shortcuts are different in another langage, I guess you can change > >> them in English wit

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

Am Samstag, 11. Juni 2016 um 16:57:40, schrieb Scott Kostyshak > On Sat, Jun 11, 2016 at 10:47:18PM +0200, Kornel Benko wrote: > > Am Samstag, 11. Juni 2016 um 16:07:42, schrieb Scott Kostyshak > > > > > On Wed, Jun 08, 2016 at 11:47:25AM +0200, Kornel Benko wrote: > > > > Am Mittwoch, 8. Juni

Re: commit 1e8b925c07b6 is "overfix"

On Fri, Jun 10, 2016 at 11:00:33AM +, Guenter Milde wrote: > On 2016-06-09, Scott Kostyshak wrote: > > On Thu, Jun 09, 2016 at 08:29:48PM +, Guenter Milde wrote: > >> On 2016-06-09, Scott Kostyshak wrote: > >> > On Thu, Jun 09, 2016 at 02:41:43PM +, Guenter Milde wrote: > > >> >> I did

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

On Sat, Jun 11, 2016 at 10:47:18PM +0200, Kornel Benko wrote: > Am Samstag, 11. Juni 2016 um 16:07:42, schrieb Scott Kostyshak > > > On Wed, Jun 08, 2016 at 11:47:25AM +0200, Kornel Benko wrote: > > > Am Mittwoch, 8. Juni 2016 um 09:36:05, schrieb Kornel Benko > > > > > > > commit 8019732b395fa

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

Am Samstag, 11. Juni 2016 um 16:07:42, schrieb Scott Kostyshak > On Wed, Jun 08, 2016 at 11:47:25AM +0200, Kornel Benko wrote: > > Am Mittwoch, 8. Juni 2016 um 09:36:05, schrieb Kornel Benko > > > commit 8019732b395faa9fafe3b4c644cb72143bdd5dd1 > > > Author: Kornel Benko > > > Date: Wed Jun 8

Re: [LyX/master] Add missing includes after change to boost signals2

Le 11/06/2016 22:30, Pavel Sanda a écrit : Stephan Witt wrote: commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 Author: Stephan Witt Date: Sat Jun 11 09:56:35 2016 +0200 Add missing includes after change to boost signals2 diff --git a/src/Server.h b/src/Server.h index 7aecde6..2c1162d 1

Re: [LyX/master] Add missing includes after change to boost signals2

Stephan Witt wrote: > commit e8b15b5f0cd216a342dbcaef7b9e90722bc99fc3 > Author: Stephan Witt > Date: Sat Jun 11 09:56:35 2016 +0200 > > Add missing includes after change to boost signals2 > > diff --git a/src/Server.h b/src/Server.h > index 7aecde6..2c1162d 100644 > --- a/src/Server.h > ++

Re: Shorcut clashing Menu vs dialog in Qt5.6

Le 11/06/2016 16:14, Kornel Benko a écrit : Am Samstag, 11. Juni 2016 um 15:24:32, schrieb Jean-Pierre Chrétien The shortcuts are different in another langage, I guess you can change them in English without affecting much the translators' work. Unless I did not understand the issue? You

Re: What Qt Version for 2.2.x?

Jean-Marc Lasgouttes wrote: > I really think we can use 4.8 as minimum for 2.3 at least. +1 Pavel

Re: [LyX/master] Cmake build: Check for QPA_XCB when QT_USES_X11 is known

On Wed, Jun 08, 2016 at 11:47:25AM +0200, Kornel Benko wrote: > Am Mittwoch, 8. Juni 2016 um 09:36:05, schrieb Kornel Benko > > commit 8019732b395faa9fafe3b4c644cb72143bdd5dd1 > > Author: Kornel Benko > > Date: Wed Jun 8 09:21:48 2016 +0200 > > > > Cmake build: Check for QPA_XCB when QT_US

Re: [PATCH] unique_ptr and some clean-up

Jean-Marc Lasgouttes wrote: > Le 07/06/2016 ?? 19:05, Guillaume Munch a écrit : > >> It says that it picked the wrong constructor for the pair, that requires >> a copyable object. Which precise version of g++ 4.6 do you have? In >> 4.6.3 pairs accept movable objects. Maybe it fails to generate the

Errors in lib/lyx2lyx/LyX.py with python3

All tests with lyx2lyx fail with: -- Executing /usr/bin/python3 /usr2/src/lyx/lyx-git/lib/lyx2lyx/lyx2lyx -e qwbwf -o 8dqNDg /usr2/src/lyx/lyx-git/lib/doc/Math.lyx Traceback (most recent call last): File "/usr2/src/lyx/lyx-git/lib/lyx2lyx/lyx2lyx", line 88, in main() File "/usr2/src/lyx/l

Re: CMake + clang failure

On Sat, Jun 11, 2016 at 01:07:45PM +0200, Stephan Witt wrote: > Am 11.06.2016 um 12:28 schrieb Kornel Benko : > > > > Am Samstag, 11. Juni 2016 um 11:57:07, schrieb Georg Baum > > > >> Kornel Benko wrote: > >> > >>> I have a check for regex, what about the attached? > >>> 1.) Determine if 'rege

Re: Shorcut clashing Menu vs dialog in Qt5.6

Am Samstag, 11. Juni 2016 um 15:24:32, schrieb Jean-Pierre Chrétien > > Le 11 juin 2016 13:10:22 CEST, Kornel Benko a écrit : > >Am Samstag, 11. Juni 2016 um 12:53:02, schrieb Jean-Marc Lasgouttes > > > > >> > >> I am not that sure. We could also choose other shortcuts in the aF&R > >> panel

Re: CMake + clang failure

Am 11.06.2016 um 13:33 schrieb Kornel Benko : > > Am Samstag, 11. Juni 2016 um 13:07:45, schrieb Stephan Witt >> Am 11.06.2016 um 12:28 schrieb Kornel Benko : >>> >>> Am Samstag, 11. Juni 2016 um 11:57:07, schrieb Georg Baum >>> Kornel Benko wrote: > I have a check for regex, wh

Re: Shorcut clashing Menu vs dialog in Qt5.6

Le 11 juin 2016 13:10:22 CEST, Kornel Benko a écrit : >Am Samstag, 11. Juni 2016 um 12:53:02, schrieb Jean-Marc Lasgouttes > >> >> I am not that sure. We could also choose other shortcuts in the aF&R >> panel, especially since the menu can be used when using aF&R >> >> JMarc > >True, but tha

Re: CMake + clang failure

Am Samstag, 11. Juni 2016 um 13:07:45, schrieb Stephan Witt > Am 11.06.2016 um 12:28 schrieb Kornel Benko : > > > > Am Samstag, 11. Juni 2016 um 11:57:07, schrieb Georg Baum > > > >> Kornel Benko wrote: > >> > >>> I have a check for regex, what about the attached? > >>> 1.) Determine if 'regex

Re: Shorcut clashing Menu vs dialog in Qt5.6

Le 11/06/16 à 13:10, Kornel Benko a écrit : True, but that is 1.) a workaround and not a real cure 2.) we have to check _many_ dialogs 3.) forces lot of translation changes. For translators it is difficult to simultaneously check shortcut clashes for menu _and_ dialog. It is hard enough if you

Re: Shorcut clashing Menu vs dialog in Qt5.6

Am Samstag, 11. Juni 2016 um 12:53:02, schrieb Jean-Marc Lasgouttes > Le 11/06/16 à 03:57, Scott Kostyshak a écrit : > > On Fri, Jun 10, 2016 at 01:02:59PM +0200, Kornel Benko wrote: > >> We still have this Shorcut clashing for some combinations. > >> > >> For instance in english GUI we have menu

Re: CMake + clang failure

Am 11.06.2016 um 12:28 schrieb Kornel Benko : > > Am Samstag, 11. Juni 2016 um 11:57:07, schrieb Georg Baum > >> Kornel Benko wrote: >> >>> I have a check for regex, what about the attached? >>> 1.) Determine if 'regex-source' compiles in FindCXX11Compiler.cmake >>> 2.) Use the value in case of

Re: Shorcut clashing Menu vs dialog in Qt5.6

Le 11/06/16 à 03:57, Scott Kostyshak a écrit : On Fri, Jun 10, 2016 at 01:02:59PM +0200, Kornel Benko wrote: We still have this Shorcut clashing for some combinations. For instance in english GUI we have menu shortcuts &File, &Edit, &Insert, &Navigate, &Document, &Tools, &Help, and in

Re: LyX 2.2.0 Linux Compilation Error

Le 10/06/16 à 23:56, Richard Heck a écrit : You could try adding: #include to support/filetools.cpp. Why not use instead? I am not sure what the difference is, but using the C++ version sounds better. JMarc

Re: CMake + clang failure

Am Samstag, 11. Juni 2016 um 11:57:07, schrieb Georg Baum > Kornel Benko wrote: > > > I have a check for regex, what about the attached? > > 1.) Determine if 'regex-source' compiles in FindCXX11Compiler.cmake > > 2.) Use the value in case of 'clang' in CMakeLists.txt > > Perfect, thanks a lot!

Re: [LyX/master] Correct path names were to look for RPM based dictionaries for hunspell on Linux.

Am 29.05.2016 um 23:56 schrieb Richard Heck : > > commit 3a2fc1595b316e0847d25b0604ec9188d953af01 > Author: Stephan Witt > Date: Tue May 10 18:06:48 2016 +0200 > >Correct path names were to look for RPM based dictionaries for hunspell on > Linux. > > diff --git a/src/HunspellChecker.cpp

Re: [LyX/master] Autotools: restore deprecation warning

Am 11.06.2016 um 10:11 schrieb Georg Baum : > > Stephan Witt wrote: > >> Now we have a linker problem: >> >> CXXLDlyx >> clang: error: no such file or directory: '../3rdparty/boost/liblyxboost.a' >> make[4]: *** [lyx] Error 1 >> make[3]: *** [all-recursive] Error 1 >> make[2]: *** [all] Err

Re: CMake + clang failure

Kornel Benko wrote: > I have a check for regex, what about the attached? > 1.) Determine if 'regex-source' compiles in FindCXX11Compiler.cmake > 2.) Use the value in case of 'clang' in CMakeLists.txt Perfect, thanks a lot! > Maybe we should use this value unconditionally? This would depend on h

Re: What Qt Version for 2.2.x?

Le 11/06/2016 10:35, Jean-Marc Lasgouttes a écrit : I really think we can use 4.8 as minimum for 2.3 at least. Of course, the patch is for stable. Waiting Richard's reply to commit.

Re: CMake + clang failure

Am Samstag, 11. Juni 2016 um 10:36:47, schrieb Georg Baum > Kornel Benko wrote: > > > OK, but my second question is not answered. To what value should > > LYX_USE_STD_REGEX be set? > > It should be autodetected. The algorithm of autotools is: > > detect presence of . If available and compiler is

Re: What Qt Version for 2.2.x?

I really think we can use 4.8 as minimum for 2.3 at least. JMarc Le 11 juin 2016 06:22:30 GMT+02:00, Guillaume Munch a écrit : >Le 11/06/2016 05:13, Richard Heck a écrit : >> >> The INSTALL file says that one can use Qt as far back as 4.5.0. But >we >> use QFont::Monospace in GuiApplication.cpp

Re: "Reconfigure" gives an error

Andrew Parsloe wrote: > On 11/06/2016 5:32 p.m., CarLaTeX wrote: >> Hi LyX developers, >> >> I've installed LyX 2.2.0 on Windows 10 (distribution for LaTeX: MiKTeX >> 2.9). >> When I use "Tools > Reconfigure" I get this error: >> Immagine incorporata 2 >> I try to translate in English: "platex.exe

Re: CMake + clang failure

Kornel Benko wrote: > OK, but my second question is not answered. To what value should > LYX_USE_STD_REGEX be set? It should be autodetected. The algorithm of autotools is: detect presence of . If available and compiler is clang, use std::regex. This is however not 100% correct: If clang is u

Re: "Reconfigure" gives an error

On 11/06/2016 5:32 p.m., CarLaTeX wrote: Hi LyX developers, I've installed LyX 2.2.0 on Windows 10 (distribution for LaTeX: MiKTeX 2.9). When I use "Tools > Reconfigure" I get this error: Immagine incorporata 2 I try to translate in English: "platex.exe - Impossible to find an entry point .

Re: CMake + clang failure

Am Samstag, 11. Juni 2016 um 09:58:59, schrieb Georg Baum > Kornel Benko wrote: > > > Should we really ignore output of '${CMAKE_CXX_COMPILER} -dumpversion'? > > In case of clang yes, since clang outputs an arbitrary number which has > nothing to do with the clang version. Sooner or later we w

Re: [LyX/master] Autotools: restore deprecation warning

Stephan Witt wrote: > Now we have a linker problem: > > CXXLDlyx > clang: error: no such file or directory: '../3rdparty/boost/liblyxboost.a' > make[4]: *** [lyx] Error 1 > make[3]: *** [all-recursive] Error 1 > make[2]: *** [all] Error 2 > make[1]: *** [all-recursive] Error 1 > make: *** [

Re: LyX 2.2.0 Linux Compilation Error

Joel Kulesza wrote: > I have gcc 4.6.1, 4.7.0, 4.7.2, 4.8.2, 4.9.2, and 5.3.0 available. Are > any > of those known to be particularly successful with this vintage of Qt? If > not, I'm afraid I'll be without 2.2.0 on this system (I am not the admin > so simply installing a package isn't an optio

Re: [LyX/master] Autotools: restore deprecation warning

Am 11.06.2016 um 09:40 schrieb Stephan Witt : > > Am 11.06.2016 um 09:30 schrieb Georg Baum : >> >> Stephan Witt wrote: >> >>> Yes. The problem is trying to create an empty archive, IMO. >> >> Indeed. On linuyx ar does not complain about that, so I did not notice. I >> moved the disabling of t

Re: CMake + clang failure

Kornel Benko wrote: > Should we really ignore output of '${CMAKE_CXX_COMPILER} -dumpversion'? In case of clang yes, since clang outputs an arbitrary number which has nothing to do with the clang version. Sooner or later we will need clang version tests as well (and then we will need to figure o

Re: CMake + clang failure

Am Samstag, 11. Juni 2016 um 08:25:58, schrieb Georg Baum > Guillaume Munch wrote: > > > Le 11/06/2016 03:00, Scott Kostyshak a écrit : > >> -- Using GCC version 4.2.1 > >> CMake Error at CMakeLists.txt:267 (message): > >>gcc >= 4.3 is required. > > > > From INSTALL: > > > >First of all,

Re: [LyX/master] Autotools: restore deprecation warning

Am 11.06.2016 um 09:30 schrieb Georg Baum : > > Stephan Witt wrote: > >> Yes. The problem is trying to create an empty archive, IMO. > > Indeed. On linuyx ar does not complain about that, so I did not notice. I > moved the disabling of the build one directory up, please try whether it > works

Re: [LyX/master] Autotools: restore deprecation warning

Stephan Witt wrote: > Yes. The problem is trying to create an empty archive, IMO. Indeed. On linuyx ar does not complain about that, so I did not notice. I moved the disabling of the build one directory up, please try whether it works now. Georg

Re: [LyX/master] Autotools: restore deprecation warning

Jean-Marc Lasgouttes wrote: > Le 09/06/2016 à 22:32, Georg Baum a écrit : >> Jean-Marc Lasgouttes wrote: >> >>> Le 09/06/16 à 20:47, Georg Baum a écrit : This causes a warning in boost: ../../../3rdparty/boost/libs/signals/src/signal_base.cpp:136:37: warning: ‘auto_ptr’ is