Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jürgen Spitzmüller
Am Donnerstag 23 Juli 2015, 00:43:35 schrieb Jean-Marc Lasgouttes: > Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : > > Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 > > of the User Guide, for instance (see attached screenshot). > > OK, try again now. Let's see how i

Re: Norwegian translation for 2.1.4 (nb.po)

2015-07-22 Thread Helge Hafting
Den 21. juli 2015 05:19, skrev Pavel Sanda: Helge Hafting wrote: Compressed nb.po attached. It compiles, and has more translations now. Especially the new pdf-comments & colorbox stuff. I hope it is in time for 2.1.4 - I am on a holiday and this was the best I could do. Helge Hafting Hi Helg

Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2015 17:42, Jürgen Spitzmüller a écrit : Yes, this is with recent master. I can easily reproduce it with sec 2.5.1 of the User Guide, for instance (see attached screenshot). OK, try again now. Let's see how it fares. JMarc

Re: LyXHTML in 2.1

2015-07-22 Thread Richard Heck
On 07/22/2015 01:51 PM, Pavel Sanda wrote: Richard Heck wrote: On 07/22/2015 11:54 AM, Pavel Sanda wrote: Richard Heck wrote: sure it is safe. But someone else should have a quick look. I'm always nervous about accessing things in the destructor. Looks correct to me. I would perhaps add comme

Re: LyXHTML in 2.1

2015-07-22 Thread Pavel Sanda
Richard Heck wrote: > On 07/22/2015 11:54 AM, Pavel Sanda wrote: >> Richard Heck wrote: >>> sure it is safe. But someone else should have a quick look. I'm always >>> nervous about accessing things in the destructor. >> Looks correct to me. I would perhaps add comment to dtor why we don't >> delete

Re: Word wrapping problem

2015-07-22 Thread Scott Kostyshak
On Mon, Jul 20, 2015 at 8:18 PM, Scott Kostyshak wrote: > On Mon, Jul 20, 2015 at 5:10 PM, Yihui Xie wrote: >> Thanks! I'm interested in testing this, but I have not built LyX from >> source for a couple of years... I'd love to test it after it is >> available in a future release. > > When it mak

Re: LyXHTML in 2.1

2015-07-22 Thread Richard Heck
On 07/22/2015 11:54 AM, Pavel Sanda wrote: Richard Heck wrote: sure it is safe. But someone else should have a quick look. I'm always nervous about accessing things in the destructor. Looks correct to me. I would perhaps add comment to dtor why we don't delete the images. Yes, good idea. rh

Re: LyXHTML in 2.1

2015-07-22 Thread Pavel Sanda
Richard Heck wrote: > sure it is safe. But someone else should have a quick look. I'm always > nervous about accessing things in the destructor. Looks correct to me. I would perhaps add comment to dtor why we don't delete the images. Pavel

Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2015 13:34, Jürgen Spitzmüller a écrit : Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: I fixed this problem. Now I am interested in any row-breaking behavior that does not sound good. It breaks between xref inset and closing bracket, e.g. in "(for details, cf. [XRef

Re: [RFC] Fun with newlines

2015-07-22 Thread Richard Heck
On 07/22/2015 06:05 AM, Jean-Marc Lasgouttes wrote: Now for something different... I have been annoyed by the looks of InsetNewLine for some time now. The following patch replaces the horrible hand-made arrow with a nice Unicode character. Not only that, but you have 3 different characters to

Re: LyXHTML in 2.1

2015-07-22 Thread Richard Heck
So the problem is one I've seen several times. The png files are generated, but then by the time we preview the document, they are gone. This is because (a) when the PreviewLoader for a Buffer is deleted, it removes all its previews and (b) we export in a clone, so that Buffer gets deleted be

Re: LyXHTML in 2.1

2015-07-22 Thread Richard Heck
On 07/21/2015 09:29 PM, Pavel Sanda wrote: Enrico Forestieri wrote: On Tue, Jul 21, 2015 at 02:04:25PM -0700, Pavel Sanda wrote: Changed Instant Preview could be the origin of this problem indeed. Hardly so, given that it seems to also occur with 2.1.3. First commit when I stop see correct re

Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jürgen Spitzmüller
Am Mittwoch 22 Juli 2015, 11:55:32 schrieb Jean-Marc Lasgouttes: > I fixed this problem. Now I am interested in any row-breaking behavior > that does not sound good. It breaks between xref inset and closing bracket, e.g. in "(for details, cf. [XRef Inset])." Jürgen

Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2015 09:40, Jean-Marc Lasgouttes a écrit : Are you interested in *any* difference in behavior I notice when testing? For example, if a linebreak is at a different (but still sensible) place than it was before? No, because I am not sure that my row breaking after str-metrics was sensibl

Re: About the rowpainter2 branch (testers, have a look!)

2015-07-22 Thread Jean-Marc Lasgouttes
Le 22/07/2015 05:56, Scott Kostyshak a écrit : On Tue, Jul 21, 2015 at 6:04 PM, Jean-Marc Lasgouttes wrote: I landed in master now. I could be imagining things, but scrolling feels smoother to me. Yes it should. The number of QPainter::drawText calls is reduced a lot (but the strings are

Re: LyXHTML in 2.1

2015-07-22 Thread Enrico Forestieri
On Tue, Jul 21, 2015 at 06:29:05PM -0700, Pavel Sanda wrote: > Enrico Forestieri wrote: > > On Tue, Jul 21, 2015 at 02:04:25PM -0700, Pavel Sanda wrote: > > > > > > Changed Instant Preview could be the origin of this problem indeed. > > > > Hardly so, given that it seems to also occur with 2.1.3.