So the problem is one I've seen several times. The png files are generated, but then by the time we preview the document, they are gone. This is because (a) when the PreviewLoader for a Buffer is deleted, it removes all its previews and (b) we export in a clone, so that Buffer gets deleted before the preview is actually shown.

I've committed a fix to master. I'd like to get this into 2.1.4. Some version of this code would have been in what Abdel changed, so I'm pretty sure it is safe. But someone else should have a quick look. I'm always nervous about accessing things in the destructor.

Richard


On 07/22/2015 10:36 AM, Richard Heck wrote:
On 07/21/2015 09:29 PM, Pavel Sanda wrote:
Enrico Forestieri wrote:
On Tue, Jul 21, 2015 at 02:04:25PM -0700, Pavel Sanda wrote:
Changed Instant Preview could be the origin of this problem indeed.
Hardly so, given that it seems to also occur with 2.1.3.
First commit when I stop see correct rendering in HTML is caused by 850e4d80c0 (compilable only after c57dc6411). However the error looks somewhat different than in current code, because there I see broken link in html,
while in 2.1 I see 'Equation' label.

There are only 'skip'ped commits left to test.
The first bad commit could be any of:
850e4d80c0ec8df578c4ab5d73952e435141b7d6
c57dc64116d8d1beb87a6b76a54cfcf82314259a
We cannot bisect more!

commit 850e4d80c0ec8df578c4ab5d73952e435141b7d6
Author: Abdelrazak Younes <you...@lyx.org>
Date:   Tue Jul 12 12:43:11 2011 +0000

     Graphics cleanup: get rid of Previews.{h,cpp}
The PreviewLoader is created directly by Buffer on demand. The PreviewLoader cache was complex and unneeded because there is one and only one PreviewLoader per Buffer.
          commit c57dc64116d8d1beb87a6b76a54cfcf82314259a
Author: Abdelrazak Younes <you...@lyx.org>
Date:   Tue Jul 12 13:41:42 2011 +0000

     gcc compile fix.

Fortunately, those are only two commits. It must presumably have been the former.

Richard


Reply via email to