Re: Warning in GuiBox.cpp

2015-05-12 Thread Uwe Stöhr
Am 12.05.2015 um 11:01 schrieb Jean-Marc Lasgouttes: It seem that there is another parenthesing problem. I won't touch it because I do not know what the intended logic is. Thanks JMarc, I improved the logic in http://www.lyx.org/trac/changeset/858c12c6bb850b7ed7a708e3e66fd58ba6f06cb9/lyxgit

[patch] better color support in character dialog

2015-05-12 Thread Uwe Stöhr
Dear LyXers, it annoyed me a long time that LyX does only provide the most basic colors in the character dialog and that these colors are not even displayed there. (For example I use the color "lime" quite frequently and had therefore to use TeX code.) I thought about this and offering all p

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-12 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Le 10/05/2015 18:29, Georg Baum a écrit : >> Sorry, I should have tried before asking. Of course there were not all >> needed backports done yet. The attached version is the minimal I could >> find. >> >> I had include the removal of LYX_PROG_CXX_WORKS, otherwise auto

Re: Signature of InsetTOC::makeTOC(With|No)Depth

2015-05-12 Thread Jean-Marc Lasgouttes
I am used to expect only the best from you :) JMarc Le 12 mai 2015 18:49:17 CEST, Richard Heck a écrit : >On 05/12/2015 11:08 AM, Jean-Marc Lasgouttes wrote: >> Le 12/05/2015 15:55, Richard Heck a écrit : >>> No, definitely an oversight. It works only because the output stream >>> containined i

Re: Signature of InsetTOC::makeTOC(With|No)Depth

2015-05-12 Thread Richard Heck
On 05/12/2015 11:08 AM, Jean-Marc Lasgouttes wrote: Le 12/05/2015 15:55, Richard Heck a écrit : No, definitely an oversight. It works only because the output stream containined in XHTMLStream is a reference. I'll fix it. And what about the Toc object? You really are demanding, aren't you? ;

Re: Signature of InsetTOC::makeTOC(With|No)Depth

2015-05-12 Thread Jean-Marc Lasgouttes
Le 12/05/2015 15:55, Richard Heck a écrit : No, definitely an oversight. It works only because the output stream containined in XHTMLStream is a reference. I'll fix it. And what about the Toc object? JMarc

Re: Signature of InsetTOC::makeTOC(With|No)Depth

2015-05-12 Thread Richard Heck
On 05/12/2015 05:06 AM, Jean-Marc Lasgouttes wrote: Hi Richard, Coverity points out that these two methods pass XHTMLStream and Toc objects by value and not by address. Is this intentional? It seems hazardous, especially in the XHTMLStream case. /// void makeTOCWithDepth(XHTMLStream

Re: [PATCH] Improve list of available languages for UI l10n.

2015-05-12 Thread Kornel Benko
Am Dienstag, 12. Mai 2015 um 15:03:58, schrieb Jean-Marc Lasgouttes > Le 12/05/2015 14:36, Jürgen Spitzmüller a écrit : > > 2015-05-12 10:37 GMT+02:00 Jean-Marc Lasgouttes: > > > > Concerning the ordering of languages, seriously the current ordering > > is just broken, and I think that or

Re: [PATCH] Improve list of available languages for UI l10n.

2015-05-12 Thread Jürgen Spitzmüller
2015-05-12 15:03 GMT+02:00 Jean-Marc Lasgouttes: > Le 12/05/2015 14:36, Jürgen Spitzmüller a écrit : > >> 2015-05-12 10:37 GMT+02:00 Jean-Marc Lasgouttes: >> >> Concerning the ordering of languages, seriously the current ordering >> is just broken, and I think that ordering by GUIName is m

Re: [PATCH] Improve list of available languages for UI l10n.

2015-05-12 Thread Jean-Marc Lasgouttes
Le 12/05/2015 14:36, Jürgen Spitzmüller a écrit : 2015-05-12 10:37 GMT+02:00 Jean-Marc Lasgouttes: Concerning the ordering of languages, seriously the current ordering is just broken, and I think that ordering by GUIName is much more useful for a human editor. Hm, ordering by lyx na

Re: [LyX/master] Fix build with GNU libstdc++ C++11 ABI

2015-05-12 Thread Jean-Marc Lasgouttes
Le 10/05/2015 18:29, Georg Baum a écrit : Sorry, I should have tried before asking. Of course there were not all needed backports done yet. The attached version is the minimal I could find. I had include the removal of LYX_PROG_CXX_WORKS, otherwise autoconf would complain about expanding a macro

Signature of InsetTOC::makeTOC(With|No)Depth

2015-05-12 Thread Jean-Marc Lasgouttes
Hi Richard, Coverity points out that these two methods pass XHTMLStream and Toc objects by value and not by address. Is this intentional? It seems hazardous, especially in the XHTMLStream case. /// void makeTOCWithDepth(XHTMLStream xs, Toc toc, const OutputParams & op) const;

Warning in GuiBox.cpp

2015-05-12 Thread Jean-Marc Lasgouttes
Hi Uwe, It seem that there is another parenthesing problem. I won't touch it because I do not know what the intended logic is. JMarc CXXGuiBox.o ../../../../master/src/frontends/qt4/GuiBox.cpp: In member function ‘virtual bool lyx::frontend::GuiBox::checkWidgets(bool) const’: ../../../

Re: [PATCH] Improve list of available languages for UI l10n.

2015-05-12 Thread Jean-Marc Lasgouttes
Le 11/05/2015 21:02, Stephan Witt a écrit : Am 11.05.2015 um 17:18 schrieb Jürgen Spitzmüller : This solution strikes me odd. The languages file is for document languages support. Having it to be ordered for GUI language purposes just does not feel right. +1 I would rather create a separat