Re: Fix compiler warnings in pedantic mode

2010-12-15 Thread Stephan Witt
Am 15.12.2010 um 23:16 schrieb Jean-Marc Lasgouttes: > Le 15/12/2010 22:36, Stephan Witt a écrit : >> I tried to compile LyX with -pedantic option. >> >> Most warnings are easy to fix. See the attached patch. > > The patch looks correct, except for some of the casts in .m files (but > they can p

Re: Fix compiler warnings in pedantic mode

2010-12-15 Thread Stephan Witt
Am 16.12.2010 um 00:44 schrieb Pavel Sanda: > Stephan Witt wrote: >> Index: src/frontends/Clipboard.h >> === >> --- src/frontends/Clipboard.h(Revision 36891) >> +++ src/frontends/Clipboard.h(Arbeitskopie) >> @@ -39,7 +

Proposal for LyX performance problems when outliner is opened

2010-12-15 Thread Pavel Sanda
hi, the attached patch has profound impact on the speed of moving with cursor and typing as well. at least here. if you wonder how to reproduce the slowness problems on your box, try to open user guide, set the nesting on deepest level and try to type fastly or move with cursor, maybe you'll be l

Re: r36896 - lyx-devel/trunk/src

2010-12-15 Thread Pavel Sanda
Abdelrazak Younes wrote: > Pavel, I should have probably requested your approval before doing that, > sorry about that. But the patches are iterative and mechanicals. I am very > cautious and I check that all help files produce identical latex after each > changes. > > The reason I am doing that

Re: r36896 - lyx-devel/trunk/src

2010-12-15 Thread Abdelrazak Younes
On 16/12/2010 00:39, you...@lyx.org wrote: Author: younes Date: Thu Dec 16 00:39:38 2010 New Revision: 36896 URL: http://www.lyx.org/trac/changeset/36896 Log: Split TeXEnvironment() in three functions. The real optimisation is yet to come. Pavel, I should have probably requested your approval

Re: Fix compiler warnings in pedantic mode

2010-12-15 Thread Pavel Sanda
Stephan Witt wrote: > Index: src/frontends/Clipboard.h > === > --- src/frontends/Clipboard.h (Revision 36891) > +++ src/frontends/Clipboard.h (Arbeitskopie) > @@ -39,7 +39,7 @@ > LinkBackGraphicsType, > EmfG

Re: Fix compiler warnings in pedantic mode

2010-12-15 Thread Enrico Forestieri
On Wed, Dec 15, 2010 at 11:16:34PM +0100, Jean-Marc Lasgouttes wrote: > Le 15/12/2010 22:36, Stephan Witt a écrit : > >I tried to compile LyX with -pedantic option. > > > >Most warnings are easy to fix. See the attached patch. > > The patch looks correct, except for some of the casts in .m files (

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 23:12, Jean-Marc Lasgouttes wrote: Le 15/12/2010 18:51, Abdelrazak Younes a écrit : It seems correct. At the time I remember saying to myself that using std::distance was not optimal and that we should use some new fast method in RandomAccessList but I did not bother because it was

Re: r36895 - lyx-devel/trunk/src

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 23:02, Vincent van Ravesteijn wrote: On Wed, Dec 15, 2010 at 10:48 PM, wrote: Author: younes Date: Wed Dec 15 22:48:00 2010 New Revision: 36895 URL: http://www.lyx.org/trac/changeset/36895 Log: get rid of TeXDeeper: this was hiding the recursiveness of TeXEnvironment without any

Re: Fix compiler warnings in pedantic mode

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 22:36, Stephan Witt a écrit : I tried to compile LyX with -pedantic option. Most warnings are easy to fix. See the attached patch. The patch looks correct, except for some of the casts in .m files (but they can probably not be avoided). But one isn't that easy: src/frontends/q

Re: std::distance and RandomAccessList

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 18:59, Abdelrazak Younes a écrit : Actually, there is a very simple and effective improvement that I am going to put in trunk: TeXOnePar() always return the next pit! There is absolutely no need to recompute the distance each time. This is a remnant of the past I guess. You mean

Re: std::distance and RandomAccessList

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 18:51, Abdelrazak Younes a écrit : It seems correct. At the time I remember saying to myself that using std::distance was not optimal and that we should use some new fast method in RandomAccessList but I did not bother because it was fast enough. So it is not fast enough for this us

Re: r36895 - lyx-devel/trunk/src

2010-12-15 Thread Vincent van Ravesteijn
On Wed, Dec 15, 2010 at 10:48 PM, wrote: > Author: younes > Date: Wed Dec 15 22:48:00 2010 > New Revision: 36895 > URL: http://www.lyx.org/trac/changeset/36895 > > Log: > get rid of TeXDeeper: this was hiding the recursiveness of TeXEnvironment > without any real benefits. This will allow furthe

Fix compiler warnings in pedantic mode

2010-12-15 Thread Stephan Witt
I tried to compile LyX with -pedantic option. Most warnings are easy to fix. See the attached patch. But one isn't that easy: src/frontends/qt4/GuiProgressView.cpp: In member function 'void lyx::frontend::GuiProgressView::debugSelectionChanged()': src/frontends/qt4/GuiProgressView.cpp:149: warn

Re: #7172: Lyx crashes when "Advanced replace" reaches the end of the document

2010-12-15 Thread Anders Lund
Hi, lyx crashes when the search/replace function reaches the end of the document, replacing math: R_C with R_\mathrm{C} in mathmode. Cheers Anders 2010/12/15 LyX Ticket Tracker > #7172: Lyx crashes when "Advanced replace" reaches the end of the document > > -+

Re: LyX on gitorious

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 18:57, Vincent van Ravesteijn wrote: On Wed, Dec 15, 2010 at 4:53 PM, Abdelrazak Younes wrote: Hi Vincent, I would like to create a new branch there for my toolbar-settings patch but the repo is not up to date. As I am not familiar with git svn could you please send your recipe t

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones who would be doing the editing are less than tec

Re: std::distance and RandomAccessList

2010-12-15 Thread Abdelrazak Younes
On 15/12/2010 18:51, Abdelrazak Younes wrote: On 15/12/2010 18:17, Jean-Marc Lasgouttes wrote: Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones

Re: std::distance and RandomAccessList (was: Re: Extreme speed difference between 1.4.5.1 and 1.6.8)

2010-12-15 Thread Liviu Andronic
On Wed, Dec 15, 2010 at 6:17 PM, Jean-Marc Lasgouttes wrote: > Duplicating the problem should be as simple as creating a 1800 pages > document IMO. I think at some time there was a document anonymizer for lyx > files (replacing all text by xxx xxx). Does this thing exist? It would be a > nice way

std::distance and RandomAccessList (was: Re: Extreme speed difference between 1.4.5.1 and 1.6.8)

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 17:54, Michael Joyner a écrit : One of our initial goals was to try and maintain an easy to edit file format should the internal customers need to "tweak" any of the outputs. The ones who would be doing the editing are less than technically inclined. Michael kindly sent to me an

LyX on gitorious

2010-12-15 Thread Abdelrazak Younes
Hi Vincent, I would like to create a new branch there for my toolbar-settings patch but the repo is not up to date. As I am not familiar with git svn could you please send your recipe to rebase git master from svn trunk? Thanks in advance, Abdel.

Re: r36891 - lyx-devel/trunk/lib/layouts

2010-12-15 Thread rgheck
On 12/15/2010 10:30 AM, rgh...@lyx.org wrote: Author: rgheck Date: Wed Dec 15 16:30:25 2010 New Revision: 36891 URL: http://www.lyx.org/trac/changeset/36891 Log: The letter class supports quote, quotation, and verse, and surely the ---Separator--- might be wanted. This would also be good f

Re: [RFC] and [patch] - support to define header /footer lines

2010-12-15 Thread Richard Heck
On 12/15/2010 08:43 AM, Helge Hafting wrote: How about defining custom Insets instead of styles? This would put the new objects in a less prominent place (i.e. not interfering with the "normal" styles), clearly mark the as something special and also allow to minimize the header boxes. Intere

Re: [RFC] and [patch] - support to define header /footer lines

2010-12-15 Thread Helge Hafting
On 13. des. 2010 22:04, Guenter Milde wrote: On 2010-12-13, Helge Hafting wrote: On 13. des. 2010 13:16, Helge Hafting wrote: On 23. sep. 2010 03:50, Uwe Stöhr wrote: The only disadvantage being that the module will now add 18 new paragraph types instead of 6 (or 12). How about defining cu

Re: generate PDF comments (was 'Re: LyX and editors?')

2010-12-15 Thread Liviu Andronic
On Wed, Dec 15, 2010 at 12:43 PM, Liviu Andronic wrote: >> If there were a way to make them appear in the pdf output that would be a >> great help. >> > I agree with Ehud that it would be great to have a 'Balloon' note > inset that would insert the containing text as PDF balloony comments. > Can L

generate PDF comments (was 'Re: LyX and editors?')

2010-12-15 Thread Liviu Andronic
On Wed, Dec 15, 2010 at 12:34 PM, ehud.kap...@gmail.com wrote: > Collaborating with non-Lyx users is a problem for me as well, because I > often want to > use comments (like PostIt notes), but when the Lyx source is exported to > pdf, the notes do not appear. > You can use greyedout notes, but it'

Re: r36884 - in lyx-devel/trunk: lib/layouts src/insets

2010-12-15 Thread Jean-Marc Lasgouttes
Le 15/12/2010 00:22, Abdelrazak Younes a écrit : Question: Should we just remove InsetNote::setButtonLabel() now? The only purpose it is serving is to provide a backup in case no label is defined. IMHO yes. Lots of code could be removed in insets if we used the layout stuff more... +1 JMarc