Re: r33408 - in lyx-devel/branches/BRANCH_1_6_X: . src/frontends/qt4

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 08:31 PM, Andre Poenitz wrote: +namespace { + +string const guiErrorType(string const s) +{ + if (s == "docbook") + return N_("DocBook"); + else if (s == "literate") + return N_("Literate"); + else if (s == "platex") + retu

Re: r33408 - in lyx-devel/branches/BRANCH_1_6_X: . src/frontends/qt4

2010-02-10 Thread Jürgen Spitzmüller
Andre Poenitz wrote: > Why a copy and not a string const & ? > > [Also, I personally prefer no 'else' after a 'return'. But we don't have > a rule about that] Thanks, I'll change that. Jürgen

Re: [patch] implement multirow support - request for help

2010-02-10 Thread Uwe Stöhr
Hello Edwin, I put the patch into trunk: http://www.lyx.org/trac/changeset/33414 I think that this is the best solution for now, because all major parts are working and we aren't introducing regressions. I listed the remaining issues here: http://wiki.lyx.org/Devel/Multirow The only major pro

Re: r33408 - in lyx-devel/branches/BRANCH_1_6_X: . src/frontends/qt4

2010-02-10 Thread Andre Poenitz
On Wed, Feb 10, 2010 at 12:42:52PM +0100, sp...@lyx.org wrote: > Author: spitz > Date: Wed Feb 10 12:42:52 2010 > New Revision: 33408 > URL: http://www.lyx.org/trac/changeset/33408 > > Log: > * GuiErrorList.cpp: > - use GUIfied strings (bug 6397). > > Modified: >lyx-devel/branches/BRANC

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 02:56 PM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Hum, no, I disagree here. This is about the float type as seen in the the float inset label so this is the buffer language. But we do not use buffer language in dialogs. The menu also uses the UI language (actu

Re: [patch] implement multirow support - request for help

2010-02-10 Thread Uwe Stöhr
Uwe Stöhr schrieb: However there are many other minor issues to solve: - The content of the multirow is not horizontally centered Sorry again, the horizontal alignment is a special issue that can be implemented later. I meant the vertical alignment: Contents of multirow cells are always ver

Re: [patch] implement multirow support - request for help

2010-02-10 Thread Edwin Leuven
Uwe Stöhr wrote: You have done some additional simplifications. With your version, setting a multicolumn is no longer possible. Can you please have a look? works fine here However there are many other minor issues to solve: - The content of the multirow is not horizontally centered you mea

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 03:03 PM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: My point is exactly that: inset labels and dialog labels should be the same if we want the user to find his babies. So, either we change both, or none. Or simply remove that label. I find it not really helpful

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > My point is exactly that: inset labels and dialog labels should be the > same if we want the user to find his babies. > > So, either we change both, or none. Or simply remove that label. I find it not really helpful anyway. Jürgen

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 02:56 PM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Hum, no, I disagree here. This is about the float type as seen in the the float inset label so this is the buffer language. But we do not use buffer language in dialogs. The menu also uses the UI language (actu

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Hum, no, I disagree here. This is about the float type as seen in the > the float inset label so this is the buffer language. But we do not use buffer language in dialogs. The menu also uses the UI language (actually, I think the inset label also should use the UI lang

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 02:45 PM, Jürgen Spitzmüller wrote: younes wrote: Modified: lyx-devel/trunk/src/frontends/qt4/FloatPlacement.cpp === === --- lyx-devel/trunk/src/frontends/qt4/FloatPlacement.cppWed Feb 10 13:26:59

Re: r33411 - in lyx-devel/trunk/src: frontends/qt4 insets

2010-02-10 Thread Jürgen Spitzmüller
younes wrote: > Modified: lyx-devel/trunk/src/frontends/qt4/FloatPlacement.cpp > === > === --- lyx-devel/trunk/src/frontends/qt4/FloatPlacement.cppWed Feb > 10 13:26:59 2010(r33410) +++ > lyx-devel/trunk/src/f

Re: r33370 - in lyx-devel/trunk/src: . frontends/qt4 frontends/qt4/ui insets

2010-02-10 Thread Abdelrazak Younes
On 02/10/2010 08:19 AM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Should be OK now (untested). No, it's not. You cannot use params.type for that, because that's not flagged for translation. Have a look at InsetCollapsable::floatName(). OK, I'll do that. I have to fix th