On 02/10/2010 08:31 PM, Andre Poenitz wrote:
+namespace { + +string const guiErrorType(string const s) +{ + if (s == "docbook") + return N_("DocBook"); + else if (s == "literate") + return N_("Literate"); + else if (s == "platex") + return N_("pLaTeX"); + else if (s == "latex") + return N_("LaTeX"); + return s; +}Why a copy and not a string const& ?[Also, I personally prefer no 'else' after a 'return'. But we don't have a rule about that]
We should. Abdel.