Re: SVN1.5.2 revision 21899

2007-12-02 Thread Jürgen Spitzmüller
Mc Murtrie wrote: > On 03/12/2007, at 2:54 AM, Jürgen Spitzmüller wrote: > > So the attached changes are needed, Roger? > I certainly believe so. committed. Jürgen

Re: multicolumn trouble with LyX 1.5.x

2007-12-02 Thread Jürgen Spitzmüller
Ryan wrote: > When using the precompiled version of LyX 1.5.1 that is available in the > repositories for Ubuntu 7.10 I am suddenly not able to specify > multicolumns in tables using the gui like I used to be able to do in LyX > 1.4.x.  What happens is that when I try select the columns to mark as

Re: [Patch] Missing translations in pocheck.pl

2007-12-02 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > i would like to have one more warning in our .po checker. > if there wont be objections i'll put it in later. > (can this go in branch Juergen ?) I have no strong opinions. I'd ask the other translaters instead if such a message would annoy or help them. Jürgen

Re: r21925 - /lyx-devel/trunk/src/BufferParams.cpp

2007-12-02 Thread Jürgen Spitzmüller
Bo Peng wrote: > If filepath.empty(), pp is addTextClass is not run. Will pp.first be > undertermined? I think if pp.first should move into if > (!filepath.empty()). I think if filepath.empty(), pp.first returns wrong, no? Jürgen

Re: [patch] fix bug 27

2007-12-02 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > - The attached patch supports \selectlanguage etc. in tex2lyx. I think there's a problem: the language switch is not static, it depends on what the user defined as lyxrc.language_command_begin and lyxrc.language_command_end. So you cannot assume (and hardcode) \selectlanguage

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: On Sun, Dec 02, 2007 at 08:54:32PM +0100, Peter Kümmel wrote: The only thing I see is that we must not delete the C string after calling putenv, IIRC that's indeed the requierment. Patch looks ok. Index: support/environment.cpp ===

Re: [Cvslog] r21929 - in /lyx-devel/branches/BRANCH_1_5_X: src/tex2lyx...

2007-12-02 Thread Jürgen Spitzmüller
[EMAIL PROTECTED] wrote: > tex2lyx/text.cpp: support for framed and shaded notes Now we are at Format 246. Could you please do the necessary update? Jürgen

Re: [patch for 1.5] support notes in tex2lyx

2007-12-02 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > This is not correct. The notes are environments and not boxes. We don't > support colorboxes and they can also only handle several paragraphs with > tricks. Shaded notes are a different LaTeX approach! UI-wise, these are boxes. Being and "environment" (markup-wise) and being a

Re: Regression List of current SVN is now in Bugzilla

2007-12-02 Thread Martin Vermeer
On Sun, Dec 02, 2007 at 06:47:43PM +0100, Uwe Stöhr wrote: > The regressions collected in this wiki page: > http://wiki.lyx.org/Devel/RegressionListSVN > > are now in Bugzilla: > > http://bugzilla.lyx.org/show_bug.cgi?id=4397 > (broken layout configuration) > > http://bugzilla.lyx.org/show_bug.cgi?

Re: [Cvslog] r21902 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Alfredo Braunstein
Andre Poenitz wrote: > So let's wait for a few people to disagree, otherwise we cannot have a > decent flamewar... Unfortunately I also agree... A/

multicolumn trouble with LyX 1.5.x

2007-12-02 Thread Ryan
When using the precompiled version of LyX 1.5.1 that is available in the repositories for Ubuntu 7.10 I am suddenly not able to specify multicolumns in tables using the gui like I used to be able to do in LyX 1.4.x. What happens is that when I try select the columns to mark as multicolumn it just

Re: [patch] fix bug 27

2007-12-02 Thread Uwe Stöhr
Take this patch with better code documentation instead. regards Uwe Index: preamble.cpp === --- preamble.cpp (revision 21925) +++ preamble.cpp (working copy) @@ -3,7 +3,8 @@ * This file is part of LyX, the document processor. * L

Re: Regression List of current SVN is now in Bugzilla

2007-12-02 Thread Uwe Stöhr
> isn't this identical problem to 4394 ? I don't know. You reported bug 4394 for LyX 1.5.2, bug 4403 was reported by Helge for LyX 1.6svn as regression to LyX 1.5.2. regards Uwe

[patch] fix bug 27

2007-12-02 Thread Uwe Stöhr
- The attached patch supports \selectlanguage etc. in tex2lyx. - To achieve this, it also enables to use more than one document language - To be LaTeX-conform, also support for this kind of option specifications is built in: \documentclass[12pt, bulgarian,italian,english]{article} Spaces are tr

[Patch] Missing translations in pocheck.pl

2007-12-02 Thread Pavel Sanda
hi, i would like to have one more warning in our .po checker. if there wont be objections i'll put it in later. (can this go in branch Juergen ?) pavel Index: pocheck.pl === --- pocheck.pl (revision 21931) +++ pocheck.pl (working c

Re: Regression List of current SVN is now in Bugzilla

2007-12-02 Thread Pavel Sanda
> http://bugzilla.lyx.org/show_bug.cgi?id=4403 > (pasting problem on Linux, not reproducible for me) isn't this identical problem to 4394 ? (yes, you can't confirm this on win, middle button pasting is X11 related issue). pavel

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 08:54:32PM +0100, Peter Kümmel wrote: > The only thing I see is that we must not delete the C string after > calling putenv, IIRC that's indeed the requierment. Patch looks ok. > Index: support/environment.cpp > =

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: #elif defined (HAVE_PUTENV) - static std::map varmap; + static std::map > varmap; string envstr = name + '=' + encoded; - char * newptr = new char[envstr.size() + 1]; - envstr.copy(newptr, envstr.length()); - newptr[envstr.length()] = '

Re: r21925 - /lyx-devel/trunk/src/BufferParams.cpp

2007-12-02 Thread Bo Peng
> Modified: lyx-devel/trunk/src/BufferParams.cpp > URL: > http://www.lyx.org/trac/file/lyx-devel/trunk/src/BufferParams.cpp?rev=21925 > == > --- lyx-devel/trunk/src/BufferParams.cpp (original) > +++ lyx-devel/trunk/src/Buf

Re: [Cvslog] r21902 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 08:24:42PM +0100, Abdelrazak Younes wrote: >>> @@ -111,42 +111,30 @@ >>> namespace support { >>> using std::ifstream; >>> -#if HAVE_DECL_ISTREAMBUF_ITERATOR >>> using std::istreambuf_iterator; >>> +using std::istream_iterator; >>> +using std::ios; >>> +using std::ios_bas

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 07:42:17PM +0100, Peter Kümmel wrote: >>> --- lyx-devel/trunk/src/support/environment.cpp (original) >>> +++ lyx-devel/trunk/src/support/environment.cpp Sat Dec 1 11:52:52 2007 >>> @@ -18,6 +18,7 @@ >>> #include "support/os.h" >>> #include >>> +#include >>> #include

Re: [Cvslog] r21902 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Dec 02, 2007 at 08:09:17AM -, [EMAIL PROTECTED] wrote: Author: younes Date: Sun Dec 2 09:09:16 2007 New Revision: 21902 URL: http://www.lyx.org/trac/changeset/21902 Log: cosmetics. Modified: lyx-devel/trunk/src/support/lyxsum.cpp Modified: lyx-devel/trunk

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Dec 02, 2007 at 09:17:08AM +0100, Abdelrazak Younes wrote: So I'd like to keep it out. Unfortunately, forward declaration of vector is not as straightforward as e.g. for string and ostream. How is it that Qt manage to forward declare things like QFileInfoList? I

Re: [Cvslog] r21905 - /lyx-devel/trunk/src/frontends/qt4/GuiPopupMenu.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 09:27:02AM -, [EMAIL PROTECTED] wrote: > Author: kuemmel > Date: Sun Dec 2 10:27:02 2007 > New Revision: 21905 > > URL: http://www.lyx.org/trac/changeset/21905 > Log: > fix memory leak. addMenu does not take ownership, a Qt bug? Not a bug if it's not documented to tak

Re: [Cvslog] r21901 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sun, Dec 02, 2007 at 07:52:29AM -, [EMAIL PROTECTED] wrote: Author: younes Date: Sun Dec 2 08:52:28 2007 New Revision: 21901 URL: http://www.lyx.org/trac/changeset/21901 Log: compil Fix. Modified: lyx-devel/trunk/src/support/lyxsum.cpp Modified: lyx-devel/tru

Re: [Cvslog] r21902 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 08:09:17AM -, [EMAIL PROTECTED] wrote: > Author: younes > Date: Sun Dec 2 09:09:16 2007 > New Revision: 21902 > > URL: http://www.lyx.org/trac/changeset/21902 > Log: > cosmetics. > > Modified: > lyx-devel/trunk/src/support/lyxsum.cpp > > Modified: lyx-devel/trunk

Re: [Cvslog] r21901 - /lyx-devel/trunk/src/support/lyxsum.cpp

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 07:52:29AM -, [EMAIL PROTECTED] wrote: > Author: younes > Date: Sun Dec 2 08:52:28 2007 > New Revision: 21901 > > URL: http://www.lyx.org/trac/changeset/21901 > Log: > compil Fix. > > > Modified: > lyx-devel/trunk/src/support/lyxsum.cpp > > Modified: lyx-devel/t

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 10:23:13AM +0100, Peter Kümmel wrote: > Abdelrazak Younes wrote: >> Andre Poenitz wrote: >>> On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: Modified: lyx-devel/trunk/src/support/FileName.h URL: http://www.lyx.org/trac/file/lyx-devel/trunk/

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Andre Poenitz
On Sun, Dec 02, 2007 at 09:17:08AM +0100, Abdelrazak Younes wrote: > Andre Poenitz wrote: >> On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: >>> Modified: lyx-devel/trunk/src/support/FileName.h >>> URL: >>> http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.h?rev=

Re: [Cvslog] r21898 - /lyx-devel/trunk/src/support/environment.cpp

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:52:52AM -, [EMAIL PROTECTED] wrote: Author: kuemmel Date: Sat Dec 1 11:52:52 2007 New Revision: 21898 URL: http://www.lyx.org/trac/changeset/21898 Log: fix memory leak Modified: lyx-devel/trunk/src/support/environment.cpp Modified: lyx-

msvc: leak detection

2007-12-02 Thread Peter Kümmel
For msvc/cmake I've added the leak detection from Dan Moulding: http://dmoulding.googlepages.com/vld It nicely integrates into Studio and gives in the debugger the complete call stack to the allocation of the not freed memory. When using cmake it could be enabled with -Dvld=1. MS's debugging too

Re: [patch for 1.5] support notes in tex2lyx

2007-12-02 Thread Uwe Stöhr
> However, for 1.6, I really think framed and shaded should go to InsetBox. > These are boxes, no notes. This is not correct. The notes are environments and not boxes. We don't support colorboxes and they can also only handle several paragraphs with tricks. Shaded notes are a different LaTeX app

Regression List of current SVN is now in Bugzilla

2007-12-02 Thread Uwe Stöhr
The regressions collected in this wiki page: http://wiki.lyx.org/Devel/RegressionListSVN are now in Bugzilla: http://bugzilla.lyx.org/show_bug.cgi?id=4397 (broken layout configuration) http://bugzilla.lyx.org/show_bug.cgi?id=4398 (date inset issue) http://bugzilla.lyx.org/show_bug.cgi?id=4399

Re: [patch for 1.5] support notes in tex2lyx

2007-12-02 Thread Jürgen Spitzmüller
Uwe Stöhr wrote: > What about my path for branch? you can commit. However, for 1.6, I really think framed and shaded should go to InsetBox. These are boxes, no notes. Jürgen

Re: [pathch for 1.5] support \newline in tex2lyx

2007-12-02 Thread Uwe Stöhr
> Yes, given that it's well tested, as usual. It's in. regards Uwe

Re: [patch for 1.5] support notes in tex2lyx

2007-12-02 Thread Uwe Stöhr
What about my path for branch? regards Uwe

drag and drop text

2007-12-02 Thread Noah Last
A drag-and-drop feature for blocks of text would be highly useful, rather than having to cut-and-paste every time you need to move blocks of texts. Thanks.

Re: changeset/21691 breaks layout configuration

2007-12-02 Thread Uwe Stöhr
> I admit that I did not test the changes for 1.6.x, I will have a look later. Ping. This should be fixed soon or be reverted in trunk until a better solution is found. That it won't be foregotten, I added this to bugzilla: http://bugzilla.lyx.org/show_bug.cgi?id=4397 regards Uwe

Re: Patch Candidate List #11

2007-12-02 Thread Richard Heck
Jürgen Spitzmüller wrote: http://www.lyx.org/trac/changeset/20903 - younes - initial support for shift + right-mouse-click selection. (TESTING REQUIRED) Richard provided the backport IIRC. I suggest to commit Richard. I'd like to see the patch first. No, I didn't do this.

Re: SVN1.5.2 revision 21899

2007-12-02 Thread Jürgen Spitzmüller
Jürgen Spitzmüller wrote: > > Adding  #include  to TocModel.cpp > > resulted in a working LyX1.5.3 > > Could you post a diff, please? So the attached changes are needed, Roger? Jürgen Index: src/frontends/qt4/TocModel.cpp === --- sr

[patch] bug 4368: Pasting multiline text into multiline table cell crashes LyX

2007-12-02 Thread Jürgen Spitzmüller
http://bugzilla.lyx.org/show_bug.cgi?id=4368 The second part of the attached patch (against branch) fixes this (pit can be invalid if a multi-par cell is replaced by content with lesser paragraphs, as in the reported case). The first part sanitizes LFUN_FILE_INSERT_PLAINTEXT[_PARA], where the c

Re: Patch Candidate List #11

2007-12-02 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg132482.html Thanks. Looks straightforward, so you can commit to branch as well. (Remember updating status.15x) Jürgen

Re: Patch Candidate List #11

2007-12-02 Thread Pavel Sanda
> Pavel Sanda wrote: > > > http://www.lyx.org/trac/changeset/21737 - sanda      - Fix dialog > > > handling of Insert Plain Text > > > > easy to backport if you want. > > Could you describe the problem it fixes again, please? http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg132482.html pave

Re: Disable warning with CMake/MSVC

2007-12-02 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Hello Peter As you are in "CMake hacking mode" ;) could you please disable warning C4355? Done. Thanks! Abdel.

Re: Disable warning with CMake/MSVC

2007-12-02 Thread Peter Kümmel
Abdelrazak Younes wrote: Hello Peter As you are in "CMake hacking mode" ;) could you please disable warning C4355? Done. Abdel. ..\..\..\..\src\insets\InsetGraphics.cpp(154) : warning C4355: 'this' : used in base member initializer list ..\..\..\..\src\insets\InsetGraphics.cpp(162) : w

Disable warning with CMake/MSVC

2007-12-02 Thread Abdelrazak Younes
Hello Peter As you are in "CMake hacking mode" could you please disable warning C4355? Abdel. ..\..\..\..\src\insets\InsetGraphics.cpp(154) : warning C4355: 'this' : used in base member initializer list ..\..\..\..\src\insets\InsetGraphics.cpp(162) : warning C4355: 'this' : used in base membe

Re: Patch Candidate List #11

2007-12-02 Thread Jürgen Spitzmüller
Some update: Michael Gerz wrote: > Approved by Jürgen > -- > http://www.lyx.org/trac/changeset/20419 - younes - > GuiApplication::notify(): don't crash with abort() but exit gracefully > when an exception is caught. try to catch LyX specific exceptions. > http://www.lyx.org/tra

Re: Patch Candidate List #11

2007-12-02 Thread Jürgen Spitzmüller
Pavel Sanda wrote: > > http://www.lyx.org/trac/changeset/21737 - sanda      - Fix dialog > > handling of Insert Plain Text > > easy to backport if you want. Could you describe the problem it fixes again, please? Jürgen

Re: Patch Candidate List #11

2007-12-02 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > Approved by Jürgen > > -- > > http://www.lyx.org/trac/changeset/20419 - younes     - > > GuiApplication::notify(): don't crash with abort() but exit gracefully > > when an exception is caught. try to catch LyX specific exceptions. > > http://www.lyx.org/

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Peter Kümmel
Abdelrazak Younes wrote: Peter Kümmel wrote: Abdelrazak Younes wrote: Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: Modified: lyx-devel/trunk/src/support/FileName.h URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.h?rev=21896

Re: SVN1.5.2 revision 21899

2007-12-02 Thread Jürgen Spitzmüller
Roger Mc Murtrie wrote: > Adding  #include  to TocModel.cpp > resulted in a working LyX1.5.3 Could you post a diff, please? Jürgen

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Abdelrazak Younes
Peter Kümmel wrote: Abdelrazak Younes wrote: Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: Modified: lyx-devel/trunk/src/support/FileName.h URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.h?rev=21896 ==

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Peter Kümmel
Abdelrazak Younes wrote: Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: Modified: lyx-devel/trunk/src/support/FileName.h URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.h?rev=21896 ===

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Peter Kümmel
Andre Poenitz wrote: On Sat, Dec 01, 2007 at 12:57:09PM +0100, Peter Kümmel wrote: Peter Kümmel wrote: Andre Poenitz wrote: #include +#include Looks like I have no chance to keep that out. First Abdel, now you ;-} Sorry, didn't know that this header is that critical at this point. I wil

Re: [Cvslog] r21896 - in /lyx-devel/trunk/src: Converter.cpp support/F...

2007-12-02 Thread Abdelrazak Younes
Andre Poenitz wrote: On Sat, Dec 01, 2007 at 10:23:17AM -, [EMAIL PROTECTED] wrote: Modified: lyx-devel/trunk/src/support/FileName.h URL: http://www.lyx.org/trac/file/lyx-devel/trunk/src/support/FileName.h?rev=21896 ===