Re: Should save/restorePosition be better in LyXView instead of BufferView?

2006-10-28 Thread Bo Peng
Yes: dispatch(FuncRequest(LFUN_BUFFER_SWITCH, _name_of_the_buffer)) No. BufferBiew::dispatch() does not pass the signal to LyXView. Will something like attached be accepted? Basically, I move LFUN_BOOKMARK_GOTO to lyxfunc.C and swith buffer via LyxView instead of BufferView. A relocation of t

Re: Should save/restorePosition be better in LyXView instead of BufferView?

2006-10-28 Thread Abdelrazak Younes
Bo Peng wrote: >> IMHO bookmark has nothing to do with BufferView nor LyXView but with >> Buffer. Especially so if these bookmarks are persistent. A bookmark >> should work with any LyXView or BufferView. > > Is there a way to call LyxView::setBuffer from BufferView? Yes: dispatch(FuncRequest(L

Re: Should save/restorePosition be better in LyXView instead of BufferView?

2006-10-28 Thread Bo Peng
IMHO bookmark has nothing to do with BufferView nor LyXView but with Buffer. Especially so if these bookmarks are persistent. A bookmark should work with any LyXView or BufferView. Is there a way to call LyxView::setBuffer from BufferView? If we can emit a signal from restorePosition, at least

Re: Should save/restorePosition be better in LyXView instead of BufferView?

2006-10-28 Thread Abdelrazak Younes
Bo Peng wrote: Hi, In the process of save/restore bookmarks, I notice that bookmark feature is confusing right now. For example, the saved bookmars will appear/disappear kind of randomly when you switch between windows. And, when you switch to another buffer using a saved bookmark, the windows t

Should save/restorePosition be better in LyXView instead of BufferView?

2006-10-28 Thread Bo Peng
Hi, In the process of save/restore bookmarks, I notice that bookmark feature is confusing right now. For example, the saved bookmars will appear/disappear kind of randomly when you switch between windows. And, when you switch to another buffer using a saved bookmark, the windows title is not chan

Re: 1.5.x compile error

2006-10-28 Thread Bo Peng
No lyx headers are precompiled any more (like in my initial pch), now only boost, stl, and in the case of qt4 the Qt headers are precompiled. Is this really too much? The problem can be easily identified and fixed, so it is not a big deal. Maybe someday you can find a bullet-proof pch approach.

Re: [PATCH] New CT merge approach

2006-10-28 Thread Peter Kümmel
Michael Gerz wrote: > Michael Gerz wrote: > >> >> I changed the CT merge strategy according to the previous discussion. >> >> This patch merges two adjacent changes if they were made by the same >> author (the change time is not regarded). >> >> OK to commit? >> >> Michael >> > Here comes this pat

Re: compiler warning

2006-10-28 Thread Peter Kümmel
Michael Gerz wrote: > Abdel, > > I think this is for you :-) > No, this was for me. ;) > Michael > > /home/software/lyx-trunk/src/frontends/qt4/GuiView.C: In member function ` > virtual void lyx::frontend::GuiView::setGeometry(unsigned int, > unsigned int, > int, int, bool)': > /home/softw

Re: [PATCH] New CT merge approach

2006-10-28 Thread Michael Gerz
Michael Gerz wrote: I changed the CT merge strategy according to the previous discussion. This patch merges two adjacent changes if they were made by the same author (the change time is not regarded). OK to commit? Michael Here comes this patch :-( Michael Index: src/changes.C =

compiler warning

2006-10-28 Thread Michael Gerz
Abdel, I think this is for you :-) Michael /home/software/lyx-trunk/src/frontends/qt4/GuiView.C: In member function ` virtual void lyx::frontend::GuiView::setGeometry(unsigned int, unsigned int, int, int, bool)': /home/software/lyx-trunk/src/frontends/qt4/GuiView.C:164: warning: converti

[PATCH] New CT merge approach

2006-10-28 Thread Michael Gerz
I changed the CT merge strategy according to the previous discussion. This patch merges two adjacent changes if they were made by the same author (the change time is not regarded). OK to commit? Michael

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Michael Gerz
Peter Kümmel wrote: Why not add a "Show allways the CT toolbar"? This maps to option "on" in stdtoolbar.ui. I wonder whether we will have context-sensitive menus at all in 1.5. Bo, will your session management make the settings in stdtoolbars.ui obsolete? Or do they co-exist? Michael

Re: guiapi.C

2006-10-28 Thread Abdelrazak Younes
Michael Gerz wrote: Do we still need guiapi.[Ch]? Again, it seems like it is not linked to the final LyX executable. I let it there because I don't know it is used in some external client. We shall know if this is true or not before removing this. Abdel.

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Michael Gerz
Peter Kümmel wrote: Have you checked the kde icons? (someone mentioned them) I had no time so far. Right now, I care for basic CT functionality. Michael

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Peter Kümmel
Michael Gerz wrote: > Peter Kümmel wrote: > >> Why should the toolbar be visible when tracking is disabled? >> >> > Because I want to switch CT on and off; because there may be changes in > a document even if CT is disabled. > Why not add a "Show allways the CT toolbar"? >> At least we need b

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Peter Kümmel
Michael Gerz wrote: > Peter Kümmel wrote: > >> Why should the toolbar be visible when tracking is disabled? >> >> > Because I want to switch CT on and off; because there may be changes in > a document even if CT is disabled. > >> At least we need better icons. >> >> > Indeed. Do you volunteer

guiapi.C

2006-10-28 Thread Michael Gerz
Do we still need guiapi.[Ch]? Again, it seems like it is not linked to the final LyX executable. Michael

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Michael Gerz
Peter Kümmel wrote: Why should the toolbar be visible when tracking is disabled? Because I want to switch CT on and off; because there may be changes in a document even if CT is disabled. At least we need better icons. Indeed. Do you volunteer? Michael

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Peter Kümmel
Michael Gerz wrote: > Peter Kümmel wrote: > >> Here a patch which fixes the table toolbar bug, >> mainly the code removing in Toolbars.C does the job. >> >> But then the hiding must be improved which forces a >> more complete CT toolbar impl. >> >> With this patch the only missing part is the sett

MathAutoCorrect.C

2006-10-28 Thread Michael Gerz
Hello, what is MathAutoCorrect.[Ch] good for? AFAICS, it is not used in the LyX executable. Is it obsolete? Michael

Re: 1.5.x compile error

2006-10-28 Thread Peter Kümmel
Bo Peng wrote: >> When developing with the the cmake build system, >> precompiled headers are used and all / >> headers are included by default. So there is no >> error if the header is not included, but the scons/auto >> builds will fail. > > Your pch approach is convenient, fast, but error-prone

Re: Table toolbar bug + CT Toolbar

2006-10-28 Thread Michael Gerz
Peter Kümmel wrote: Here a patch which fixes the table toolbar bug, mainly the code removing in Toolbars.C does the job. But then the hiding must be improved which forces a more complete CT toolbar impl. With this patch the only missing part is the setting of the change track flag, which now i

Re: 1.5.x compile error

2006-10-28 Thread Bo Peng
When developing with the the cmake build system, precompiled headers are used and all / headers are included by default. So there is no error if the header is not included, but the scons/auto builds will fail. Your pch approach is convenient, fast, but error-prone. When I tried (and failed) to a

Re: Obsolete QT3 code

2006-10-28 Thread Abdelrazak Younes
Michael Gerz wrote: Abdel, this looks superfluous. Can I commit? Yes. Abdel.

Re: Only 5 showstoppers known

2006-10-28 Thread Bo Peng
OK, should be solved now. Indeed. Thanks. Bo

Re: 1.5.x compile error

2006-10-28 Thread Abdelrazak Younes
Peter Kümmel wrote: Bennett Helm wrote: Maybe this is the reason: Ah!!! Thanks for the explanation. Abdel.

Obsolete QT3 code

2006-10-28 Thread Michael Gerz
Abdel, this looks superfluous. Can I commit? Michael Index: GuiFontMetrics.C === --- GuiFontMetrics.C(Revision 15593) +++ GuiFontMetrics.C(Arbeitskopie) @@ -61,28 +61,14 @@ int GuiFontMetrics::ascent(char_type c) const {

Table toolbar bug + CT Toolbar

2006-10-28 Thread Peter Kümmel
Here a patch which fixes the table toolbar bug, mainly the code removing in Toolbars.C does the job. But then the hiding must be improved which forces a more complete CT toolbar impl. With this patch the only missing part is the setting of the change track flag, which now is always enabled. Mich

Re: Unused variable

2006-10-28 Thread Michael Gerz
Michael Gerz wrote: Hi, can you remove this unused variable? Sorry, can _I_ remove it? Am I allowed to do so? Michael

Re: 1.5.x compile error

2006-10-28 Thread Abdelrazak Younes
Bennett Helm wrote: g++-dp-4.2 -DHAVE_CONFIG_H -I. -I. -I../../../src -DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR -DQT_NO_STL -DQT_NO_KEYWORDS -I../../../src -I../../../src/frontends -I../../../images -I/Users/bennett/lyx/gcc-4.0/Qt-4.2.1-install/include -I/Users/bennett/lyx/gcc-4.0/Qt-4.2.1-install

Re: 1.5.x compile error

2006-10-28 Thread Peter Kümmel
Bennett Helm wrote: > g++-dp-4.2 -DHAVE_CONFIG_H -I. -I. -I../../../src -DQT_CLEAN_NAMESPACE > -DQT_GENUINE_STR -DQT_NO_STL -DQT_NO_KEYWORDS -I../../../src > -I../../../src/frontends -I../../../images > -I/Users/bennett/lyx/gcc-4.0/Qt-4.2.1-install/include > -I/Users/bennett/lyx/gcc-4.0/Qt-4.2.1-in

Unused variable

2006-10-28 Thread Michael Gerz
Hi, can you remove this unused variable? Michael Index: src/rowpainter.C === --- src/rowpainter.C(Revision 15592) +++ src/rowpainter.C(Arbeitskopie) @@ -852,8 +852,6 @@ // Add to row signature cache

Re: Only 5 showstoppers known

2006-10-28 Thread Abdelrazak Younes
Bo Peng wrote: I think this is due to the BufferView pointer cached in LyXText. It could explain many other reported crash... I'm on it. You must still be working on it, just let you know that I get compiling errors as of r15591. OK, should be solved now. Abdel. Author: younes Date: Sat Oc

Re: Only 5 showstoppers known

2006-10-28 Thread Abdelrazak Younes
Bo Peng wrote: I think this is due to the BufferView pointer cached in LyXText. It could explain many other reported crash... I'm on it. You must still be working on it, just let you know that I get compiling errors as of r15591. Hum, no, I haven't even started. This below has nothing to do w

1.5.x compile error

2006-10-28 Thread Bennett Helm
g++-dp-4.2 -DHAVE_CONFIG_H -I. -I. -I../../../src - DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR -DQT_NO_STL -DQT_NO_KEYWORDS - I../../../src -I../../../src/frontends -I../../../images -I/Users/ bennett/lyx/gcc-4.0/Qt-4.2.1-install/include -I/Users/bennett/lyx/ gcc-4.0/Qt-4.2.1-install/include/QtCore -

Re: Only 5 showstoppers known

2006-10-28 Thread Bo Peng
I think this is due to the BufferView pointer cached in LyXText. It could explain many other reported crash... I'm on it. You must still be working on it, just let you know that I get compiling errors as of r15591. g++ -o debug/common/frontends/qt4/QLPainter.o -c -g -O -DQT_SHARED -DHAVE_CONFIG

Re: [Patch] optimize utf8_to_ucs4

2006-10-28 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Hello, This patch brings a 20% improvement when loading a big document (my test document is the UserGuide copied&Pasted 3 times). This is done by avoiding multiple string/vector/docstring copying. I can think of many other optimisation but I would like this one to go

Re: LyX/Mac 1.5.0, Qt 4.2.1 Profile

2006-10-28 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> En direct tu peux me parler en Francais si tu veux :-) Je préfère continuer sur la liste pour que les autres puissent intervenir (ai je répondu en direct par erreur?) Ouep. Abdelrazak> Bac

Re: LyX/Mac 1.5.0, Qt 4.2.1 Profile

2006-10-28 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> There was no such trick. Andre proposed to limit the cache Abdelrazak> to the first 256 chars. I pushed that to 65536 (2^16) Abdelrazak> which covers all of ucs2. Even if we use 100 different A

Re: About multiple windows and typing speed

2006-10-28 Thread Abdelrazak Younes
Enrico Forestieri wrote: LyX 1.5 was basically performing the same with both Qt3/Win and Qt4/Win. So, from what you say, its poor performance is related to something that is being done differently with respect to 1.3. Indeed, even using Qt/X11, scrolling of the document attached to bug 2900 is di

Re: Only 5 showstoppers known

2006-10-28 Thread Abdelrazak Younes
Asger Ottar Alstrup wrote: - Various crashes with multiple views. Possible interaction with the coord cache. Not easily reproducible. I think this is due to the BufferView pointer cached in LyXText. It could explain many other reported crash... I'm on it. Abdel.

Re: Compiler warnings (session.h)

2006-10-28 Thread Bo Peng
I think this one is for you: In file included from /home/software/lyx-trunk/src/bufferlist.C:20: /home/software/lyx-trunk/src/session.h:40: warning: `class lyx::SessionSection' has virtual functions but non-virtual destructor OK. I will give them an empty one. Cheers, Bo

Compiler warnings (session.h)

2006-10-28 Thread Michael Gerz
Bo, I think this one is for you: In file included from /home/software/lyx-trunk/src/bufferlist.C:20: /home/software/lyx-trunk/src/session.h:40: warning: `class lyx::SessionSection' has virtual functions but non-virtual destructor /home/software/lyx-trunk/src/session.h:52: warning: `class l

Re: CT changes

2006-10-28 Thread Michael Gerz
Jean-Marc Lasgouttes wrote: Michael> For simplicity, we could assume that adjacent changes of the Michael> _same_ author are always merged, where the later time is Michael> preserved. In this case, the changetime indicates the latest Michael> change in the given section. This leads to less chang

Re: [Cvslog] r15569 - in /lyx-devel/trunk/src: changes.C changes.h par...

2006-10-28 Thread Michael Gerz
Andre Poenitz wrote: Using operator==() in that case is misleading as we suddenly have situations with a == b, b == c, and a != c. For fuzzy comparison, a named function should be used. Agreed. I wasn't very happy with it, too. I will fix it in the next commit. Michael

Re: Only 5 showstoppers known

2006-10-28 Thread Jean-Marc Lasgouttes
> "Joost" == Joost Verburg <[EMAIL PROTECTED]> writes: Joost> Asger Ottar Alstrup wrote: >> - Encodings. UTF-8 is not supported for LaTeX output, but no known >> regressions from 1.4 as far as I know. I guess UTF-8 should be >> listed in the document encodings list, so people can choose it >>

Re: LyX 1.5.0 won't start properly on Mac

2006-10-28 Thread Jean-Marc Lasgouttes
> "Bennett" == Bennett Helm <[EMAIL PROTECTED]> writes: Bennett> I just added the --enable-profiling flag to configure, which Bennett> does the trick for Shark. Should I do something else instead? Are you sure that Shark needs this? JMarc

Re: LyX/Mac 1.5.0, Qt 4.2.1 Profile

2006-10-28 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> En direct tu peux me parler en Francais si tu veux :-) Je préfère continuer sur la liste pour que les autres puissent intervenir (ai je répondu en direct par erreur?) Abdelrazak> Back to English, yes I understand wha

Re: LyX/Mac 1.5.0, Qt 4.2.1 Profile

2006-10-28 Thread Jean-Marc Lasgouttes
> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: Abdelrazak> There was no such trick. Andre proposed to limit the cache Abdelrazak> to the first 256 chars. I pushed that to 65536 (2^16) Abdelrazak> which covers all of ucs2. Even if we use 100 different Abdelrazak> fonts and size

Re: Random notes

2006-10-28 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: Andre> On Wed, Oct 25, 2006 at 10:42:36AM +0200, Jean-Marc Lasgouttes Andre> wrote: >> One year for the 1.5 cycle would not be a scandal, and that puts us >> in march 2007. I am not saying that we shall do that, but there is >> no need to

Re: Only 5 showstoppers known

2006-10-28 Thread Peter Kümmel
Asger Ottar Alstrup wrote: > Hi, > > My attempt at a status of 1.5.svn in terms of show-stoppers. > > The list includes just 5 known show stoppers: > > - In math the cursor blinks at the start of the math inset and then > seems to go the correct place afterwards. Any other known cursor > regress

Re: About multiple windows and typing speed

2006-10-28 Thread Enrico Forestieri
On Fri, Oct 27, 2006 at 10:23:16PM +0200, Andre Poenitz wrote: > On Thu, Oct 26, 2006 at 10:01:06PM +0200, Enrico Forestieri wrote: > > On Thu, Oct 26, 2006 at 02:21:41PM +0200, Abdelrazak Younes wrote: > > > Jean-Marc Lasgouttes wrote: > > > >>"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECT

Re: Only 5 showstoppers known

2006-10-28 Thread Joost Verburg
Asger Ottar Alstrup wrote: - Encodings. UTF-8 is not supported for LaTeX output, but no known regressions from 1.4 as far as I know. I guess UTF-8 should be listed in the document encodings list, so people can choose it themselves. I guess this is not a show stopper anymore. UTF-8 support can c

Re: Only 5 showstoppers known

2006-10-28 Thread Peter Kümmel
Asger Ottar Alstrup wrote: > Hi, > > My attempt at a status of 1.5.svn in terms of show-stoppers. > > The list includes just 5 known show stoppers: > > - In math the cursor blinks at the start of the math inset and then > seems to go the correct place afterwards. Any other known cursor > regress

Only 5 showstoppers known

2006-10-28 Thread Asger Ottar Alstrup
Hi, My attempt at a status of 1.5.svn in terms of show-stoppers. The list includes just 5 known show stoppers: - In math the cursor blinks at the start of the math inset and then seems to go the correct place afterwards. Any other known cursor regressions? - Selection. Does not work in math

Re: Random notes

2006-10-28 Thread José Matos
On Friday 27 October 2006 10:32 pm, Andre Poenitz wrote: > You know that that Christmas release data is kind of a running gag... That is the point. :-) In the talk that I gave yesterday, I presented this idea, something like this: LyX fake FAQ Q: When will feature xyz (replace xyz with ap

Re: About multiple windows and typing speed

2006-10-28 Thread Andre Poenitz
On Thu, Oct 26, 2006 at 10:01:06PM +0200, Enrico Forestieri wrote: > On Thu, Oct 26, 2006 at 02:21:41PM +0200, Abdelrazak Younes wrote: > > Jean-Marc Lasgouttes wrote: > > >>"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > > > > >>> I thought Abdel tested that with qt4. > > > >

Re: Random notes

2006-10-28 Thread Andre Poenitz
On Wed, Oct 25, 2006 at 10:42:36AM +0200, Jean-Marc Lasgouttes wrote: > One year for the 1.5 cycle would not be a scandal, and that puts us in > march 2007. I am not saying that we shall do that, but there is no > need to try to get a xmas date (as was proposed elsewhere) if we feel > we cannot do

Re: [Cvslog] r15569 - in /lyx-devel/trunk/src: changes.C changes.h par...

2006-10-28 Thread Andre Poenitz
On Thu, Oct 26, 2006 at 07:00:29PM -, [EMAIL PROTECTED] wrote: > changes that only differ in their change time with abs(ct1 - ct2) < 300 sec, > they will be merged (and the later change time is preserved). > Technically, the check for equality (or similarity) is made in > operator==(...

Re: [Cvslog] r15570 - in /lyx-devel/branches/BRANCH_1_4_X: lib/ChangeL...

2006-10-28 Thread Andre Poenitz
On Thu, Oct 26, 2006 at 07:09:12PM -, [EMAIL PROTECTED] wrote: > Author: forenr > Date: Thu Oct 26 21:09:10 2006 > New Revision: 15570 > > URL: http://www.lyx.org/trac/changeset/15570 > Log: > Make MathBigInset working and implement GUI for fixed size math delimiters > (by Georg and me) Thank

Re: Is it time to rename .C to .cpp now?

2006-10-28 Thread Andre Poenitz
On Tue, Oct 24, 2006 at 02:58:50PM -0500, Bo Peng wrote: > >please not that in this case it is not necessary to run > >autogen.sh or configure. That is only needed for bigger changes > >(deleting/adding a directory etc.) > > My understanding is every addition/removal of files leads to > autogen.sh

Re: UI for New/Close Window

2006-10-28 Thread Andre Poenitz
On Tue, Oct 24, 2006 at 02:50:08PM +0200, Jean-Marc Lasgouttes wrote: > > "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > Abdelrazak> There are two solutions: > > Abdelrazak> 1) Make the central widget a QTabWidget in GuiView (which > Abdelrazak> is a QMainApplication). Then

Re: Scrollbar and multible views

2006-10-28 Thread Jonathan Vogt
Am Freitag 27 Oktober 2006 17:55 schrieb Abdelrazak Younes: > Jonathan Vogt wrote: > > Hi all, > > > > hope I don't report anything old as new again, at least I didn't find > > anything. > > > > 1) Open up one Document > > 2) Open new window and load same document > > 3) Type some lines in new wind