Re: [patch] CoordBranch

2004-11-14 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Sun, Nov 14, 2004 at 04:48:14PM +0100, Alfredo Braunstein wrote: >> The attached patch gets rid of the internal xo_ cache of LyXText. > | Things are snapping into place after all. > | I think I owe you something... > >> The last situation where coords

Re: how to get current cell in insettabular?

2004-11-14 Thread Andre Poenitz
On Sun, Nov 14, 2004 at 08:36:50PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > Is the cursor in the cell if we call this code? If so, we'd take the > > idx() of the correct slice. If not, the 'easy' way out would be to > > revive 'actcell_', even if I don't like it. > > Acutally

Re: [Patch] gtk Box dialog

2004-11-14 Thread Martin Vermeer
On Sun, 2004-11-14 at 16:58, John Spray wrote: > Hi, > > Attached patch implements the box dialog for the gtk frontend. I've > also moved some common functionality out of GGraphics and into ghelpers. > > John + // we're not changing the liststore, just selecting i +

[Patch] gtk menu icons, stock icons in toolbar & menubar

2004-11-14 Thread John Spray
This patch does two things: -Add getGTKStockIcon function for using gtk stock icons where available in menus and toolbars. -Put icons next to command items in menus. Note that GMenubar.C now includes ToolbarBackend.h for the getIcon function. Perhaps this function should be moved somewhere more

Re: how to get current cell in insettabular?

2004-11-14 Thread Alfredo Braunstein
Georg Baum wrote: > Am Sonntag, 14. November 2004 20:36 schrieb Alfredo Braunstein: >> Acutally actcell_ *is* wrong, as we shouldn't store a view-dependent > state >> in the view-independent [wanna-be] data struct insettabular... > > This explains why it is so difficult to get this data inside th

Re: [patch] CoordBranch

2004-11-14 Thread Alfredo Braunstein
Andre Poenitz wrote: > Things are snapping into place after all. I'm as surprised as you ;-) > I think I owe you something... Nah... just putting toghether some pieces here and there... you did all the hard work. > The second one sounds cleaner. Cool, I've done that. > What about being a bi

Crash in LyXText/font_metrics

2004-11-14 Thread John Spray
Hi, A month ago it worked fine (I just tried lyx-devel cvs from oct 14), but now the gtk frontend segfaults when you try to view the docs in the help menu. I'm certain this isn't because of a change in frontends/gtk, because nothing but a couple of miscellaneous dialogs has changed since then.

Re: how to get current cell in insettabular?

2004-11-14 Thread Alfredo Braunstein
Georg Baum wrote: > Would the following work? > > - static int InsetTabularMailer::string2params(...) > + static void InsetTabularMailer::string2params(...) > > and then use kernel().bufferview() in the controller to get the cursor > (and active cell). InsetTabularMailer::string2params is btw th

Re: how to get current cell in insettabular?

2004-11-14 Thread Georg Baum
Am Sonntag, 14. November 2004 20:36 schrieb Alfredo Braunstein: > Acutally actcell_ *is* wrong, as we shouldn't store a view-dependent state > in the view-independent [wanna-be] data struct insettabular... This explains why it is so difficult to get this data inside the inset ;-) > Dunno what is

Re: booktabs branch

2004-11-14 Thread Georg Baum
Am Sonntag, 14. November 2004 11:37 schrieb Juergen Spitzmueller: > P.S.: I have tried the booktabs branch yesterday. Looks very good so far. Then > I noticed how bad the shape of the tabular code is ATM. Multicolumn is > disabled; rotate_cell does not work; UNSET_ALL_LINES is disabled; > getAc

Re: [patch] CoordBranch

2004-11-14 Thread Andre Poenitz
On Sun, Nov 14, 2004 at 04:48:14PM +0100, Alfredo Braunstein wrote: > The attached patch gets rid of the internal xo_ cache of LyXText. Things are snapping into place after all. I think I owe you something... > The last situation where coords are used is when moving the cursor while it > is off-

Re: how to get current cell in insettabular?

2004-11-14 Thread Alfredo Braunstein
Andre Poenitz wrote: > Is the cursor in the cell if we call this code? If so, we'd take the > idx() of the correct slice. If not, the 'easy' way out would be to > revive 'actcell_', even if I don't like it. Acutally actcell_ *is* wrong, as we shouldn't store a view-dependent state in the view-ind

Re: how to get current cell in insettabular?

2004-11-14 Thread Georg Baum
Am Sonntag, 14. November 2004 08:45 schrieb Andre Poenitz: > Is the cursor in the cell if we call this code? If so, we'd take the > idx() of the correct slice. If not, the 'easy' way out would be to > revive 'actcell_', even if I don't like it. It is in the tabular cell (otherwise we have no curre

Re: how to get current cell in insettabular?

2004-11-14 Thread Andre Poenitz
On Sat, Nov 13, 2004 at 10:16:52PM +0100, Georg Baum wrote: > André, > > this code in InsetTabularMailer::params2string(): > > #ifdef WITH_WARNINGS > #warning wrong! > #endif > //data << name_ << " \\active_cell " << inset.getActCell() << '\n'; > data << name_ << " \\active_cell " << 0 << '\n';

[Patch] gtk ERT dialog

2004-11-14 Thread John Spray
A trivial one. John Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/ChangeLog,v retrieving revision 1.82 diff -u -p -r1.82 ChangeLog --- ChangeLog 14 Nov 2004 17:10:04 - 1.82 +++ ChangeLog 14 Nov

[patch] CoordBranch

2004-11-14 Thread Alfredo Braunstein
The attached patch gets rid of the internal xo_ cache of LyXText. The needed infrastructure was already in Andre's initial patch, but some text operations used coordinates when not available. The last situation where coords are used is when moving the cursor while it is off-screen. With the patch,

Re: [Patch] gtk Box dialog

2004-11-14 Thread Lars Gullik Bjønnes
John Spray <[EMAIL PROTECTED]> writes: | Hi, > | Attached patch implements the box dialog for the gtk frontend. I've | also moved some common functionality out of GGraphics and into ghelpers. ok -- Lgb

[Patch] gtk Box dialog

2004-11-14 Thread John Spray
Hi, Attached patch implements the box dialog for the gtk frontend. I've also moved some common functionality out of GGraphics and into ghelpers. John Index: ChangeLog === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/gtk/

Re: getCursorPos

2004-11-14 Thread Alfredo Braunstein
Kornelia Poenitz wrote: > See attached. Super! Thanks, Alfredo

Re: booktabs branch

2004-11-14 Thread Juergen Spitzmueller
Georg Baum wrote: > > 1. Disable changing of vertical rules in the frontends if booktabs are > > enabled. The output of vertical rules is already suppressed. > > The attached patch implements this. Looks good. Jürgen P.S.: I have tried the booktabs branch yesterday. Looks very good so far. Then

Re: [patch] another off-by-one

2004-11-14 Thread Juergen Spitzmueller
John Spray wrote: > > Attached patch accounts for this change in stringFromUnit, committing. > > Oops, I forgot that I don't have cvs write outside of frontends/gtk: can > someone else commit this please? Done. Thanks. Jürgen

getCursorPos

2004-11-14 Thread Kornelia Poenitz
See attached. ? .bufferview_funcs.C.swp ? 1.diff ? mathed/.math_nestinset.C.swp Index: cursor.C === RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/cursor.C,v retrieving revision 1.111.2.8 diff -u -p -r1.111.2.8 cursor.C --- cursor.C