Re: [patch] merge ParIterator with DocumentIterator

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > +void DocumentIterator::forwardPar() > +{ > + while (true) { > + size_t old_depth = depth(); > + idx_type old_idx = idx(); > + par_type old_par = par(); > + > + forwardPos(); > + > + if (empty()) > +

LFUN_EXPORT_CUSTOM and converted sendto dialog.

2004-03-27 Thread Angus Leeming
Just committed. Patch attached for those interested. -- Angus sendto.diff.bz2 Description: BZip2 compressed data

Re: [patch] merge ParIterator with DocumentIterator

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sat, Mar 27, 2004 at 04:14:48PM +0100, Alfredo Braunstein wrote: >> This is the merge of paritertator with dociterator, allowing pariterator >> to go into math-text insets etc. >> >> + const correctness of InsetText::paragraphs >> + 12 files changed, 145 insertions(+), 3

Re: dociterator

2004-03-27 Thread Alfredo Braunstein
Angus Leeming wrote: > Alfredo Braunstein wrote: > >> Andre Poenitz wrote: >> >>> On Sat, Mar 27, 2004 at 01:42:30PM +0100, Alfredo Braunstein wrote: btw, we should have a right past-the-end position for dociterator (and all derivatives). >>> >>> We do. >>> >>> It's an empty cursor s

Re: cvs.lyx.org

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > Same behaviour. > > I just figured out that it "works", but somehow takes a larger amount of > time _per file_ in each interaction. A 'cvs commit' is actually quite > fast, but 'cvs update' takes about 10s per file before anything is > printed on the screen. So I got the im

Re: dociterator

2004-03-27 Thread Angus Leeming
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> On Sat, Mar 27, 2004 at 01:42:30PM +0100, Alfredo Braunstein wrote: >>> btw, we should have a right past-the-end position for dociterator >>> (and all derivatives). >> >> We do. >> >> It's an empty cursor slice stack. (which is, btw, differe

Re: dociterator

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sat, Mar 27, 2004 at 01:42:30PM +0100, Alfredo Braunstein wrote: >> btw, we should have a right past-the-end position for dociterator (and >> all derivatives). > > We do. > > It's an empty cursor slice stack. (which is, btw, different from the > last possible cursor pos

Re: Something is rotten in current cvs

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > +void DocumentIterator::forwardInset() > +{ > + while (depth()) { > + size_t old_depth = depth(); > + > + forwardPos(); > + > + if (depth() > old_depth) > + break; > + } > +} > > Aehm, forget the last mail. If

Re: Non-member emails not in the archives

2004-03-27 Thread lyx
On Tue, Mar 23, 2004 at 03:17:32PM +0100, Claus Hindsgaul wrote: > Hi, > > I am not a member og the lyx-devel list, but I have posted on it. > I thought my emails did not reach the lyx-devel list, since they did not > appear on the archives at (after 5 days): > http://www.mail-archive.com/lyx-dev

Re: New LFUN_SENDTO

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 06:57:32PM +, Angus Leeming wrote: > The attached patch moves functionality out of ControlSendto and into > the core, where it belongs. However, I'm unsure of two things: > > 1. The name. We have an LFUN_EXPORT. Maybe LFUN_SENDTO would be better > off as LFUN_EXPORT_CUS

Re: [patch] merge ParIterator with DocumentIterator

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 04:14:48PM +0100, Alfredo Braunstein wrote: > This is the merge of paritertator with dociterator, allowing pariterator to > go into math-text insets etc. > > + const correctness of InsetText::paragraphs > + 12 files changed, 145 insertions(+), 358 deletions(-) +void Docum

Re: math crash

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 03:53:02PM +0100, Alfredo Braunstein wrote: > Go to Section 4.3.2 of the UG, and go down a bit -> crash MathScriptInset is currently broken (semi-intentoinally to get a clean DocumentIterator implementation...) > #0 0x0815245f in MathArray::draw(PainterInfo&, int, int) co

Re: [patch] small tex2lyx fix

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 04:04:58PM +0100, Georg Baum wrote: > tex2lyx does not handle \vspace{1cm} correctly, it swallows the 1. The > attached fixes that. Could somebody please apply? Don't you think it's time to grow up and commit your fixes yourself? ;-} Andre'

Re: Something is rotten in current cvs

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 02:11:16PM +0100, Alfredo Braunstein wrote: > I think it is a complete no-issue for now, as iterating over all cursor > positions of the Userguide20 is still unnoticeable (sub second) here. If it > shows up in the profiles we can do it later. I'd really prefer to have the >

Re: InsetFormulaMacro: what is tmpl()?

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 02:01:27PM +0100, Alfredo Braunstein wrote: > Angus Leeming wrote: > > > void InsetFormulaMacro::write(Buffer const &, ostream & os) const > > { > > os << "FormulaMacro "; > > WriteStream wi(os, false, false); > > tmpl()->write(wi); > > } > > > > N

meeting 2004

2004-03-27 Thread Andre Poenitz
Can anybody please remind me about the where and when? I must have missed something Andre'

Re: cvs.lyx.org

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 12:30:44PM +, Angus Leeming wrote: > Andre Poenitz wrote: > > It is really strange: I can ping or ssh to lyx.cvs.org with a ping > > time of 200-300ms. As soon as I start a cvs update, ping times go up > > to 2-3s. > > Here's a thought. Why not try the anoncvs mirror?

Re: Something is rotten in current cvs

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 01:16:33PM +0100, Alfredo Braunstein wrote: > I've reimplemented forwardPar as well which was severely fsckd up. AKA "not implemented at all"? > I'll apply both shortly if there are no objections. None from my side... Andre'

cvs

2004-03-27 Thread Andre Poenitz
Urm... it seems to work. About 10 seconds per file or so as 'startup time', so commiting single files seems to work, but a 'cvs up' on the whole tree is impossible... Is this to be expected? Anybody else working over a 56k modem? Andre'

Re: Something is rotten in current cvs

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 01:16:33PM +0100, Alfredo Braunstein wrote: > Ok, your testcase works fine with Andre's patch and this implementation of > forwardInset. +void DocumentIterator::forwardInset() +{ + while (depth()) { + size_t old_depth = depth(); + + forwar

Re: dociterator

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 01:42:30PM +0100, Alfredo Braunstein wrote: > btw, we should have a right past-the-end position for dociterator (and all > derivatives). We do. It's an empty cursor slice stack. (which is, btw, different from the last possible cursor position, i.e. really one ++ after thi

New LFUN_SENDTO

2004-03-27 Thread Angus Leeming
The attached patch moves functionality out of ControlSendto and into the core, where it belongs. However, I'm unsure of two things: 1. The name. We have an LFUN_EXPORT. Maybe LFUN_SENDTO would be better off as LFUN_EXPORT_CUSTOM? 2. Where the code should go. All these different dispatch functions

Re: [patch] small tex2lyx fix

2004-03-27 Thread Angus Leeming
Georg Baum wrote: > tex2lyx does not handle \vspace{1cm} correctly, it swallows the 1. > The attached fixes that. Could somebody please apply? Done. -- Angus

Re: [patch] small lyx2lyx fix

2004-03-27 Thread Angus Leeming
Georg Baum wrote: > lyxrevert_225.py adds an additional '{' to the ERT inset if it has > to convert a minipage to ERT. The attached fixes that. Could > somebody please apply? Done. -- Angus

Re: lyx-1.3.4 dialogs not taking focus

2004-03-27 Thread Bennett Helm
On Mar 26, 2004, at 10:28 AM, Jean-Marc Lasgouttes wrote: Bennett> It mainly happens after I do a mouse click in the main Bennett> document window. If I then bring up a dialog box Bennett> (Find/Replace, Layout> Document..., etc.) it typically does Bennett> not have focus. After I've clicked on th

[patch] small tex2lyx fix

2004-03-27 Thread Georg Baum
tex2lyx does not handle \vspace{1cm} correctly, it swallows the 1. The attached fixes that. Could somebody please apply? Georg Index: src/tex2lyx/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/tex2lyx/ChangeLog,v retrieving revision

[patch] merge ParIterator with DocumentIterator

2004-03-27 Thread Alfredo Braunstein
This is the merge of paritertator with dociterator, allowing pariterator to go into math-text insets etc. + const correctness of InsetText::paragraphs + 12 files changed, 145 insertions(+), 358 deletions(-) Things which are not so clean: - the use of a tmp InsetText in C&P (we should tackle thi

[patch] small lyx2lyx fix

2004-03-27 Thread Georg Baum
lyxrevert_225.py adds an additional '{' to the ERT inset if it has to convert a minipage to ERT. The attached fixes that. Could somebody please apply? Georg Index: lib/lyx2lyx/ChangeLog === RCS file: /cvs/lyx/lyx-devel/lib/lyx2lyx/

math crash

2004-03-27 Thread Alfredo Braunstein
Go to Section 4.3.2 of the UG, and go down a bit -> crash #0 0x0815245f in MathArray::draw(PainterInfo&, int, int) const () #1 0x0817bf86 in MathScriptInset::draw(PainterInfo&, int, int) const () #2 0x0815246e in MathArray::draw(PainterInfo&, int, int) const () #3 0x08160802 in MathGridInset:

[BOOST patch]: boost format fix.

2004-03-27 Thread Angus Leeming
Lars, this one liner fixes a bug in the boost format library which is otherwise completely broken on a 64 bit machine. The patch has been rolled into the boost cvs tree by its maintainer already. Can I get you to apply it to the lyx boost tree please? -- AngusIndex: boost/boost/format/internals.

Re: Something is rotten in current cvs

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Sat, Mar 27, 2004 at 12:56:03AM +0100, Alfredo Braunstein wrote: >> > Missing insetiterator.C? >> >> No, just DocIterator::forwardInset in dociterator.C. > > > void DocumentIterator::forwardInset() > { > forwardPos(); > while (!empty() && (pos() == lastpos() || nextI

Re: InsetFormulaMacro: what is tmpl()?

2004-03-27 Thread Angus Leeming
Alfredo Braunstein wrote: > No idea but I've just commited an obvious fix (add the declaration). Good man. -- Angus

Re: InsetFormulaMacro: what is tmpl()?

2004-03-27 Thread Alfredo Braunstein
Angus Leeming wrote: > void InsetFormulaMacro::write(Buffer const &, ostream & os) const > { > os << "FormulaMacro "; > WriteStream wi(os, false, false); > tmpl()->write(wi); > } > No idea but I've just commited an obvious fix (add the declaration). Alfredo

InsetFormulaMacro: what is tmpl()?

2004-03-27 Thread Angus Leeming
../../../src/mathed/formulamacro.C: In member function `virtual void InsetFormulaMacro::write(const Buffer&, std::ostream&) const': ../../../src/mathed/formulamacro.C:73: error: `tmpl' undeclared (first use this function) ../../../src/mathed/formulamacro.C:73: error: (Each undeclared identifi

Re: lyx-devel src/: Bidi.C BufferView.C BufferView.h BufferVie ...

2004-03-27 Thread Alfredo Braunstein
Angus Leeming wrote: > Alfredo, are you planning to commit Andre's insetiterator patch any > time soon, or should I do it? (Now that we have a forwardInset() > definition.) Andre' seems to be commiting his stuff in this very moment. Alfredo

dociterator

2004-03-27 Thread Alfredo Braunstein
btw, we should have a right past-the-end position for dociterator (and all derivatives). Alfredo

Re: lyx-devel src/: Bidi.C BufferView.C BufferView.h BufferVie ...

2004-03-27 Thread Angus Leeming
Alfredo Braunstein wrote: > Andre Poenitz wrote: > >> On Fri, Mar 26, 2004 at 09:19:56PM +0100, Alfredo Braunstein wrote: >>> > For IU in Cut&Paste we can't use ParagraphLists as there's no >>> > such thing in math. Least common denominator would be a 'cell', >>> > which still translates to diffe

Re: cvs.lyx.org

2004-03-27 Thread Angus Leeming
Andre Poenitz wrote: > It is really strange: I can ping or ssh to lyx.cvs.org with a ping > time of 200-300ms. As soon as I start a cvs update, ping times go up > to 2-3s. Here's a thought. Why not try the anoncvs mirror? You won't be able to commit from it, but you will at least make some head wa

Re: lyx-devel src/: Bidi.C BufferView.C BufferView.h BufferVie ...

2004-03-27 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Fri, Mar 26, 2004 at 09:19:56PM +0100, Alfredo Braunstein wrote: >> > For IU in Cut&Paste we can't use ParagraphLists as there's no such >> > thing in math. Least common denominator would be a 'cell', which still >> > translates to different things in text (InsetText/LyxT

[partial patch]

2004-03-27 Thread Andre Poenitz
This is the diff of my lyx-devel vs my lyx-devel-orig (which was supposed to be a copy of last Thursdays's CVS but somehow isn't...) Andre' 1.diff Description: Binary data

cvs.lyx.org

2004-03-27 Thread Andre Poenitz
It is really strange: I can ping or ssh to lyx.cvs.org with a ping time of 200-300ms. As soon as I start a cvs update, ping times go up to 2-3s. Andre'

Re: lyx-devel src/: Bidi.C BufferView.C BufferView.h BufferVie ...

2004-03-27 Thread Andre Poenitz
On Fri, Mar 26, 2004 at 09:19:56PM +0100, Alfredo Braunstein wrote: > > For IU in Cut&Paste we can't use ParagraphLists as there's no such thing > > in math. Least common denominator would be a 'cell', which still > > translates to different things in text (InsetText/LyxText) and math > > (MathArra

Re: collapsables

2004-03-27 Thread Andre Poenitz
On Fri, Mar 26, 2004 at 08:39:11PM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > >> So: either we add an insetdim_ member in InsetCollapsable and store the > >> InsetText's dimension there, and we continue to overwrite dim_ (I have a > >> patch for this), > > > > InsetCollapsable's

Re: Something is rotten in current cvs

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 12:56:03AM +0100, Alfredo Braunstein wrote: > > Missing insetiterator.C? > > No, just DocIterator::forwardInset in dociterator.C. void DocumentIterator::forwardInset() { forwardPos(); while (!empty() && (pos() == lastpos() || nextInset() == 0))

Re: Something is rotten in current cvs

2004-03-27 Thread Andre Poenitz
On Sat, Mar 27, 2004 at 12:59:19AM +0100, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > This seems to be solvable. Attached a 'makepatch.sh' style patch that > > replaces Buffer::inset_iterator by some small wrapper around > > DocumentIterator. > > > > [Alfredo: Is this close to what yo

Re: Something is rotten in current cvs

2004-03-27 Thread Alfredo Braunstein
Alfredo Braunstein wrote: > Angus Leeming wrote: > >> On Friday 26 March 2004 7:05 pm, Andre Poenitz wrote: >>> On Thu, Mar 25, 2004 at 04:20:18PM +, Angus Leeming wrote: >>> > LyX is crashing when iterating over insets. Note the two added >>> > lines, below. That looks very, very wrong :-( >