On Sat, Mar 27, 2004 at 06:57:32PM +0000, Angus Leeming wrote:
> The attached patch moves functionality out of ControlSendto and into
> the core, where it belongs. However, I'm unsure of two things:
> 
> 1. The name. We have an LFUN_EXPORT. Maybe LFUN_SENDTO would be better
> off as LFUN_EXPORT_CUSTOM?

I think I would like the latter better.
 
> 2. Where the code should go. All these different dispatch functions
> leaves me confused ;-) I've put it in LyXFunc::dispatch. Please feel
> free to tell me that's not the right place. You'll have to explain
> why though ;-)

If it doesn't require a BufferView and uses the whole buffer and/or LyX
instance it should go to LyXFunc::dispatch.

In the long run I'd like to move the buffer specific stuff to some
buffer::dispatch() but that's now off the 1.4 list...

So you've chosen well.

Andre'

Reply via email to