Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-06 Thread Stéphane Graber
On 02/04/2013 04:53 PM, Dwight Engen wrote: > Signed-off-by: Dwight Engen Acked-by: Stéphane Graber Looks good. I slightly expanded the commit message and pushed to staging. Thanks. > --- > config/Makefile.am | 14 +++--- > config/default.conf.libvirt | 3 +++ > config/defau

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-05 Thread Dwight Engen
On Tue, 05 Feb 2013 03:05:00 +0400 Michael Tokarev wrote: > 05.02.2013 02:34, Stéphane Graber wrote: > [] > > This change was discussed a few weeks ago on this list and > > suggested by me with approval at the time by both Dwight and Serge > > who are both active lxc contributors. > > > > I haven

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Stéphane Graber
On 02/04/2013 05:02 PM, Michael Tokarev wrote: > 05.02.2013 01:57, Michael Tokarev wrote: >> 05.02.2013 01:53, Dwight Engen wrote: >>> Signed-off-by: Dwight Engen >> [lots of changes, no explanation...] >> >> What for? Why? >> >> This change is purely cosmetic, it has no visible benefit >> (and n

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Michael Tokarev
05.02.2013 02:34, Stéphane Graber wrote: [] > This change was discussed a few weeks ago on this list and suggested by > me with approval at the time by both Dwight and Serge who are both > active lxc contributors. > > I haven't reviewed Dwight's implementation yet but will very soon and > expect to

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Stéphane Graber
On 02/04/2013 05:02 PM, Michael Tokarev wrote: > 05.02.2013 01:57, Michael Tokarev wrote: >> 05.02.2013 01:53, Dwight Engen wrote: >>> Signed-off-by: Dwight Engen >> [lots of changes, no explanation...] >> >> What for? Why? >> >> This change is purely cosmetic, it has no visible benefit >> (and n

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Michael Tokarev
05.02.2013 01:53, Dwight Engen wrote: > Signed-off-by: Dwight Engen [lots of changes, no explanation...] What for? Why? This change is purely cosmetic, it has no visible benefit (and no explanations are given in the patch too), but it sure breaks compatibility with previously installed and perf

Re: [lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Michael Tokarev
05.02.2013 01:57, Michael Tokarev wrote: > 05.02.2013 01:53, Dwight Engen wrote: >> Signed-off-by: Dwight Engen > [lots of changes, no explanation...] > > What for? Why? > > This change is purely cosmetic, it has no visible benefit > (and no explanations are given in the patch too), but it > sure

[lxc-devel] [PATCH] rename /etc/lxc/lxc.conf to /etc/lxc/default.conf

2013-02-04 Thread Dwight Engen
Signed-off-by: Dwight Engen --- config/Makefile.am | 14 +++--- config/default.conf.libvirt | 3 +++ config/default.conf.ubuntu | 3 +++ config/default.conf.unknown | 1 + config/lxc.conf.libvirt | 3 --- config/lxc.conf.ubuntu | 3 --- config/lxc.conf.unknown