Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-27 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > Serge Hallyn writes: > Anyway I just wanted to point it out because I hadn't seen it in the > conversation and the mount --make-rshared / command is a single function > call which makes it an easy change to make. Even if there are more > compre

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-25 Thread Eric W. Biederman
Serge Hallyn writes: > Quoting Eric W. Biederman (ebied...@xmission.com): >> Serge Hallyn writes: >> >> > Quoting Michael H. Warfield (m...@wittsend.com): >> >> On Wed, 2013-01-16 at 16:46 -0600, Serge Hallyn wrote: >> >> > Quoting Michael H. Warfield (m...@wittsend.com): >> >> > > Serge, >> >>

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-25 Thread Serge Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > Serge Hallyn writes: > > > Quoting Michael H. Warfield (m...@wittsend.com): > >> On Wed, 2013-01-16 at 16:46 -0600, Serge Hallyn wrote: > >> > Quoting Michael H. Warfield (m...@wittsend.com): > >> > > Serge, > >> > > > >> > > Revisiting an ear

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-24 Thread Eric W. Biederman
Serge Hallyn writes: > Quoting Michael H. Warfield (m...@wittsend.com): >> On Wed, 2013-01-16 at 16:46 -0600, Serge Hallyn wrote: >> > Quoting Michael H. Warfield (m...@wittsend.com): >> > > Serge, >> > > >> > > Revisiting an earlier remark... >> > ... >> > > > Now I tested, and with a simple se

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-17 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Wed, 2013-01-16 at 16:46 -0600, Serge Hallyn wrote: > > Quoting Michael H. Warfield (m...@wittsend.com): > > > Serge, > > > > > > Revisiting an earlier remark... > > ... > > > > Now I tested, and with a simple setup we can use a much simpler >

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-17 Thread Michael H. Warfield
On Wed, 2013-01-16 at 16:46 -0600, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > Serge, > > > > Revisiting an earlier remark... > ... > > > Now I tested, and with a simple setup we can use a much simpler > > > patch which just does mount("", "/", NULL, MS_SLAVE|MS_REC,

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-16 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > Serge, > > Revisiting an earlier remark... ... > > Now I tested, and with a simple setup we can use a much simpler > > patch which just does mount("", "/", NULL, MS_SLAVE|MS_REC, 0); > > for the whole of chroot_into_slave() (and skips the new umou

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-16 Thread Michael H. Warfield
Serge, Revisiting an earlier remark... On Thu, 2012-12-20 at 09:03 -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On 12/20/2012 06:58 AM, Serge Hallyn wrote: > ... > > /proc/mounts in the container will also end up being polluted by all the > > mount points from t

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-09 Thread Michael H. Warfield
On Wed, 2013-01-09 at 08:25 -0600, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Wed, 2013-01-09 at 21:27 +0800, Alexander Vladimirov wrote: > > > 2013/1/9 Michael H. Warfield : > > > > On Tue, 2013-01-08 at 15:40 -0500, Michael H. Warfield wrote: > > > >> On Wed, 20

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-09 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Wed, 2013-01-09 at 21:27 +0800, Alexander Vladimirov wrote: > > 2013/1/9 Michael H. Warfield : > > > On Tue, 2013-01-08 at 15:40 -0500, Michael H. Warfield wrote: > > >> On Wed, 2013-01-09 at 04:31 +0800, Alexander Vladimirov wrote: > > >> > Wel

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-09 Thread Michael H. Warfield
On Wed, 2013-01-09 at 21:27 +0800, Alexander Vladimirov wrote: > 2013/1/9 Michael H. Warfield : > > On Tue, 2013-01-08 at 15:40 -0500, Michael H. Warfield wrote: > >> On Wed, 2013-01-09 at 04:31 +0800, Alexander Vladimirov wrote: > >> > Well, properly placed hook could do all the things MAKEDEV sup

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-09 Thread Alexander Vladimirov
2013/1/9 Michael H. Warfield : > On Tue, 2013-01-08 at 15:40 -0500, Michael H. Warfield wrote: >> On Wed, 2013-01-09 at 04:31 +0800, Alexander Vladimirov wrote: >> > Well, properly placed hook could do all the things MAKEDEV supposed to do. >> >> And would give us the flexibility to worry about thi

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-08 Thread Michael H. Warfield
On Tue, 2013-01-08 at 15:40 -0500, Michael H. Warfield wrote: > On Wed, 2013-01-09 at 04:31 +0800, Alexander Vladimirov wrote: > > Well, properly placed hook could do all the things MAKEDEV supposed to do. > > And would give us the flexibility to worry about things like serial > devices or some US

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-08 Thread Michael H. Warfield
On Wed, 2013-01-09 at 04:31 +0800, Alexander Vladimirov wrote: > Well, properly placed hook could do all the things MAKEDEV supposed to do. And would give us the flexibility to worry about things like serial devices or some USB devices or a few other things that would ordinarily be populated by ud

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-08 Thread Alexander Vladimirov
Well, properly placed hook could do all the things MAKEDEV supposed to do. 2013/1/9 Serge Hallyn : > Quoting Michael H. Warfield (m...@wittsend.com): >> More on the MAKEDEV debacle... > ... >> This whole thing with MAKEDEV is looking more and more like a morass >> with no way to cleanly resolve it

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-08 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > More on the MAKEDEV debacle... ... > This whole thing with MAKEDEV is looking more and more like a morass > with no way to cleanly resolve it. It sounds like consensus is it should be dropped from staging?

Re: [lxc-devel] [PATCH] Support MS_SHARED / - issues calling MAKEDEV

2013-01-08 Thread Michael H. Warfield
More on the MAKEDEV debacle... On Mon, 2013-01-07 at 09:48 -0600, Serge Hallyn wrote: > Quoting Michael H. Warfield (m...@wittsend.com): > > On Sun, 2013-01-06 at 06:39 +0800, Alexander Vladimirov wrote: > > > It is a separate package in Arch Linux and I dont have it installed on > > > the host, a

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-08 Thread Serge Hallyn
Quoting Dwight Engen (dwight.en...@oracle.com): > On Mon, 07 Jan 2013 13:26:44 -0500 > "Michael H. Warfield" wrote: > > > On Tue, 2013-01-08 at 01:32 +0800, Alexander Vladimirov wrote: > > > 2013/1/8 Serge Hallyn : > > > > Quoting Alexander Vladimirov > > > > (alexander.idkfa.vladimi...@gmail.com

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Dwight Engen
On Mon, 07 Jan 2013 13:26:44 -0500 "Michael H. Warfield" wrote: > On Tue, 2013-01-08 at 01:32 +0800, Alexander Vladimirov wrote: > > 2013/1/8 Serge Hallyn : > > > Quoting Alexander Vladimirov > > > (alexander.idkfa.vladimi...@gmail.com): > > >> Just like on the host: > > >> [idkfa@s10 ~]$ ls -la

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Michael H. Warfield
On Tue, 2013-01-08 at 01:32 +0800, Alexander Vladimirov wrote: > 2013/1/8 Serge Hallyn : > > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > >> Just like on the host: > >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > >> crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /d

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > 2013/1/8 Serge Hallyn : > > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > >> Just like on the host: > >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > >> crw-rw-rw- 1 root root 1, 7 янв 6 13

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
2013/1/8 Serge Hallyn : > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): >> Just like on the host: >> [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} >> crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full >> crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null >> crw-rw-r

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > Just like on the host: > [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full > crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null > crw-rw-rw- 1 root tty 5, 0 янв 8 00:0

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
Just like on the host: [idkfa@s10 ~]$ ls -la /dev/{null,tty,urandom,zero,full} crw-rw-rw- 1 root root 1, 7 янв 6 13:30 /dev/full crw-rw-rw- 1 root root 1, 3 янв 6 13:30 /dev/null crw-rw-rw- 1 root tty 5, 0 янв 8 00:03 /dev/tty crw-rw-rw- 1 root root 1, 9 янв 6 13:30 /dev/urandom crw-rw-rw- 1 r

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > I also noticed device nodes having strange permissions when /dev is > being auto-populated > > [idkfa@lxc0 ~]$ ls -la /dev/{null,tty,urandom,zero,full} > crwxr-xr-x 1 root root 1, 7 Jan 6 05:56 /dev/full > crwxr-xr-x 1 root ro

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > On Sun, 2013-01-06 at 06:39 +0800, Alexander Vladimirov wrote: > > It is a separate package in Arch Linux and I dont have it installed on > > the host, as well as in container since everything works well without > > it > > Well, that would explain

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Alexander Vladimirov
Sure, I'll do that 2013/1/7 Serge Hallyn : > Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): >> I can confirm it works for Arch Linux with systemd 196 >> >> However I see exactly one message saying: >> sh: /sbin/MAKEDEV: No such file or directory > > Oh, then we should at le

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Alexander Vladimirov (alexander.idkfa.vladimi...@gmail.com): > I can confirm it works for Arch Linux with systemd 196 > > However I see exactly one message saying: > sh: /sbin/MAKEDEV: No such file or directory Oh, then we should at least check for its existence before running it. Do y

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-07 Thread Serge Hallyn
Quoting Michael H. Warfield (m...@wittsend.com): > I see a call to "/sbin/MAKEDEV console" in src/lxc/conf.c. Not sure if > it's that call that's generating the problem but there is no MAKEDEV in Right. With lxc.autodev, upstart's "mounted MOUNTPOINT=/dev" gets sent (bc /dev gets mounted) which

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-05 Thread Alexander Vladimirov
I also noticed device nodes having strange permissions when /dev is being auto-populated [idkfa@lxc0 ~]$ ls -la /dev/{null,tty,urandom,zero,full} crwxr-xr-x 1 root root 1, 7 Jan 6 05:56 /dev/full crwxr-xr-x 1 root root 1, 3 Jan 6 05:56 /dev/null crwxr-xr-x 1 root root 5, 0 Jan 6 05:56 /dev/tty

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-05 Thread Michael H. Warfield
On Sun, 2013-01-06 at 06:39 +0800, Alexander Vladimirov wrote: > It is a separate package in Arch Linux and I dont have it installed on > the host, as well as in container since everything works well without > it Well, that would explain it. What isn't explained is why we need it. This is the ru

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-05 Thread Alexander Vladimirov
I can confirm it works for Arch Linux with systemd 196 However I see exactly one message saying: sh: /sbin/MAKEDEV: No such file or directory 2013/1/6 Michael H. Warfield : > Hey Serge! > > Took longer for me to test this out on Fedora 18 Beta than I had > expected. I got tangled up trying to

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2013-01-05 Thread Michael H. Warfield
Hey Serge! Took longer for me to test this out on Fedora 18 Beta than I had expected. I got tangled up trying to get bridge networking working and my day job wanted to get in my way... :-P I hear down that F18 final has been delayed again but anticipated for Jan 15. I'll test that when it beco

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2012-12-27 Thread Michael H. Warfield
On Thu, 2012-12-20 at 09:03 -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On 12/20/2012 06:58 AM, Serge Hallyn wrote: > ... > > /proc/mounts in the container will also end up being polluted by all the > > mount points from the host, this in itself doesn't cause any

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2012-12-20 Thread Michael H. Warfield
Hey Serge, I saw your patch and your comment about being out till the 2nd. I'm also out until the 27th myself and away from my clusters. On Thu, 2012-12-20 at 09:03 -0600, Serge Hallyn wrote: > Quoting Stéphane Graber (stgra...@ubuntu.com): > > On 12/20/2012 06:58 AM, Serge Hallyn wrote: > ... >

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2012-12-20 Thread Serge Hallyn
Quoting Stéphane Graber (stgra...@ubuntu.com): > On 12/20/2012 06:58 AM, Serge Hallyn wrote: ... > /proc/mounts in the container will also end up being polluted by all the > mount points from the host, this in itself doesn't cause any big > problem, though the container will try (and fail) to unmou

Re: [lxc-devel] [PATCH] Support MS_SHARED /

2012-12-20 Thread Stéphane Graber
On 12/20/2012 06:58 AM, Serge Hallyn wrote: > (I'll be out until Jan 2, but in the meantime, here is hopefully a > little newyears gift - this seems to allow lxc-start with / being > MS_SHARED on the host) > > When / is MS_SHARED (for instance with f18 and modern arch), lxc-start > fails on pivot_

[lxc-devel] [PATCH] Support MS_SHARED /

2012-12-19 Thread Serge Hallyn
(I'll be out until Jan 2, but in the meantime, here is hopefully a little newyears gift - this seems to allow lxc-start with / being MS_SHARED on the host) When / is MS_SHARED (for instance with f18 and modern arch), lxc-start fails on pivot_root. The kernel enforces that, when doing pivot_root,