On 2007-06-28, at 23:37, David A. Greene wrote:
On Thursday 28 June 2007 21:51, Nick Lewycky wrote:
David Greene wrote:
+// Cray [dag]: Must recompute end() each iteration because
it may
Please don't mark the comments as being from Cray. Just write the
comment as a standard explanatio
Hi Evan,
> +/// propagateEHRegister - The specified EH register is required in a
> successor
> +/// of the EH landing pad. Propagate it (by adding it to livein) to all the
> +/// blocks in the paths between the landing pad and the specified block.
thanks for this fix. For the moment we don't re
David Greene wrote:
> +// Cray [dag]: Must recompute end() each iteration because it may
Please don't mark the comments as being from Cray. Just write the
comment as a standard explanation.
Nick
___
llvm-commits mailing list
llvm-commits@cs.uiuc.edu
> Next stage into switch lowering refactoring
> 1. Fix some bugs in the jump table lowering threshold
> 2. Implement much better metric for optimal pivot selection
> 3. Tune thresholds for different lowering methods
> 4. Implement shift-and trick for lowering small ( length) cases with few destinat
On Apr 4, 2007, at 6:17 PM, Reid Spencer wrote:
>>
>> I'm fine with it aborting if you don't want to implement the lowering
>> code.
>
> As you'd rather have an abort, I'll change it.
>
Thank you,
-Chris
___
llvm-commits mailing list
llvm-commits@cs.u
On Wed, 2007-04-04 at 18:06 -0700, Chris Lattner wrote:
> On Apr 4, 2007, at 5:54 PM, Reid Spencer wrote:
>
> > On Wed, 2007-04-04 at 17:37 -0700, Chris Lattner wrote:
> >>> Implement the llvm.bit.part_select.iN.iN.iN overloaded intrinsic.
> >>
> >> Urr? This is obviously incorrect. I'd much rat
On Apr 4, 2007, at 5:54 PM, Reid Spencer wrote:
> On Wed, 2007-04-04 at 17:37 -0700, Chris Lattner wrote:
>>> Implement the llvm.bit.part_select.iN.iN.iN overloaded intrinsic.
>>
>> Urr? This is obviously incorrect. I'd much rather have the code
>> generator assert and die on an unsupported int
On Wed, 2007-04-04 at 17:37 -0700, Chris Lattner wrote:
> > Implement the llvm.bit.part_select.iN.iN.iN overloaded intrinsic.
>
> Urr? This is obviously incorrect. I'd much rather have the code
> generator assert and die on an unsupported intrinsic than to
> miscompile it silently.
Okay, bu
> Implement the llvm.bit.part_select.iN.iN.iN overloaded intrinsic.
Urr? This is obviously incorrect. I'd much rather have the code
generator assert and die on an unsupported intrinsic than to
miscompile it silently.
-Chris
>
> ---
> Diffs of the changes: (+5 -0)
>
> SelectionDAGISel.cpp
> // FIXME: Distinguish between a formal with no [sz]ext
> attribute from one
> // that is zero extended!
> if (FTy->paramHasAttr(j, FunctionType::ZExtAttribute))
> - Flags |= 0;
> + Flags &= ~(SDISelParamFlags::Signed);
this should set the zext bit.
> case Promote
> Some comments:
>
> 1. Why 27 - 31 instead of 3 - 6?
I preferred to separate multi-bit values from boolean values.
> Please add comment to
> SelectionDAGNodes.h (see CALL).
Added.
> 2. Purely a stylistic nitpick. Please add a space between // and the
> actual comment.
Added.
On Feb 13, 2007, at 5:50 AM, Lauro Ramos Venancio wrote:
>
>
> Changes in directory llvm/lib/CodeGen/SelectionDAG:
>
> SelectionDAGISel.cpp updated: 1.361 -> 1.362
> ---
> Log message:
>
> Add "original alignment" to function arguments flags.
>
>
> ---
> Diffs of the changes: (+30 -10)
>
> Selec
12 matches
Mail list logo
