[llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Dan Gohman
Changes in directory llvm/lib/CodeGen: LiveIntervalAnalysis.cpp updated: 1.247 -> 1.248 VirtRegMap.cpp updated: 1.112 -> 1.113 --- Log message: Replace M_REMATERIALIZIBLE and the newly-added isOtherReMaterializableLoad with a general target hook to identify rematerializable instructions. Some i

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Evan Cheng
Yes, it looks good. I can deal with LDRcp and friends later. Thanks. Evan On Jun 18, 2007, at 2:35 PM, Dan Gohman wrote: >> We can eliminate LDRcp, that's fine. >> >> However, I still don't like the separate hook and targetinstrinfo >> bit. Dan, can you have just a single isTriviallyReMateriali

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Dan Gohman
> We can eliminate LDRcp, that's fine. > > However, I still don't like the separate hook and targetinstrinfo > bit. Dan, can you have just a single isTriviallyReMaterializable hook > that encompass all these? What do you think about the attached patch? It's not tested yet, but it shows what I

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Evan Cheng
We can eliminate LDRcp, that's fine. However, I still don't like the separate hook and targetinstrinfo bit. Dan, can you have just a single isTriviallyReMaterializable hook that encompass all these? Evan On Jun 18, 2007, at 9:42 AM, Chris Lattner wrote: > > On Jun 18, 2007, at 7:46 AM, Dan

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Chris Lattner
On Jun 18, 2007, at 7:46 AM, Dan Gohman wrote: >> Is this necessary? ARM is already doing this by marking trivially re- >> materializable instructions with let isReMaterializable = 1. > > It's not necessary, but it seems cleaner :-). > > In the ARM target, other than instructions that are always

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-18 Thread Dan Gohman
> Is this necessary? ARM is already doing this by marking trivially re- > materializable instructions with let isReMaterializable = 1. It's not necessary, but it seems cleaner :-). In the ARM target, other than instructions that are always trivially rematerialiable, there's only LDR, with a ReMat

Re: [llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-17 Thread Evan Cheng
Hi Dan, Is this necessary? ARM is already doing this by marking trivially re- materializable instructions with let isReMaterializable = 1. Evan On Jun 14, 2007, at 1:51 PM, Dan Gohman wrote: > > > Changes in directory llvm/lib/CodeGen: > > LiveIntervalAnalysis.cpp updated: 1.246 -> 1.247 > Vir

[llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2007-06-14 Thread Dan Gohman
Changes in directory llvm/lib/CodeGen: LiveIntervalAnalysis.cpp updated: 1.246 -> 1.247 VirtRegMap.cpp updated: 1.111 -> 1.112 --- Log message: Add a target hook to allow loads from constant pools to be rematerialized, and an implementation for x86. --- Diffs of the changes: (+6 -3) LiveI

[llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp

2006-12-06 Thread Evan Cheng
Changes in directory llvm/lib/CodeGen: LiveIntervalAnalysis.cpp updated: 1.201 -> 1.202 VirtRegMap.cpp updated: 1.83 -> 1.84 --- Log message: MI keeps a ptr of TargetInstrDescriptor, use it. --- Diffs of the changes: (+5 -3) LiveIntervalAnalysis.cpp |3 ++- VirtRegMap.cpp |

[llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp VirtRegMap.h

2006-05-01 Thread Chris Lattner
Changes in directory llvm/lib/CodeGen: LiveIntervalAnalysis.cpp updated: 1.155 -> 1.156 VirtRegMap.cpp updated: 1.62 -> 1.63 VirtRegMap.h updated: 1.19 -> 1.20 --- Log message: Remove previous patch, which wasn't quite right. --- Diffs of the changes: (+23 -24) LiveIntervalAnalysis.cpp |

[llvm-commits] CVS: llvm/lib/CodeGen/LiveIntervalAnalysis.cpp VirtRegMap.cpp VirtRegMap.h

2006-04-30 Thread Evan Cheng
Changes in directory llvm/lib/CodeGen: LiveIntervalAnalysis.cpp updated: 1.154 -> 1.155 VirtRegMap.cpp updated: 1.60 -> 1.61 VirtRegMap.h updated: 1.18 -> 1.19 --- Log message: Local spiller kills a store if the folded restore is turned into a copy. But this is incorrect if the spilled value li