[llvm-branch-commits] [mlir] [mlir][memref][NFC] Simplify `constifyIndexValues` (PR #135940)

2025-04-16 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/135940 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [mlir] [mlir][memref][NFC] Simplify `constifyIndexValues` (PR #135940)

2025-04-16 Thread Quentin Colombet via llvm-branch-commits
@@ -88,101 +88,30 @@ SmallVector memref::getMixedSizes(OpBuilder &builder, // Utility functions for propagating static information //===--===// -/// Helper function that infers the constant values from a lis

[llvm-branch-commits] [llvm] CodeGen: Trim redundant template argument from defusechain_iterator (PR #135024)

2025-04-10 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/135024 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Remove subreg def check for insert_subreg (PR #130085)

2025-03-11 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/130085 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Remove subreg def check for bitcast (PR #130086)

2025-03-06 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/130086 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] RegAlloc: Use new approach to handling failed allocations (PR #128469)

2025-02-25 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/128469 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] Reapply "RegAlloc: Fix verifier error after failed allocation (#119690)" (PR #128400)

2025-02-25 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/128400 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Allow introducing subregister uses on reg_sequence (PR #127052)

2025-02-13 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/127052 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Handle subregister compose when looking through reg_sequence (PR #127051)

2025-02-13 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/127051 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Fix looking for def of current copy to coalesce (PR #125533)

2025-02-04 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. Let's roll with it then! https://github.com/llvm/llvm-project/pull/125533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[llvm-branch-commits] [llvm] PeepholeOpt: Fix looking for def of current copy to coalesce (PR #125533)

2025-02-03 Thread Quentin Colombet via llvm-branch-commits
@@ -1002,17 +1003,15 @@ bool PeepholeOptimizer::optimizeCondBranch(MachineInstr &MI) { /// share the same register file as \p Reg and \p SubReg. The client should /// then be capable to rewrite all intermediate PHIs to get the next source. /// \return False if no alternative s

[llvm-branch-commits] [llvm] AMDGPU: Use default shouldRewriteCopySrc (PR #125535)

2025-02-03 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/125535 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Simplify tracking of current op for copy and reg_sequence (PR #124224)

2025-01-27 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/124224 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] PeepholeOpt: Stop allocating tiny helper classes (PR #123936)

2025-01-22 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. I only skimmed through the changes but they make sense. Do you see any compile time improvements over these? Otherwise LGTM. (The PR/commit could have the NFC tag, right?) https://github.com/llvm/llvm-project/pull/123936 _

[llvm-branch-commits] [llvm] PeepholeOpt: Remove check for subreg index on a def operand (PR #123943)

2025-01-22 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. Nice catch! https://github.com/llvm/llvm-project/pull/123943 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co

[llvm-branch-commits] [llvm] [Coalescer] Consider NewMI's subreg index when updating lanemask. (PR #121780)

2025-01-06 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. Looks good. https://github.com/llvm/llvm-project/pull/121780 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-co

[llvm-branch-commits] [llvm] [Coalescer] Consider NewMI's subreg index when updating lanemask. (PR #121780)

2025-01-06 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet edited https://github.com/llvm/llvm-project/pull/121780 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [Coalescer] Consider NewMI's subreg index when updating lanemask. (PR #121780)

2025-01-06 Thread Quentin Colombet via llvm-branch-commits
@@ -1508,14 +1508,14 @@ bool RegisterCoalescer::reMaterializeTrivialDef(const CoalescerPair &CP, //undef %2.subreg:reg = INST %1:reg ; DefMI (rematerializable), // ; DefSubIdx = subreg //%3:reg = COPY %2

[llvm-branch-commits] [llvm] RegAllocGreedy: Fix subrange based instruction split logic (PR #120199)

2024-12-23 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/120199 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] RegAllocGreedy: Fix subrange based instruction split logic (PR #120199)

2024-12-23 Thread Quentin Colombet via llvm-branch-commits
@@ -1387,18 +1357,34 @@ static bool readsLaneSubset(const MachineRegisterInfo &MRI, DestSrc->Destination->getSubReg() == DestSrc->Source->getSubReg()) return false; + Register Reg = VirtReg.reg(); + // FIXME: We're only considering uses, but should be consider d

[llvm-branch-commits] [llvm] RegAlloc: Fix failure on undef use when all registers are reserved (PR #119647)

2024-12-13 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/119647 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] RegAlloc: Do not fatal error if there are no registers in the alloc order (PR #119640)

2024-12-13 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. https://github.com/llvm/llvm-project/pull/119640 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] RegAlloc: Do not fatal error if there are no registers in the alloc order (PR #119640)

2024-12-12 Thread Quentin Colombet via llvm-branch-commits
@@ -192,3 +177,50 @@ void RegAllocBase::enqueue(const LiveInterval *LI) { << " in skipped register class\n"); } } + +MCPhysReg RegAllocBase::getErrorAssignment(const TargetRegisterClass &RC, + const MachineInstr

[llvm-branch-commits] [llvm] release/19.x: [RegisterCoalescer] Fix SUBREG_TO_REG handling in the RegisterCoalescer. (#96839) (PR #101071)

2024-07-30 Thread Quentin Colombet via llvm-branch-commits
https://github.com/qcolombet approved this pull request. Thanks for the back port. LGTM https://github.com/llvm/llvm-project/pull/101071 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[llvm-branch-commits] [llvm] 905623b - [NFC][LICM] Minor improvements to debug output

2021-01-11 Thread Quentin Colombet via llvm-branch-commits
Author: Quentin Colombet Date: 2021-01-11T18:02:49-08:00 New Revision: 905623b64df0c865d4dddc4a60aff9751fbaa0e0 URL: https://github.com/llvm/llvm-project/commit/905623b64df0c865d4dddc4a60aff9751fbaa0e0 DIFF: https://github.com/llvm/llvm-project/commit/905623b64df0c865d4dddc4a60aff9751fbaa0e0.di

[llvm-branch-commits] [llvm-branch] r261586 - [AArch64] Fix bug in prolog clobbering live reg when shrink wrapping.

2016-02-22 Thread Quentin Colombet via llvm-branch-commits
Author: qcolombet Date: Mon Feb 22 16:27:47 2016 New Revision: 261586 URL: http://llvm.org/viewvc/llvm-project?rev=261586&view=rev Log: [AArch64] Fix bug in prolog clobbering live reg when shrink wrapping. This adapts r261349 to the release branch. Modified: llvm/branches/release_38/lib/Targ

[llvm-branch-commits] [llvm-branch] r258269 - Merging r258221:

2016-01-19 Thread Quentin Colombet via llvm-branch-commits
Author: qcolombet Date: Tue Jan 19 19:14:03 2016 New Revision: 258269 URL: http://llvm.org/viewvc/llvm-project?rev=258269&view=rev Log: Merging r258221: r258221 | qcolombet | 2016-01-19 15:29:03 -0800 (Tue, 19 Jan 2016) | 8 l

[llvm-branch-commits] [llvm-branch] r258268 - Merging r258207:

2016-01-19 Thread Quentin Colombet via llvm-branch-commits
Author: qcolombet Date: Tue Jan 19 19:09:12 2016 New Revision: 258268 URL: http://llvm.org/viewvc/llvm-project?rev=258268&view=rev Log: Merging r258207: r258207 | qcolombet | 2016-01-19 14:31:12 -0800 (Tue, 19 Jan 2016) | 1 l

[llvm-branch-commits] [llvm-branch] r244976 - [release_37] Revert r242173 since it breaks R9 290X.

2015-08-13 Thread Quentin Colombet via llvm-branch-commits
Author: qcolombet Date: Thu Aug 13 17:52:11 2015 New Revision: 244976 URL: http://llvm.org/viewvc/llvm-project?rev=244976&view=rev Log: [release_37] Revert r242173 since it breaks R9 290X. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91588 Modified: llvm/branches/release_37/include/