On Tue, May 4, 2021 at 8:35 PM Mehdi AMINI wrote:
>
>
>
> On Tue, May 4, 2021 at 4:24 AM Aaron Ballman via cfe-dev
> wrote:
>>
>> On Mon, May 3, 2021 at 1:24 PM Krzysztof Parzyszek via cfe-dev
>> wrote:
>> >
>> > Statement:
>> >
>> > Our current code review policy states[1]:
>> >
>> > “Code rev
> > The commit email has a URL: link, e.g. this recent one (which has no
> > Dn review):
> >
> > URL:
> > https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3
> >
> > Does that take you to a different place than the rG link would?
> > Seems like they ought to go
The github URL is not the "rG" one being referred to here. If you wanted to
do a post-commit review on the commit, you'd go to
https://reviews.llvm.org/rGb04148f77713c92ee57b33b7b858ad18ce8d78e3, which
is a part of Phabricator. You can comment on this page, much in the same
way as you would a D
On Tue, May 4, 2021 at 9:56 AM wrote:
>
> > You're right that doing post-commit reviews on Phabricator is not
> > seamless---the rG link is not included anywhere. Hopefully that could be
> > fixed with some Phabricator configuration tweaks, like sending the commit
> > email to the -commits list.
> You're right that doing post-commit reviews on Phabricator is not
> seamless---the rG link is not included anywhere. Hopefully that could be
> fixed with some Phabricator configuration tweaks, like sending the commit
> email to the -commits list.
The commit email has a URL: link, e.g. this rece
You're right that doing post-commit reviews on Phabricator is not
seamless---the rG link is not included anywhere. Hopefully that could be fixed
with some Phabricator configuration tweaks, like sending the commit email to
the -commits list.
I'm not sure if there is a general fix for the spam i
On Mon, May 3, 2021 at 1:24 PM Krzysztof Parzyszek via cfe-dev
wrote:
>
> Statement:
>
> Our current code review policy states[1]:
>
> “Code reviews are conducted, in order of preference, on our web-based
> code-review tool (see Code Reviews with Phabricator), by email on the
> relevant project’
On Mon, 3 May 2021, Krzysztof Parzyszek via cfe-dev wrote:
Potential future direction:
This section presents a potential future evolution of the review process.
Christian has conducted experiments suggesting that we can replace the
XXX-commits mailing lists with notifications directly from Pha
