The github URL is not the "rG" one being referred to here. If you wanted to do a post-commit review on the commit, you'd go to https://reviews.llvm.org/rGb04148f77713c92ee57b33b7b858ad18ce8d78e3, which is a part of Phabricator. You can comment on this page, much in the same way as you would a Dxxxxxx review.
On Tue, 4 May 2021 at 14:56, via lldb-dev <lldb-dev@lists.llvm.org> wrote: > > You're right that doing post-commit reviews on Phabricator is not > > seamless---the rG link is not included anywhere. Hopefully that could be > > fixed with some Phabricator configuration tweaks, like sending the commit > > email to the -commits list. > > The commit email has a URL: link, e.g. this recent one (which has no > Dnnnnn review): > > URL: > https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3 > > Does that take you to a different place than the rG link would? > Seems like they ought to go to the same place. > --paulr > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev >
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
