On Tue, May 4, 2021 at 9:56 AM <paul.robin...@sony.com> wrote: > > > You're right that doing post-commit reviews on Phabricator is not > > seamless---the rG link is not included anywhere. Hopefully that could be > > fixed with some Phabricator configuration tweaks, like sending the commit > > email to the -commits list. > > The commit email has a URL: link, e.g. this recent one (which has no > Dnnnnn review): > > URL: > https://github.com/llvm/llvm-project/commit/b04148f77713c92ee57b33b7b858ad18ce8d78e3 > > Does that take you to a different place than the rG link would? > Seems like they ought to go to the same place.
That sends you to the GitHub commit for the change. The corresponding rG link would be: https://reviews.llvm.org/rGb04148f77713c92ee57b33b7b858ad18ce8d78e3 ~Aaron _______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
