llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This PR adds support for `obj2yaml` and `yaml2obj` to generate minidumps that
have a Memory64List stream. This is a prerequisite to #101086.
Worth noting
- const dropped on minidumps so we could cache a Memo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0891ccc0c68c35e17562c752955788f08054bcdb
9be9a32f57c5bd516eb5e64282ed71292a78c27a --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
`lldb-server --server` works on Windows now w/o multithreading. The rest
functionality remains unchanged.
Added also PipeWindows::WriteWithTimeout(), fixed
PipeWindows::ReadWithTimeout() and missing init
Author: David Spickett
Date: 2024-07-31T08:37:42+01:00
New Revision: aa07282a25c3d6df04af9a4d34874cc433c9c68a
URL:
https://github.com/llvm/llvm-project/commit/aa07282a25c3d6df04af9a4d34874cc433c9c68a
DIFF:
https://github.com/llvm/llvm-project/commit/aa07282a25c3d6df04af9a4d34874cc433c9c68a.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Host::LaunchProcess() requires to SetMonitorProcessCallback. This callback is
called from the child process monitor thread. We cannot control this thread
anyway. lldb-server may crash if there is a loggin
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c35c4c72e4977258fc1da940e0470e8d0671bf07
c785238cf366746a383e74a89be7c7431cd41d3c --e
Author: Dmitry Vasilyev
Date: 2024-07-31T17:51:06+04:00
New Revision: 93fecc2577ece0329f3bbe2719bbc5b4b9b30010
URL:
https://github.com/llvm/llvm-project/commit/93fecc2577ece0329f3bbe2719bbc5b4b9b30010
DIFF:
https://github.com/llvm/llvm-project/commit/93fecc2577ece0329f3bbe2719bbc5b4b9b30010.dif
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is an alternative, much simpler implementation of #99305. In this
version I replace the AnyModule wildcard match with a special TypeQuery flag
which achieves (mostly) the same thing.
It is a preparatory
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d8b985c9490664f7ec923e59cf6c603d998179ae
e87b2b24cd673584aabd00eaf6ad8fc4c0c52c98 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alexandre Perez (aperez)
Changes
This introduces a `target.object-map` which allows us to remap module
locations, much in the same way as source mapping works today. This is useful,
for instance, when debugging coredumps, so we can replace
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
12189f800585ab459afa20b4f159db93ae474b57...5221c6f267fffd811c6dd39dbbcc211e2a93739c
lldb/
Author: Jonas Devlieghere
Date: 2024-07-31T09:57:10-07:00
New Revision: 8398ad9cb21736dc57ee4dd766bd0859ef9bd000
URL:
https://github.com/llvm/llvm-project/commit/8398ad9cb21736dc57ee4dd766bd0859ef9bd000
DIFF:
https://github.com/llvm/llvm-project/commit/8398ad9cb21736dc57ee4dd766bd0859ef9bd000.d
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/101365
This is used by various system routines (the capabilities checker and dyld to
name a few) to add extra color to an abort. This patch adds a frame
recognizer so people can easily see the details, and also ad
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This is used by various system routines (the capabilities checker and dyld to
name a few) to add extra color to an abort. This patch adds a frame
recognizer so people can easily see the details, and also adds the
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
80c0e8d572d3b1c34d66faffc42bcfc9432583ec...5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 80c0e8d572d3b1c34d66faffc42bcfc9432583ec
5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 --e
Author: Felipe de Azevedo Piovezan
Date: 2024-07-31T10:25:31-07:00
New Revision: 9fe455fd0c7d6f2107b33b37c04bbd3b12fe65b3
URL:
https://github.com/llvm/llvm-project/commit/9fe455fd0c7d6f2107b33b37c04bbd3b12fe65b3
DIFF:
https://github.com/llvm/llvm-project/commit/9fe455fd0c7d6f2107b33b37c04bbd3b1
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/101365
>From 5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Tue, 30 Jul 2024 09:32:24 -0700
Subject: [PATCH 1/2] Add a StackFrameRecognizer for the Darwin specific
abort_wit
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/101365
>From 5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Tue, 30 Jul 2024 09:32:24 -0700
Subject: [PATCH 1/3] Add a StackFrameRecognizer for the Darwin specific
abort_wit
https://github.com/jimingham approved this pull request.
LGTM I like that you also changed "Update" to "ModuleWasUpdated", that's more
accurate. `m_initialized` isn't quite the right name, it means "needs work"
not "initialized" which sounds like it should happen once.
If you can think of a be
Author: Alexandre Perez
Date: 2024-07-31T10:57:40-07:00
New Revision: 0a01e8ff530ab15277aa9fad5361297d7b55e247
URL:
https://github.com/llvm/llvm-project/commit/0a01e8ff530ab15277aa9fad5361297d7b55e247
DIFF:
https://github.com/llvm/llvm-project/commit/0a01e8ff530ab15277aa9fad5361297d7b55e247.dif
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Fixed few bugs in PipeWindows. Added the test for async read/write.
---
Full diff: https://github.com/llvm/llvm-project/pull/101383.diff
7 Files Affected:
- (modified) lldb/include/lldb/Host/PipeBase.h
zeroomega wrote:
Hi @medismailben
We are seeing redefinition of pid_t error again on windows builder:
https://lab.llvm.org/buildbot/#/builders/141/builds/1254
after multiple revert and reland like e72cdae47b4e263ea97b2bdd75cf44c1510cf3be.
Could you revert the change please? Could you also not
@@ -0,0 +1,211 @@
+"""
+Test that the FrameRecognizer for __abort_with_payload
+works properly
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+class TestAbortWithPayload(TestBase
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dimitry Andric (DimitryAndric)
Changes
…() declarations
Similar to #97796, fix the type of the `native_thread` parameter for
the arm, mips64 and powerpc variants of `NativeRegisterContextFreeBSD_*`.
Otherwise, this leads to compile errors
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
971a1ac4451017e625f81a4a8c15092c06dd2eb3...ed18268a5501a7d6e2aa03717d3c36a1040d2ad4
lldb/
Author: Dimitry Andric
Date: 2024-08-01T09:28:29+02:00
New Revision: 7088a5ed880f29129ec844c66068e8cb61ca98bf
URL:
https://github.com/llvm/llvm-project/commit/7088a5ed880f29129ec844c66068e8cb61ca98bf
DIFF:
https://github.com/llvm/llvm-project/commit/7088a5ed880f29129ec844c66068e8cb61ca98bf.diff
Author: Kendal Harland
Date: 2024-08-02T10:03:39+01:00
New Revision: 3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac
URL:
https://github.com/llvm/llvm-project/commit/3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac
DIFF:
https://github.com/llvm/llvm-project/commit/3c3851f3ed837aaae7df76e9a4cbb866dbfee3ac.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
We plan to eventually use the Clang driver to initialize the `CompilerInstance`.
This should make refactorings of this code more straightforward.
---
Full diff: https://github.com/llvm/llvm-project/pull/10
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This reverts commit 9effefbae8d96006a4dd29bb9ab8532fd408559d.
With the include order in ScriptedProcessPythonInterface.cpp fixed (though I
cannot explain exactly why it works) and removes the /H flag
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Same motivation as https://github.com/llvm/llvm-project/pull/101669. We plan to
eventually use the Clang driver to initialize the `CompilerInstance`.
This should make refactorings of this code more straigh
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
`CreateTargetInfo` can return a `nullptr` in a couple cases. So we should log
that and let the user know something is wrong (hence the `lldbassert`).
I didn't actually run into this. Just stumbled upon it
Author: David Spickett
Date: 2024-08-02T08:55:26-07:00
New Revision: 9d07f43676f03460d913aabd503ae8154cabdda1
URL:
https://github.com/llvm/llvm-project/commit/9d07f43676f03460d913aabd503ae8154cabdda1
DIFF:
https://github.com/llvm/llvm-project/commit/9d07f43676f03460d913aabd503ae8154cabdda1.diff
Author: Michael Buch
Date: 2024-08-02T18:13:35+01:00
New Revision: d6cbcf93b227befaad00957a56acd63c837c26ff
URL:
https://github.com/llvm/llvm-project/commit/d6cbcf93b227befaad00957a56acd63c837c26ff
DIFF:
https://github.com/llvm/llvm-project/commit/d6cbcf93b227befaad00957a56acd63c837c26ff.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch adds a shell test to verify the output of the `scripting template
list` command.
---
Full diff: https://github.com/llvm/llvm-project/pull/101726.diff
1 Files Affected:
- (added) lldb/
Author: Michael Buch
Date: 2024-08-02T19:13:41+01:00
New Revision: 5c1d7689738d144613e7915c0b6ec850dd5c3956
URL:
https://github.com/llvm/llvm-project/commit/5c1d7689738d144613e7915c0b6ec850dd5c3956
DIFF:
https://github.com/llvm/llvm-project/commit/5c1d7689738d144613e7915c0b6ec850dd5c3956.diff
Author: Med Ismail Bennani
Date: 2024-08-02T11:20:39-07:00
New Revision: 737c387f8be15cf3d6004d3f58a3ce5763f7f9e8
URL:
https://github.com/llvm/llvm-project/commit/737c387f8be15cf3d6004d3f58a3ce5763f7f9e8
DIFF:
https://github.com/llvm/llvm-project/commit/737c387f8be15cf3d6004d3f58a3ce5763f7f9e8.
Author: Jacob Lalonde
Date: 2024-08-02T13:35:05-07:00
New Revision: 3e4af616334eae532f308605b89ff158dd195180
URL:
https://github.com/llvm/llvm-project/commit/3e4af616334eae532f308605b89ff158dd195180
DIFF:
https://github.com/llvm/llvm-project/commit/3e4af616334eae532f308605b89ff158dd195180.diff
Author: Michael Buch
Date: 2024-08-02T22:27:40+01:00
New Revision: 12e3a06cb7615fbd91031420f3dec2a85d7877d6
URL:
https://github.com/llvm/llvm-project/commit/12e3a06cb7615fbd91031420f3dec2a85d7877d6
DIFF:
https://github.com/llvm/llvm-project/commit/12e3a06cb7615fbd91031420f3dec2a85d7877d6.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
In #100443, Mach-o and Minidump now only call process API's that take a
`SaveCoreOption` as the container for the style and information if a thread
should be included in the core or not. This introduced a bu
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1ae837ab34424a0b81bcc9a4fabc89e36cd57235...9d105b25b2e0721d68db8dca60cb155d233d0933
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1ae837ab34424a0b81bcc9a4fabc89e36cd57235
9d105b25b2e0721d68db8dca60cb155d233d0933 --e
Author: Jacob Lalonde
Date: 2024-08-02T18:38:05-07:00
New Revision: 34766d0d488ba2fbefa80dcd0cc8720a0e753448
URL:
https://github.com/llvm/llvm-project/commit/34766d0d488ba2fbefa80dcd0cc8720a0e753448
DIFF:
https://github.com/llvm/llvm-project/commit/34766d0d488ba2fbefa80dcd0cc8720a0e753448.diff
jeffreytan81 wrote:
@jimingham, it has been a while. Any other major changes you want to see? Thanks
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
Author: Matheus Izvekov
Date: 2024-08-04T23:28:54-03:00
New Revision: 7f78f99fe5af82361d37adcbd2daa4d04afba13d
URL:
https://github.com/llvm/llvm-project/commit/7f78f99fe5af82361d37adcbd2daa4d04afba13d
DIFF:
https://github.com/llvm/llvm-project/commit/7f78f99fe5af82361d37adcbd2daa4d04afba13d.dif
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch loosen the parsing requirement to allow parsing not only JSON
dictionaries but also JSON arrays.
---
Full diff: https://github.com/llvm/llvm-project/pull/101929.diff
2 Files Affected:
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
8d1b17b6623742ec4454f5bae2e23f8b30124314...54081f56181d954365f9ab762ca6715e28119ad4
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
Following 9a9ec228cdcf, since the ThreadPlanPython class started making use of
the Scripted Interface instead of calling directly into the python methods,
this class can work with other scripting l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch addresses an issue that will arise with future SDKs. The
ClangExpressionParser currently unconditionally sets
`-fbuiltin-headers-in-system-modules` when evaluating expressions with the
`target.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch is a follow-up to #97263 that fix ambigous abbreviated
command resolution.
When multiple commands are resolved, instead of failing to pick a command to
run, this patch changes to resolu
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch renames the `scripting template` subcommand to be `scripting
extension` instead since that would make more sense for upcoming commands.
---
Full diff: https://github.com/llvm/llvm-projec
https://github.com/sedymrak created
https://github.com/llvm/llvm-project/pull/101981
StepScope enum is a type whose values are passed around, but they are
ultimately ignored.
>From 8abb0771e646dfc46d832f03485b288a4be08168 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Ko=C5=A1=C3=ADk?=
Date
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (sedymrak)
Changes
StepScope enum is a type whose values are passed around, but they are
ultimately ignored.
---
Full diff: https://github.com/llvm/llvm-project/pull/101981.diff
1 Files Affected:
- (modified) lldb/source/Commands/C
Author: Pavel Labath
Date: 2024-08-05T17:06:07+02:00
New Revision: 212950fbcec3b71fa15ee49e0539333a30159c32
URL:
https://github.com/llvm/llvm-project/commit/212950fbcec3b71fa15ee49e0539333a30159c32
DIFF:
https://github.com/llvm/llvm-project/commit/212950fbcec3b71fa15ee49e0539333a30159c32.diff
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/101935
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9fea73110ecc0a13d18e5c52f8e7fa62a9de9ee9
8abb0771e646dfc46d832f03485b288a4be08168 --e
Author: Med Ismail Bennani
Date: 2024-08-05T09:35:27-07:00
New Revision: 5689cccead7b70d8eeae4c641e8078e6d3c50b9a
URL:
https://github.com/llvm/llvm-project/commit/5689cccead7b70d8eeae4c641e8078e6d3c50b9a
DIFF:
https://github.com/llvm/llvm-project/commit/5689cccead7b70d8eeae4c641e8078e6d3c50b9a.
Matej =?utf-8?q?Košík?=
Message-ID:
In-Reply-To:
https://github.com/sedymrak updated
https://github.com/llvm/llvm-project/pull/101981
>From 8abb0771e646dfc46d832f03485b288a4be08168 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Ko=C5=A1=C3=ADk?=
Date: Mon, 5 Aug 2024 13:47:02 +0200
Subject
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
… Options. (#100443)"
This reverts commit 3e4af616334eae532f308605b89ff158dd195180.
@adrian-prantl FYI
Reverts #100443
---
Patch is 40.32 KiB, truncated to 20.00 KiB below, full version:
https://github.
Author: Jacob Lalonde
Date: 2024-08-05T10:17:25-07:00
New Revision: accf5c9bb3b5fe88628a44062a5c0c2f903fca2c
URL:
https://github.com/llvm/llvm-project/commit/accf5c9bb3b5fe88628a44062a5c0c2f903fca2c
DIFF:
https://github.com/llvm/llvm-project/commit/accf5c9bb3b5fe88628a44062a5c0c2f903fca2c.diff
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 72c9e24ed92149e853fc215cdf07e3afe34ae146
c2eb655327120d794c49a21908c5c664f3283f92 --e
jimingham wrote:
IIUC, you are adding a new rule that if an incoming command name has partial
matches to one user command and one alias command, the user command is
preferred over the alias command. Is that right?
You certainly should document that rule somewhere - maybe in the Tutorial
sect
https://github.com/jimingham approved this pull request.
Makes sense, none of this is Python specific so the name is not appropriate.
https://github.com/llvm/llvm-project/pull/101931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
Author: Med Ismail Bennani
Date: 2024-08-05T10:43:42-07:00
New Revision: 039cfe812c15c8f9e52ddb8cfc183fd8c927dba5
URL:
https://github.com/llvm/llvm-project/commit/039cfe812c15c8f9e52ddb8cfc183fd8c927dba5
DIFF:
https://github.com/llvm/llvm-project/commit/039cfe812c15c8f9e52ddb8cfc183fd8c927dba5.
@@ -395,6 +396,11 @@ class ThreadPlan : public
std::enable_shared_from_this,
bool IsControllingPlan() { return m_is_controlling_plan; }
+ // Returns true if this plan is a leaf plan, meaning the plan will be popped
jimingham wrote:
Leaf plans are only au
@@ -813,12 +819,17 @@ bool Thread::ShouldStop(Event *event_ptr) {
// decide whether they still need to do more work.
bool done_processing_current_plan = false;
-
if (!current_plan->PlanExplainsStop(event_ptr)) {
if (current_plan->TracerExplainsStop()) {
done
jimingham wrote:
Ack, sorry, I missed that you had updated this. My notifications from GitHub
are somewhat flakey...
I didn't understand why you are checking both "IsLeafPlan" and
"MischiefManaged", why does MischiefManaged get to override IsLeafPlan?
https://github.com/llvm/llvm-project/pul
Author: Dmitry Vasilyev
Date: 2024-08-05T22:11:24+04:00
New Revision: ddb9869dd2b5c54fc2369287299e11b9a618d71a
URL:
https://github.com/llvm/llvm-project/commit/ddb9869dd2b5c54fc2369287299e11b9a618d71a
DIFF:
https://github.com/llvm/llvm-project/commit/ddb9869dd2b5c54fc2369287299e11b9a618d71a.dif
Author: sedymrak
Date: 2024-08-05T11:23:57-07:00
New Revision: 248c53429427034f45705af60d47f3b1090c4799
URL:
https://github.com/llvm/llvm-project/commit/248c53429427034f45705af60d47f3b1090c4799
DIFF:
https://github.com/llvm/llvm-project/commit/248c53429427034f45705af60d47f3b1090c4799.diff
LOG:
Matej =?utf-8?q?Košík?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
@sedymrak Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm
jimingham wrote:
> > IIUC, you are adding a new rule that if an incoming command name has
> > partial matches to one user command and one alias command, the user command
> > is preferred over the alias command. Is that right?
>
> Yes.
>
> > You certainly should document that rule somewhere -
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sam James (thesamesam)
Changes
AddressableBits uses `uint32_t` without including `` which fails
to build w/ GCC 15 after a change in libstdc++ [0]
[0]
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3a817a4a5a6d94da9127af3be9f84a74
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This patch extends TypeQuery matching to support anonymous namespaces. A new
flag is added to control the behavior. In the "strict" mode, the query must
match the type exactly -- all anonymous namespaces inclu
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
d337f5aa59fecd2413b076ed9573e378c57c1307...c6936f3d5d0592babe9082e867b179af594c447b
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d337f5aa59fecd2413b076ed9573e378c57c1307
c6936f3d5d0592babe9082e867b179af594c447b --e
Author: Sam James
Date: 2024-08-06T09:58:36+01:00
New Revision: bb59f04e7e75dcbe39f1bf952304a157f0035314
URL:
https://github.com/llvm/llvm-project/commit/bb59f04e7e75dcbe39f1bf952304a157f0035314
DIFF:
https://github.com/llvm/llvm-project/commit/bb59f04e7e75dcbe39f1bf952304a157f0035314.diff
LOG
llvmbot wrote:
/pull-request llvm/llvm-project#102112
https://github.com/llvm/llvm-project/pull/102110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This fixes a regression caused by delayed type definition searching (#96755 and friends): If we end up adding a member (e.g. a typedef) to a type
that we've already attempted to complete (and failed), the resul
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
…Type
This is needed to ensure we find a type if its definition is in a CU that
wasn't indexed. This can happen if the definition is in some precompiled code
(e.g. the c++ standard library) which was built wi
Author: Vladislav Dzhidzhoev
Date: 2024-08-06T15:07:12+02:00
New Revision: a0fa9a308d20786ceb63b5d021c7f643ea2ef1c2
URL:
https://github.com/llvm/llvm-project/commit/a0fa9a308d20786ceb63b5d021c7f643ea2ef1c2
DIFF:
https://github.com/llvm/llvm-project/commit/a0fa9a308d20786ceb63b5d021c7f643ea2ef1c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
That aren't the generated `python_api/` pages.
This button is a pencil icon at the top right of the page and takes you to a
GitHub page where you can edit the content, assuming you have a fork already
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
4c670b266a10d613a58b71cc9c3d3a21cb6dc36b...8fddf6f57dcb4bcdef78139f49718fcc2ea0fd20
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch changes the return type of `GetMetadata` from a `ClangASTMetadata*`
to a `std::optional`. Except for one call-site
(`SetDeclIsForcefullyCompleted`), we never actually make use
temyurchenko wrote:
> > I don't have the full context but I can definitely run the lldb test suite
> > for you. I'm building now. (BTW, I see there are some merge conflicts on
> > the PR.)
>
> I have the results now. The patch is based on a fairly old revision, so it
> didn't work for me with
https://github.com/temyurchenko updated
https://github.com/llvm/llvm-project/pull/98795
>From 24ee56b5a104bdc8434413458f23b2d271764c78 Mon Sep 17 00:00:00 2001
From: Artem Yurchenko <44875844+temyurche...@users.noreply.github.com>
Date: Thu, 30 May 2024 16:18:47 -0400
Subject: [PATCH 1/4] [clang
royitaqi wrote:
> LGTM. Could we cover this scenario by the existing unit test?
Yes, definitely.
At the time of the patch I didn't find any existing unit test files by
searching for "ProgressTest.cpp". Just now I realize there is the
[ProgressReportTest.cpp](https://github.com/llvm/llvm-proje
jimingham wrote:
This patch almost certainly caused this asan failure:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/581/consoleText
Can you take a look?
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits ma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This fix is based on a problem with cxx_compiler and cxx_linker macros on
Windows.
There was an issue with compiler detection in paths containing "icc". In such
case, Makefile.rules thought it was
@@ -1003,6 +1010,21 @@ class Platform : public PluginInterface {
FileSpec GetModuleCacheRoot();
};
+class PlatformMetadata {
+public:
+ PlatformMetadata(Debugger &debugger, const ScriptedMetadata metadata);
+ ~PlatformMetadata() = default;
+
+ Debugger &GetDebugger() cons
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/99814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
This is a pretty big patch, since it's only failing on ASAN bots, I'd give
@jeffreytan81 a bit to see if it's something obvious before reverting that.
reverts aren't 100% free, they can make cherrypicking a hassle, so...
https://github.com/llvm/llvm-project/pull/90930
___
Author: Kevin Frei
Date: 2024-08-06T11:06:04-07:00
New Revision: e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218
URL:
https://github.com/llvm/llvm-project/commit/e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218
DIFF:
https://github.com/llvm/llvm-project/commit/e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218.diff
LO
jeffreytan81 wrote:
@jimingham, @adrian-prantl , thanks for letting me know. Surprised that I did
not get failure email.
Do you know how I can reproduce the failure?
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb
jimingham wrote:
The console logs for the bots usually have the CMake command used to configure
the tree for the test. The one I referred to above has:
'/usr/local/bin/cmake' '-G' 'Ninja'
'/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm'
'-DCMAKE_BUILD_TYPE
jeffreytan81 wrote:
I think I understand the lifetime issue that caused the ASAN failure. I will
fix it.
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/102208
This PR fixes the ASAN failure in
https://github.com/llvm/llvm-project/pull/90930.
The original PR made the assumption that parent `ThreadPlanStepOverRange`'s
lifetime will always be longer than `ThreadP
601 - 700 of 93530 matches
Mail list logo
