llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: None (sedymrak) <details> <summary>Changes</summary> StepScope enum is a type whose values are passed around, but they are ultimately ignored. --- Full diff: https://github.com/llvm/llvm-project/pull/101981.diff 1 Files Affected: - (modified) lldb/source/Commands/CommandObjectThread.cpp (+8-12) ``````````diff diff --git a/lldb/source/Commands/CommandObjectThread.cpp b/lldb/source/Commands/CommandObjectThread.cpp index 366b6dd965b38..fcf46843ba674 100644 --- a/lldb/source/Commands/CommandObjectThread.cpp +++ b/lldb/source/Commands/CommandObjectThread.cpp @@ -247,8 +247,6 @@ class CommandObjectThreadBacktrace : public CommandObjectIterateOverThreads { CommandOptions m_options; }; -enum StepScope { eStepScopeSource, eStepScopeInstruction }; - #define LLDB_OPTIONS_thread_step_scope #include "CommandOptions.inc" @@ -374,14 +372,13 @@ class CommandObjectThreadStepWithTypeAndScope : public CommandObjectParsed { CommandObjectThreadStepWithTypeAndScope(CommandInterpreter &interpreter, const char *name, const char *help, const char *syntax, - StepType step_type, - StepScope step_scope) + StepType step_type) : CommandObjectParsed(interpreter, name, help, syntax, eCommandRequiresProcess | eCommandRequiresThread | eCommandTryTargetAPILock | eCommandProcessMustBeLaunched | eCommandProcessMustBePaused), - m_step_type(step_type), m_step_scope(step_scope), + m_step_type(step_type), m_class_options("scripted step") { AddSimpleArgumentList(eArgTypeThreadIndex, eArgRepeatOptional); @@ -621,7 +618,6 @@ class CommandObjectThreadStepWithTypeAndScope : public CommandObjectParsed { } StepType m_step_type; - StepScope m_step_scope; ThreadStepScopeOptionGroup m_options; OptionGroupPythonClassWithDict m_class_options; OptionGroupOptions m_all_options; @@ -2561,35 +2557,35 @@ CommandObjectMultiwordThread::CommandObjectMultiwordThread( interpreter, "thread step-in", "Source level single step, stepping into calls. Defaults " "to current thread unless specified.", - nullptr, eStepTypeInto, eStepScopeSource))); + nullptr, eStepTypeInto))); LoadSubCommand("step-out", CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope( interpreter, "thread step-out", "Finish executing the current stack frame and stop after " "returning. Defaults to current thread unless specified.", - nullptr, eStepTypeOut, eStepScopeSource))); + nullptr, eStepTypeOut))); LoadSubCommand("step-over", CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope( interpreter, "thread step-over", "Source level single step, stepping over calls. Defaults " "to current thread unless specified.", - nullptr, eStepTypeOver, eStepScopeSource))); + nullptr, eStepTypeOver))); LoadSubCommand("step-inst", CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope( interpreter, "thread step-inst", "Instruction level single step, stepping into calls. " "Defaults to current thread unless specified.", - nullptr, eStepTypeTrace, eStepScopeInstruction))); + nullptr, eStepTypeTrace))); LoadSubCommand("step-inst-over", CommandObjectSP(new CommandObjectThreadStepWithTypeAndScope( interpreter, "thread step-inst-over", "Instruction level single step, stepping over calls. " "Defaults to current thread unless specified.", - nullptr, eStepTypeTraceOver, eStepScopeInstruction))); + nullptr, eStepTypeTraceOver))); LoadSubCommand( "step-scripted", @@ -2600,7 +2596,7 @@ CommandObjectMultiwordThread::CommandObjectMultiwordThread( "that will be used to populate an SBStructuredData Dictionary, which " "will be passed to the constructor of the class implementing the " "scripted step. See the Python Reference for more details.", - nullptr, eStepTypeScripted, eStepScopeSource))); + nullptr, eStepTypeScripted))); LoadSubCommand("plan", CommandObjectSP(new CommandObjectMultiwordThreadPlan( interpreter))); `````````` </details> https://github.com/llvm/llvm-project/pull/101981 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
