Author: sas
Date: Mon Aug 6 15:04:08 2018
New Revision: 339068
URL: http://llvm.org/viewvc/llvm-project?rev=339068&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
Author: sas
Date: Mon Aug 6 15:21:28 2018
New Revision: 339071
URL: http://llvm.org/viewvc/llvm-project?rev=339071&view=rev
Log:
Revert "Add a relocation for R_AARCH64_ABS32 in ObjectFileELF"
This reverts commit f055ce7eb893cd0d17ebcfd4125018f46f983aff.
Modified:
lldb/trunk/source/Plugins/O
Author: sas
Date: Thu Aug 16 17:35:47 2018
New Revision: 339974
URL: http://llvm.org/viewvc/llvm-project?rev=339974&view=rev
Log:
Add a relocation for R_AARCH64_ABS32 in ObjectFileELF
Summary:
.rela.debug_info relocations are being done via
ObjectFileELF::ApplyRelocations for aarch64. Currently,
Author: sas
Date: Wed Aug 22 15:25:45 2018
New Revision: 340460
URL: http://llvm.org/viewvc/llvm-project?rev=340460&view=rev
Log:
Add include directory for libxml on macOS
Summary:
Builds fail because libxml/xmlreader.h isn't found. Adding the include
directory to the include list fixes the issue
Makes sense. I'll update the diff.
On Mon, Nov 6, 2017 at 9:28 AM Zachary Turner wrote:
> This is definitely required, but only on windows. I’d put it behind a
> check for Windows, and I’d also add a check to print a warning/error if
> (TARGET lld) returns false on windows
> On Mon, Nov 6, 2017
Author: sas
Date: Mon Nov 6 11:25:33 2017
New Revision: 317501
URL: http://llvm.org/viewvc/llvm-project?rev=317501&view=rev
Log:
Add a dependency from check-lldb on lld
Summary:
This is required when using the in-tree clang for building tests,
because -fuse-ld=lld is used by default.
Subscriber
I think @zturner is correct. Shared libraries do work with lldb on Windows,
just just that these tests are not buildable for Windows.
On Mon, Nov 6, 2017 at 1:56 PM Zachary Turner wrote:
> It’s been a long time since I looked at this but I remember it just being
> a problem in the Makefiles, not
Author: sas
Date: Mon Nov 6 16:14:40 2017
New Revision: 317529
URL: http://llvm.org/viewvc/llvm-project?rev=317529&view=rev
Log:
Disable tests in lang/c/shared_lib on Windows
Summary: These fail because `-fPIC` is not supported on Windows.
Reviewers: zturner, jingham, clayborg
Reviewed By: cla
Author: sas
Date: Mon Nov 13 12:13:25 2017
New Revision: 318079
URL: http://llvm.org/viewvc/llvm-project?rev=318079&view=rev
Log:
Reformat a comment. NFC.
Modified:
lldb/trunk/include/lldb/lldb-private-defines.h
Modified: lldb/trunk/include/lldb/lldb-private-defines.h
URL:
http://llvm.org/v
Author: sas
Date: Wed Nov 22 15:56:32 2017
New Revision: 318886
URL: http://llvm.org/viewvc/llvm-project?rev=318886&view=rev
Log:
Run clang-format on source/Host/common/Symbols.cpp
I saw a bunch of style errors so this fixes them.
Modified:
lldb/trunk/source/Host/common/Symbols.cpp
Modified
Author: sas
Date: Mon Nov 27 13:16:37 2017
New Revision: 319095
URL: http://llvm.org/viewvc/llvm-project?rev=319095&view=rev
Log:
Mark UUID::GetByteSize() const
Summary:
This method doesn't modify anything in the object it's called on so we
can mark it const to make it usable in a const context.
Author: sas
Date: Mon Nov 27 17:26:07 2017
New Revision: 319132
URL: http://llvm.org/viewvc/llvm-project?rev=319132&view=rev
Log:
Remove some duplicated code in UUID.cpp
Summary: Formatting needs to be done only once. Ran check-lldb and nothing
changes.
Reviewers: clayborg, davide
Reviewed By:
Author: sas
Date: Tue Nov 28 09:50:31 2017
New Revision: 319191
URL: http://llvm.org/viewvc/llvm-project?rev=319191&view=rev
Log:
Simplify UUID constructors
Summary: This remove a small amount of duplicated code.
Reviewers: clayborg, zturner, davide
Subscribers: lldb-commits
Differential Revis
Yeah, just a quick note about ds2, this is the current status of supported
platforms:
* Linux (x86/x86_64/arm/aarch64), used for debugging processes on "classic"
linux (Ubuntu, centOS, etc), Android, as well as Tizen.
* Windows (x86/x86_64/arm), used to debug processes on Windows Desktop,
Windows P
Author: sas
Date: Fri Mar 31 13:00:48 2017
New Revision: 299239
URL: http://llvm.org/viewvc/llvm-project?rev=299239&view=rev
Log:
Verify memory address range validity in GDBRemoteCommunicationClient
Summary:
This aims to verify the validity of the response from the debugging
server in GDBRemoteCo
Author: sas
Date: Tue May 23 13:54:03 2017
New Revision: 303674
URL: http://llvm.org/viewvc/llvm-project?rev=303674&view=rev
Log:
hange RenderScriptx86ABIFixups.cpp to use llvm::AttributeList iterator
LLVM::AttributeList recently had getNumSlots() removed, which broke the
build. This fixes the bu
Author: sas
Date: Tue May 23 14:22:31 2017
New Revision: 303677
URL: http://llvm.org/viewvc/llvm-project?rev=303677&view=rev
Log:
Fix bad change in RenderScriptx86ABIFixups.cpp, forgot to change everything
necessary
Summary: I didn't change all instances of i to I in this loop. I am a bad
perso
Author: sas
Date: Mon Jun 5 12:44:04 2017
New Revision: 304725
URL: http://llvm.org/viewvc/llvm-project?rev=304725&view=rev
Log:
Avoid invalid string access in ObjCLanguage::MethodName::SetName
Summary:
Don't access `name[1] if the string is only of length 1. Avoids a
crash/assertion failure w
What difference does this make?
On Fri, Sep 15, 2017 at 8:00 PM Eugene Zemtsov via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: eugene
> Date: Fri Sep 15 19:58:49 2017
> New Revision: 313437
>
> URL: http://llvm.org/viewvc/llvm-project?rev=313437&view=rev
> Log:
> Check availabili
Author: sas
Date: Fri Sep 22 16:41:41 2017
New Revision: 314045
URL: http://llvm.org/viewvc/llvm-project?rev=314045&view=rev
Log:
Implement trampoline step-through for Windows-x86.
Summary:
This is required to be able to step through calls to external functions
that are not properly marked with _
Author: sas
Date: Thu Sep 28 12:49:00 2017
New Revision: 314455
URL: http://llvm.org/viewvc/llvm-project?rev=314455&view=rev
Log:
Add a few missing newlines in lldb-server messages
Reviewers: fjricci, clayborg
Subscribers: lldb-commits
Differential Revision: https://reviews.llvm.org/D38373
Mod
I do. We still use this but always in a remote debugging scenario so I
never had issues with this diff and I haven't gotten around to looking at
windows unit tests at all.
On Mon, Oct 2, 2017 at 9:43 AM Zachary Turner via Phabricator <
revi...@reviews.llvm.org> wrote:
> zturner added a comment.
>
Author: sas
Date: Mon Oct 9 10:49:32 2017
New Revision: 315221
URL: http://llvm.org/viewvc/llvm-project?rev=315221&view=rev
Log:
Update ABISysV_arm64::RegisterIsVolatile to accept registers prefixed with r
Summary:
While the specification says that the 64bit registers are prefixed with
`x`, it s
Author: sas
Date: Tue Oct 24 15:56:05 2017
New Revision: 316526
URL: http://llvm.org/viewvc/llvm-project?rev=316526&view=rev
Log:
Remove some dead code from ClangExpressionDeclMap.cpp
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
Modified:
lldb/trunk/
Author: sas
Date: Tue Oct 24 16:01:33 2017
New Revision: 316527
URL: http://llvm.org/viewvc/llvm-project?rev=316527&view=rev
Log:
Remove some unused function calls from ClangUserExpression.cpp
Modified:
lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp
Modified:
lldb/
Author: sas
Date: Tue Oct 24 16:40:59 2017
New Revision: 316532
URL: http://llvm.org/viewvc/llvm-project?rev=316532&view=rev
Log:
Allow ObjectFilePECOFF to initialize with ARM binaries.
Summary: This is required to start debugging WinPhone ARM targets.
Reviewers: compnerd, zturner, omjavaid
Rev
Author: sas
Date: Tue Oct 24 16:46:00 2017
New Revision: 316533
URL: http://llvm.org/viewvc/llvm-project?rev=316533&view=rev
Log:
Fix a compile warning on linux
Can't cast directly between a pointer to function and a pointer to
object.
Modified:
lldb/trunk/source/API/SBDebugger.cpp
Modified
Author: sas
Date: Thu Oct 26 10:04:20 2017
New Revision: 316673
URL: http://llvm.org/viewvc/llvm-project?rev=316673&view=rev
Log:
Allow SysV-i386 ABI on everything other than Apple targets
Summary:
This matches other SysV ABIs that are different on Apple and non-Apple targets,
like `ABISysV_arm.c
This changes nothing except for 32bit Windows, which used to not be able to
benefit from ABISysV_i386 but can use it now. The ABI support is tested
independently from Windows itself.
On Thu, Oct 26, 2017 at 10:25 AM Davide Italiano
wrote:
> On Thu, Oct 26, 2017 at 10:04 AM, Stephane Sezer
Author: sas
Date: Thu Nov 2 09:56:19 2017
New Revision: 317218
URL: http://llvm.org/viewvc/llvm-project?rev=317218&view=rev
Log:
Use LLVM version string
Summary:
macOS builds of LLDB use the bundle version from
`tools/driver/lldb-Info.plist`. That file hasn't been updated since the 4.0
release s
Author: sas
Date: Thu Nov 2 09:56:52 2017
New Revision: 317219
URL: http://llvm.org/viewvc/llvm-project?rev=317219&view=rev
Log:
Run clang-format on lldb.cpp
Modified:
lldb/trunk/source/lldb.cpp
Modified: lldb/trunk/source/lldb.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/source
Author: sas
Date: Mon Oct 31 19:21:57 2016
New Revision: 285658
URL: http://llvm.org/viewvc/llvm-project?rev=285658&view=rev
Log:
Remove executable bit on a source file
Modified:
lldb/trunk/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
(contents, props changed)
Modif
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
Cool stuff.
Are you planning on doing a similar change for other architectures?
https://reviews.llvm.org/D25947
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
sas added a comment.
Just a couple nits inline. Also, did you run `clang-format` on your change? I
see some issues with `if`s and the associated parentheses.
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:215
+ }
+ if (siginfo_signal_found == false) {
+//
I'm currently busy with other stuff but I'll get back to this soon. I
think we have a different version of this internally which seems to
work properly, so I'll make sure everything is clean and re-upload a
better version.
On Tue, Dec 20, 2016 at 11:34 AM, Greg Clayton via Phabricator
wrote:
> cl
Author: sas
Date: Tue Oct 6 13:03:04 2015
New Revision: 249434
URL: http://llvm.org/viewvc/llvm-project?rev=249434&view=rev
Log:
Fix Darwin build of lldb-server.
Summary: We were missing the symbol for the version number.
Reviewers: clayborg
Subscribers: lldb-commits
Differential Revision: ht
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249434: Fix Darwin build of lldb-server. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D13271?vs=36035&id=36638#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13271
Files:
Author: sas
Date: Wed Oct 14 15:39:41 2015
New Revision: 250322
URL: http://llvm.org/viewvc/llvm-project?rev=250322&view=rev
Log:
Avoid a -Wreorder warning in ScriptInterpreterPython.cpp.
Modified:
lldb/trunk/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
Modified:
lld
sas created this revision.
sas added reviewers: clayborg, dawn, brucem, tfiala.
sas added a subscriber: lldb-commits.
Looks like having a space in the Xcode path triggers this bug. We need
to use cmake -E env FOO=bar [COMMAND] to set the environment instead.
I am using cmake 3.3.1 and ninja 1.6.0
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250335: Fix codesign command with cmake. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D13742?vs=37387&id=37405#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13742
Files:
Author: sas
Date: Wed Oct 14 17:25:43 2015
New Revision: 250335
URL: http://llvm.org/viewvc/llvm-project?rev=250335&view=rev
Log:
Fix codesign command with cmake.
Summary:
Looks like having a space in the Xcode path triggers this bug. We need
to use cmake -E env FOO=bar [COMMAND] to set the envir
Author: sas
Date: Thu Oct 15 17:24:17 2015
New Revision: 250465
URL: http://llvm.org/viewvc/llvm-project?rev=250465&view=rev
Log:
Minor indentation fix in StackFrameList.cpp.
Modified:
lldb/trunk/source/Target/StackFrameList.cpp
Modified: lldb/trunk/source/Target/StackFrameList.cpp
URL:
htt
sas added a comment.
Adding quotes doesn't work. I think the patch that @dawn linked is good enough
even though the issue is still not fixed on older cmake versions.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL250335
___
lldb-
sas accepted this revision.
sas added a comment.
This revision is now accepted and ready to land.
Sorry for introducing this bug. I think this is good.
Repository:
rL LLVM
http://reviews.llvm.org/D13995
___
lldb-commits mailing list
lldb-commits@
sas created this revision.
sas added reviewers: dawn, brucem.
sas added a subscriber: lldb-commits.
This breaks when using a symlink from llvm/tools/lldb to the lldb source
tree, instead of cloning directly as a child. With this change, we can
build properly, even when using links.
http://reviews
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This does not have any functionnal difference but I found myself
searching for 'struct RegisterInfo$' to find a definition and couldn't
find it. The version without typedef seems more common so
Author: sas
Date: Mon Oct 26 16:32:31 2015
New Revision: 251351
URL: http://llvm.org/viewvc/llvm-project?rev=251351&view=rev
Log:
Remove some useless typedef's.
Summary:
This does not have any functionnal difference but I found myself
searching for 'struct RegisterInfo$' to find a definition and
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251351: Remove some useless typedef's. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D14091?vs=38455&id=38464#toc
Repository:
rL LLVM
http://reviews.llvm.org/D14091
Files:
ll
Author: sas
Date: Wed Oct 28 12:34:45 2015
New Revision: 251530
URL: http://llvm.org/viewvc/llvm-project?rev=251530&view=rev
Log:
Avoid using `..` in paths for include dirs.
Summary:
This breaks when using a symlink from llvm/tools/lldb to the lldb source
tree, instead of cloning directly as a ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251530: Avoid using `..` in paths for include dirs.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D14089?vs=38454&id=38670#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1408
sas added a comment.
Thanks for fixing this. Didn't test external LLVM builds.
Repository:
rL LLVM
http://reviews.llvm.org/D14166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
sas created this revision.
sas added reviewers: tberghammer, clayborg.
sas added a subscriber: lldb-commits.
Herald added a subscriber: rengolin.
This was GetAddressClass' behavior before. This is required when
debugging binaries that don't have mapping symbols ($a, $t, etc). These
binaries will o
sas added a comment.
Ok I'll integrate that with the code that uses m_address_class_map.
http://reviews.llvm.org/D14507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D19603
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
=
sas created this revision.
sas added a reviewer: zturner.
sas added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This is required to start debugging WinPhone ARM targets.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
I
sas added a comment.
@zturner, you might be right, I might have to change the code I have to load
the initial executable's `Module` and use an offset different than 0 there.
I'll wait to see what @clayborg says.
http://reviews.llvm.org/D19603
___
sas added a comment.
@compnerd:
- We don't use thumb-* triples in lldb as far as I can see. Thumb is handled
just fine regardless of the triple.
- `pc` vs `unknown` doesn't seem to matter either, and other code in this file
uses `pc` (see a few lines above).
- `msvc` vs `itanium` is also handle
sas accepted this revision.
sas added a reviewer: sas.
sas added a comment.
This revision is now accepted and ready to land.
I did the same thing back when 3.7 was the current release branch and I think
@clayborg reviewed it at that point.
Without this, we simply can't build the release branch.
sas created this revision.
sas added a reviewer: spyffe.
sas added a subscriber: lldb-commits.
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displayed.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: sou
sas added a comment.
Ah yes, good idea not to use `AsCString()` here.
I think changing the `!=` to `==` is the right thing to do here because the bug
was introduced in r263995:
@@ -122,7 +125,7 @@ IRExecutionUnit::DisassembleFunction (Stream &stream,
for (JittedFunction &function :
sas updated this revision to Diff 57854.
sas added a comment.
No need to use `.AsCString()` on these.
http://reviews.llvm.org/D20312
Files:
source/Expression/IRExecutionUnit.cpp
Index: source/Expression/IRExecutionUnit.cpp
===
-
sas accepted this revision.
sas added a comment.
This is really useful.
http://reviews.llvm.org/D20623
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas added a comment.
Nit: Adding a comment explaining why we special-case the main executable (i.e.:
because it is never included in `libraries-svr4` packets) might be useful here.
http://reviews.llvm.org/D20990
___
lldb-commits mailing list
lldb-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271863: Fix function name lookup in IRExecutionEngine.cpp.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D20312?vs=57854&id=59685#toc
Repository:
rL LLVM
http://reviews.llvm.or
Author: sas
Date: Sun Jun 5 21:50:46 2016
New Revision: 271863
URL: http://llvm.org/viewvc/llvm-project?rev=271863&view=rev
Log:
Fix function name lookup in IRExecutionEngine.cpp.
Summary:
Without this commit, when `log enable lldb expr` is enabled, the
disassembly of JIT'ed code is never displa
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
Some thread plans have public contructors, some others have protected
constructors with friend classes. Not sure how these were determined,
but this thread plan is going to be required to imple
sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.
This is required to be able to step through calls to external functions
that are not properly marked with __declspec(dllimport). When a call
like this is emitted, the linker will inject a tramp
sas updated this revision to Diff 63542.
sas added a comment.
Use arm-pc-windows intead of armv7-pc-windows.
http://reviews.llvm.org/D19604
Files:
source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Index: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
==
sas requested a review of this revision.
sas added a comment.
@jingham, it looks like the `GetStepThroughTrampolinePlan` functions do not
queue the thread plan themselves. See
`DynamicLoaderPOSIXDYLD::GetStepThroughTrampolinePlan` for instance that just
does `new ThreadPlanRunToAddress(...)`.
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
This is already done when building for linux with the CMake build
system. This functionality disappeared recently when some of the build
scripts used by the xcode build system changed.
http://r
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
http://reviews.llvm.org/D22234
Files:
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
--- scripts/Xcode/bui
sas created this revision.
sas added reviewers: tfiala, clayborg.
sas added a subscriber: lldb-commits.
When we build Debug, we might be tracking down bugs in clang/llvm as
well, so building it Debug with assertions helps debug the debugger.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj
sas updated this revision to Diff 63550.
sas added a comment.
Remove leftover comment.
http://reviews.llvm.org/D22235
Files:
lldb.xcodeproj/project.pbxproj
scripts/Xcode/build-llvm.py
Index: scripts/Xcode/build-llvm.py
===
---
sas added a subscriber: sas.
sas added a comment.
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
Sounds good. I can make a separate patch to make all the constructors
public if you think that's better. See http://reviews.llvm.org/D22230
for a patch that makes one of the constructors public.
Is this patch good to go in its current form then?
On Mon, Jul 11, 2016 at 12:21 PM, Jim Ingham wrote
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275134: Apply local patches when building llvm on Mac.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22233?vs=63547&id=63619#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Author: sas
Date: Mon Jul 11 20:28:59 2016
New Revision: 275134
URL: http://llvm.org/viewvc/llvm-project?rev=275134&view=rev
Log:
Apply local patches when building llvm on Mac.
Summary:
This is already done when building for linux with the CMake build
system. This functionality disappeared recent
sas updated this revision to Diff 63625.
sas added a comment.
Rebase.
http://reviews.llvm.org/D22230
Files:
include/lldb/Target/ThreadPlanStepInstruction.h
Index: include/lldb/Target/ThreadPlanStepInstruction.h
===
--- include/l
Author: sas
Date: Mon Jul 11 20:43:46 2016
New Revision: 275139
URL: http://llvm.org/viewvc/llvm-project?rev=275139&view=rev
Log:
Make ThreadPlanStepInstruction's constructor public.
Summary:
Some thread plans have public contructors, some others have protected
constructors with friend classes. N
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275139: Make ThreadPlanStepInstruction's constructor public.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22230?vs=63625&id=63627#toc
Repository:
rL LLVM
http://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275140: Add LLVM build config for BuildAndIntegration.
(authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D22234?vs=63548&id=63628#toc
Repository:
rL LLVM
http://reviews.llvm.org/D2
Author: sas
Date: Mon Jul 11 20:44:58 2016
New Revision: 275140
URL: http://llvm.org/viewvc/llvm-project?rev=275140&view=rev
Log:
Add LLVM build config for BuildAndIntegration.
Reviewers: tfiala, clayborg
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D22234
Modified:
sas abandoned this revision.
sas added a comment.
Ah, makes sense, I had missed the `DebugClang` build configuration. Thanks for
pointing this out.
http://reviews.llvm.org/D22235
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
sas created this revision.
sas added reviewers: jingham, clayborg.
sas added a subscriber: lldb-commits.
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false return value.
Change by Walter Erquinigo
http://reviews.llvm.org/D22278
Files
Author: sas
Date: Wed Jul 13 12:34:26 2016
New Revision: 275287
URL: http://llvm.org/viewvc/llvm-project?rev=275287&view=rev
Log:
Fix a check in the objc trampoline handler
Summary:
The function FunctionCaller::WriteFunctionArguments returns false on
errors, so they should check for the false ret
sas added a comment.
@jingham, @clayborg, this is indeed a bit fragile as having to specify your
rewrite maps manually when debugging is very error-prone. I have a patch that
fetches the path to the rewrite map from the debug info, I'm waiting for this
one to go in to upload that other diff (tr
sas added a comment.
In http://reviews.llvm.org/D22294#483250, @clayborg wrote:
> In http://reviews.llvm.org/D22294#483213, @sas wrote:
>
> > @jingham, @clayborg, this is indeed a bit fragile as having to specify your
> > rewrite maps manually when debugging is very error-prone. I have a patch
sas added a comment.
In http://reviews.llvm.org/D22294#483264, @clayborg wrote:
> Note that during function lookup, we can find **both** "putchar" and
> "__my_putchar" in the debug info, so you will be able to call both.
Correct, unless as you pointed out both symbols are in libraries, and not
Yeah I can do this today.
> On Jul 19, 2016, at 1:58 AM, Zachary Turner wrote:
>
> I can't test this on Windows until Friday because I'm traveling and my laptop
> isn't set up to build lldb. Could Stephane maybe help?
>
>
> On Tue, Jul 19, 2016 at 1:51 AM Saleem Abdulrasool
> wrote:
> compn
sas created this revision.
sas added a reviewer: tfiala.
sas added a subscriber: lldb-commits.
This is supposed to find the python lib dir and seems like it's just
been copied twice by mistake.
https://reviews.llvm.org/D22891
Files:
source/Host/CMakeLists.txt
Index: source/Host/CMakeLists.txt
Author: sas
Date: Thu Jul 28 17:11:54 2016
New Revision: 277060
URL: http://llvm.org/viewvc/llvm-project?rev=277060&view=rev
Log:
Remove a duplicated block in cmake.
Summary:
This is supposed to find the python lib dir and seems like it's just
been copied twice by mistake.
Reviewers: tfiala
Sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277060: Remove a duplicated block in cmake. (authored by
sas).
Changed prior to commit:
https://reviews.llvm.org/D22891?vs=65839&id=66038#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22891
Fil
sas created this revision.
sas added a reviewer: clayborg.
sas added subscribers: lldb-commits, fjricci.
Some debug servers don't support it so there's no point in spamming
this.
http://reviews.llvm.org/D15972
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
source/P
Author: sas
Date: Thu Jan 7 18:00:17 2016
New Revision: 257116
URL: http://llvm.org/viewvc/llvm-project?rev=257116&view=rev
Log:
Make sure we don't send qModuleInfo packets unnecessarily.
Summary:
Some debug servers don't support it so there's no point in spamming
this.
Reviewers: clayborg
Sub
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257116: Make sure we don't send qModuleInfo packets
unnecessarily. (authored by sas).
Changed prior to commit:
http://reviews.llvm.org/D15972?vs=44268&id=44288#toc
Repository:
rL LLVM
http://reviews
Author: sas
Date: Thu Jan 7 19:39:14 2016
New Revision: 257132
URL: http://llvm.org/viewvc/llvm-project?rev=257132&view=rev
Log:
Fix dwarf sequence insertions
Summary:
If two dwarf sequences begin with entries that have identical addresses,
it is possible for the comparator to order the first en
sas closed this revision.
sas added a comment.
Committed as r257132.
http://reviews.llvm.org/D15979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: sas
Date: Fri Jan 8 14:32:35 2016
New Revision: 257204
URL: http://llvm.org/viewvc/llvm-project?rev=257204&view=rev
Log:
Prevent infinite recursive loop in AppleObjCTrampolineHandler constructor
Summary:
When we construct AppleObjCTrampolineHandler, if m_impl_fn_addr is
invalid, we call
sas closed this revision.
sas added a comment.
Committed as r257204.
http://reviews.llvm.org/D15978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
sas created this revision.
sas added reviewers: tberghammer, clayborg.
sas added subscribers: lldb-commits, fjricci.
Herald added subscribers: rengolin, aemerson.
This was used with the old ARM vs. Thumb detection code but is not
required anymore.
http://reviews.llvm.org/D16099
Files:
source/P
1 - 100 of 191 matches
Mail list logo
