[Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

[Stephane Sezer via lldb-commits]

sas created this revision.
sas added reviewers: clayborg, zturner.
sas added a subscriber: lldb-commits.

Some thread plans have public contructors, some others have protected
constructors with friend classes. Not sure how these were determined,
but this thread plan is going to be required to implement trampoline
step-through on Windows.

http://reviews.llvm.org/D22230

Files:
  include/lldb/Target/ThreadPlanStepInstruction.h

Index: include/lldb/Target/ThreadPlanStepInstruction.h
===================================================================
--- include/lldb/Target/ThreadPlanStepInstruction.h
+++ include/lldb/Target/ThreadPlanStepInstruction.h
@@ -23,6 +23,12 @@
 class ThreadPlanStepInstruction : public ThreadPlan
 {
 public:
+    ThreadPlanStepInstruction (Thread &thread,
+                               bool step_over,
+                               bool stop_others,
+                               Vote stop_vote,
+                               Vote run_vote);
+
     ~ThreadPlanStepInstruction() override;
 
     void GetDescription(Stream *s, lldb::DescriptionLevel level) override;
@@ -37,11 +43,6 @@
 protected:
     bool DoPlanExplainsStop(Event *event_ptr) override;
 
-    ThreadPlanStepInstruction (Thread &thread,
-                               bool step_over,
-                               bool stop_others,
-                               Vote stop_vote,
-                               Vote run_vote);
     void SetUpState ();
 
 private:



Index: include/lldb/Target/ThreadPlanStepInstruction.h
===================================================================
--- include/lldb/Target/ThreadPlanStepInstruction.h
+++ include/lldb/Target/ThreadPlanStepInstruction.h
@@ -23,6 +23,12 @@
 class ThreadPlanStepInstruction : public ThreadPlan
 {
 public:
+    ThreadPlanStepInstruction (Thread &thread,
+                               bool step_over,
+                               bool stop_others,
+                               Vote stop_vote,
+                               Vote run_vote);
+
     ~ThreadPlanStepInstruction() override;
 
     void GetDescription(Stream *s, lldb::DescriptionLevel level) override;
@@ -37,11 +43,6 @@
 protected:
     bool DoPlanExplainsStop(Event *event_ptr) override;
 
-    ThreadPlanStepInstruction (Thread &thread,
-                               bool step_over,
-                               bool stop_others,
-                               Vote stop_vote,
-                               Vote run_vote);
     void SetUpState ();
 
 private:

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits