[Lldb-commits] [PATCH] D62474: [CMake] Remove lldb-server from LLDB.framework

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB361947: [CMake] Remove lldb-server from LLDB.framework (authored by stefan.graenitz, committed by ). Changed prior to commit: https://reviews.llvm.org/D62474?vs=201480&id=201862#toc Repository: rL

[Lldb-commits] [PATCH] D62472: [CMake] LLDB.framework tools handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL361946: [CMake] LLDB.framework tools handling (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D62764: Detect x86 mid-function epilogues that end in a jump

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362456: Add support for mid-function epilogues on x86 that end in a non-local jump. (authored by jmolenda, committed by ).

[Lldb-commits] [PATCH] D62878: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL362588: [CMake] Export CMAKE_CONFIGURATION_TYPES for the LLVM build-tree (authored by stefan.graenitz, committed by ). Ch

[Lldb-commits] [PATCH] D62879: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm-tblgen in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rL362589: [CMake] Add configuration dirs as potential locations for llvm-lit and llvm… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[Lldb-commits] [PATCH] D62859: [CMake] Add special case for processing LLDB_DOTEST_ARGS

This revision was automatically updated to reflect the committed changes. Closed by commit rL362803: [CMake] Add special case for processing LLDB_DOTEST_ARGS (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[Lldb-commits] [PATCH] D63110: Fix a crash in option parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363101: Fix a crash in option parsing. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6311

[Lldb-commits] [PATCH] D63310: Make crashlog.py less noisy

This revision was automatically updated to reflect the committed changes. Closed by commit rL363412: Make crashlog.py less noisy (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63310?v

[Lldb-commits] [PATCH] D63311: Python 3: decode string as utf-8 to avoid type mismatch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL363413: Python 3: decode string as utf-8 to avoid type mismatch. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

This revision was automatically updated to reflect the committed changes. Closed by commit rL363441: Don't try to parse ObjC method if CU isn't ObjC (authored by gclayton, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[Lldb-commits] [PATCH] D63370: Specify log level for CMake messages (less stderr)

This revision was automatically updated to reflect the committed changes. Closed by commit rL363821: Specify log level for CMake messages (less stderr) (authored by stefan.graenitz, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.org/D63370?vs

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

This revision was automatically updated to reflect the committed changes. Closed by commit rL363933: [unittests] Use object library if cmake supports it (authored by tkrasnukha, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D63544: Use object library if cmake supports it

This revision was automatically updated to reflect the committed changes. Closed by commit rL364035: [unittests] Simplify CMakeLists with object library (authored by tkrasnukha, committed by ). Changed prior to commit: https://reviews.llvm.org/D63544?vs=205816&id=205971#toc Repository: rL LL

[Lldb-commits] [PATCH] D63802: Handle nested register definition xml files from the remote serial protocol stub

This revision was automatically updated to reflect the committed changes. Closed by commit rL364484: Support nested target.xml register definition files, lack of reg group markers. (authored by jmolenda, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Change

[Lldb-commits] [PATCH] D64397: [CMake] Remove extra lldb-framework target

This revision was automatically updated to reflect the committed changes. Closed by commit rL365615: [CMake] Remove extra lldb-framework target (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[Lldb-commits] [PATCH] D64399: [CMake] Distribution builds for LLDB standalone

This revision was automatically updated to reflect the committed changes. Closed by commit rL365616: [CMake] Distribution builds for LLDB standalone (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[Lldb-commits] [PATCH] D64408: [CMake] `install-distribution` for LLDB on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL365617: [CMake] `install-distribution` for LLDB on Darwin (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[Lldb-commits] [PATCH] D64444: Add Python 3.6 and 3.7 to the version list

This revision was automatically updated to reflect the committed changes. Closed by commit rL365688: Add Python 3.6 and 3.7 to the version list (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D64806: [CMake] Always build debugserver on Darwin and allow tests to use the system's one

This revision was automatically updated to reflect the committed changes. Closed by commit rL366433: [CMake] Always build debugserver on Darwin and allow tests to use the system's… (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D64865: [CMake] Polish folders in generated Xcode project

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366459: [CMake] Polish folders in generated Xcode project (authored by stefan.graenitz, committed by ). Herald added a pro

[Lldb-commits] [PATCH] D64897: Move start-address finding to Target, implement fallback if main executable does not have a start address

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366493: Fall back to dyld's _dyld_start when no LC_MAIN / main() func can be found (authored by jmolenda, committed by ).

[Lldb-commits] [PATCH] D63667: Support __kernel_rt_sigreturn in frame initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL366580: Support Linux signal return trampolines in frame initialization (authored by josepht, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[Lldb-commits] [PATCH] D64994: [CMake] Align debugserver with lldb-server on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL366631: [CMake] Align debugserver with lldb-server on Darwin (authored by stefan.graenitz, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

tschuett added a comment. There is no syntax highlighting for Python in sphinx? The code in https://lldb.llvm.org/python_api/lldb.SBDebugger.html#lldb.SBDebugger is hard to read. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94489/new/ https://revi

[Lldb-commits] [PATCH] D94489: [lldb][docs] Use sphinx instead of epydoc to generate LLDB's Python reference

tschuett added a comment. In D94489#2503685 , @teemperor wrote: > In D94489#2503662 , @tschuett wrote: > >> There is no syntax highlighting for Python in sphinx? The code in >> https://lldb.llvm.org/python_api/lldb.

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. Shouldn't this also update PlatformiOSSimulator.h? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89156/new/ https://reviews.llvm.org/D89156 ___ lldb-commits mailing list lld

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530656 , @JosephTremoulet wrote: > In D89156#2530353 , @Abpostelnicu > wrote: > >> Shouldn't this also update PlatformiOSSimulator.h? > > There is no PlatformOSSimulator.h

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530701 , @JosephTremoulet wrote: > Oh, I see. I made this change in the master branch and then ported it to the > release/11.x branch. It changed the signature of a virtual method, which had > a couple more ove

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. And there are more issues like: https://github.com/llvm/llvm-project/blob/llvmorg-11.0.1/lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp#L733. `old_module_sp_ptr` is nowhere declared. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu created this revision. Abpostelnicu added a reviewer: JosephTremoulet. Abpostelnicu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix fallout caused by D89156 on 11.0.1 for MacOS Repositor

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320134. Abpostelnicu added a comment. Update with format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 320137. Abpostelnicu added a comment. Update for plularization of variables name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Plat

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu marked an inline comment as done. Abpostelnicu added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58 const lldb_private::FileSpecList *module_search_paths_ptr, - lldb::ModuleSP *old_mo

[Lldb-commits] [PATCH] D89156: [lldb] GetSharedModule: Collect old modules in SmallVector

Abpostelnicu added a comment. In D89156#2530839 , @tstellar wrote: > In D89156#2530703 , @Abpostelnicu > wrote: > >> In D89156#2530701 , >> @JosephTremoulet wrote: >> >>> O

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu marked an inline comment as done. Abpostelnicu added a comment. @tstellar what do you suggest to do here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 ___

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu updated this revision to Diff 321104. Abpostelnicu added a comment. rebased on 11.1rc2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 Files: lldb/source/Plugins/Platform/MacOSX/PlatformApple

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. The failure is wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. Landed in 11.1 https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312#diff-2fa23ad0cf1839955ddaf4a0d78a9d9b5fd9b88933f82f6433035916a2655c6c. Patch needs to be rebased for trunk now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D77878: [lldb] Fix a typo in a test name

This revision was automatically updated to reflect the committed changes. Closed by commit rGcea112f422ce: [lldb] Fix a typo in a test name (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77878/new/ htt

[Lldb-commits] [PATCH] D77452: [intel-pt] Improve the way the test determines whether to run

This revision was automatically updated to reflect the committed changes. Closed by commit rGda0e91fee614: [intel-pt] Improve the way the test determines whether to run (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D78839: [lldb-vscode] Add an option for loading core files

This revision was automatically updated to reflect the committed changes. Closed by commit rG83725822c525: [lldb-vscode] Add an option for loading core files (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D78839?vs=260731&id=260748#toc Re

[Lldb-commits] [PATCH] D81200: [vscode] set default values for terminateDebuggee for the disconnect request

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a9e7d0b6bef: [vscode] set default values for terminateDebuggee for the disconnect request (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D81978: Redo of Add terminateCommands to lldb-vscode protocol

This revision was automatically updated to reflect the committed changes. Closed by commit rG74ab1da0285f: Redo of Add terminateCommands to lldb-vscode protocol (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D83008: Fix ItaniumRecordLayoutBuilder so that is grabs the correct bases class offsets from the external source

tschuett added a comment. You could try: clangxx_host -Xclang -fdump-record-layouts %p/Inputs/layout.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83008/new/ https://reviews.llvm.org/D83008 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. Looks obviously good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580 __

[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

serge-sans-paille added a comment. Possible followup: shouldn't all the other `Get*` be flagged as `const` too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83580/new/ https://reviews.llvm.org/D83580

[Lldb-commits] [PATCH] D83857: Harmonize python shebang

This revision was automatically updated to reflect the committed changes. Closed by commit rG515bc8c1554f: Harmonize Python shebang (authored by serge-sans-paille). Herald added projects: clang, Sanitizers, LLDB, libc++, OpenMP, libc-project. Herald added subscribers: libc-commits, openmp-commits,

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl created this revision. aykevl added reviewers: dylanmckay, deepak2427, Andrzej, clayborg, labath. Herald added subscribers: lldb-commits, Jim, aprantl. Herald added a project: LLDB. Add bare-metal AVR support to lldb. Loading a binary works, but little else. Things that work: $ ./llvm-b

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl updated this revision to Diff 240857. aykevl added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. @labath Thank you for the quick review! I have added a test per your suggestions. I'm not very familiar with lldb but this passes the tests. CHANG

[Lldb-commits] [PATCH] D73539: [AVR] Basic support for remote debugging

aykevl added a comment. It's worth noting that I haven't managed to get a line table from a binary produced by LLVM (with my own compiler frontend) and linked by avr-gcc. But I believe that is a bug in the AVR backend of LLVM as a binary built entirely by `avr-gcc` works just fine. CHANGES SI

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

aykevl added a comment. Ok, I've updated the title and the commit message (text until the separator). Does that look good? I have commit access so I can merge this myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.llvm.org/D73539 _

[Lldb-commits] [PATCH] D73539: [AVR] Recognize the AVR architecture in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG727ed11b24c0: [AVR] Recognize the AVR architecture in lldb (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73539/new/ https://reviews.ll

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG45e3f6660cf4: Auto-completion bug fix for dot operator (authored by Hector Diaz , committed by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl created this revision. aykevl added reviewers: granata.enrico, labath, dylanmckay, Andrzej. Herald added subscribers: llvm-commits, lldb-commits, hiraditya. Herald added projects: LLDB, LLVM. Addresses are usually two bytes in size on AVR, so make sure LLDB deals with that. --- I'm not s

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. See D73969 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73961/new/ https://reviews.llvm.org/D73961 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl created this revision. aykevl added reviewers: labath, dylanmckay, Andrzej. aykevl added projects: LLVM, LLDB. Herald added subscribers: lldb-commits, aprantl. aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to te

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242340. aykevl added a comment. Added a unit test. I think it would also be a good idea to test this by loading an AVR binary and connecting to a debugger (thus triggering this code), but I don't know how to add such a test. Suggestions would be appreciated.

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl updated this revision to Diff 242694. aykevl set the repository for this revision to rG LLVM Github Monorepo. aykevl added a comment. > I do have one question though. Will the DataExtractor actually do something > reasonable for non-power-of-2 sizes (5,6,7) ? If yes, then great -- if not,

[Lldb-commits] [PATCH] D73961: [LLDB] Addresses can be two bytes in size

aykevl added a comment. > How do you normally generate the binaries with these kinds of addresses? Can > they be produced with clang? Can they be produced with llvm-mc? Linked with > lld ? With `avr-gcc`. I think it's easiest to just generate a minimal binary using `yaml2obj`. For the rest I'

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

aykevl added a comment. >> Right now there are asserts both when constructing/copying(?) the object (5 >> asserts) and at the place where `m_addr_size` is used (3 asserts). I would >> propose picking one place, such as where it is used. That would reduce the >> number of asserts to 3 and keep t

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

tatyana-krasnukha updated this revision to Diff 166507. tatyana-krasnukha added a comment. LLDB's static libraries link each other as INTERFACE, that's why CMake doesn't propagate lldbHost's include directories to lldbCore and lldbInterpreter. For lldbHost itself, I had to use PUBLIC, because its

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha updated this revision to Diff 166520. Repository: rLLDB LLDB https://reviews.llvm.org/D48623 Files: include/lldb/Core/Architecture.h source/Plugins/Architecture/Arm/ArchitectureArm.cpp source/Plugins/Architecture/Arm/ArchitectureArm.h source/Plugins/Architecture/CMake

[Lldb-commits] [PATCH] D51999: build: add libedit to include paths

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D51999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. much better! Thanks for making the changes Repository: rLLDB LLDB https://reviews.llvm.org/D48623 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D48623: Move architecture-specific address adjustment to architecture plugins.

tatyana-krasnukha added a comment. Thanks for your patience;) Repository: rLLDB LLDB https://reviews.llvm.org/D48623 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk updated this revision to Diff 166534. vsk added a comment. As discussed offline, print out a note when stepping out of a frame with artificial ancestors explaining that they were skipped while stepping out. See the added test: functionalities/tail_call_frames/thread_step_out_message. https

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz created this revision. sgraenitz added reviewers: clayborg, aprantl, jingham, jasonmolenda. Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini. So far SymbolFileDWARFDebugMap did only parse one compile unit per OSO entry. Thus, LLDB failed to resolve breakpoint locations in

[Lldb-commits] [PATCH] D52376: [API][Swig] Overloaded functions for SBTarget

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: spyffe, clayborg, zturner. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Slightly refactored typemaps to combine overloading with default arguments. Repository: rLLDB LLDB https://r

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Do you mean `ConnectToRemote` method from `lldb/tools/lldb-server/lldb-gdbserver.cpp`? https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

vsk planned changes to this revision. vsk added a comment. While testing this out, I found an issue with CallEdge::GetReturnPCAddress. Getting the load address there adds an unnecessary slide to the PC. I'll try to have that worked out next week. https://reviews.llvm.org/D50478

[Lldb-commits] [PATCH] D52376: [API][Swig] Overloaded functions for SBTarget

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This patch changes the SB API. We don't break binary compatibility with the SB API's, and especially not for something like GetInstructions/GetInstructionsWithFlavor, which are fu

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Yes, the `writeSocketIdToPipe(unnamed_pipe_fd, socket_id);` fails in this method/file. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. AFAIR, adding an `exit(...)` to `ConnectToRemote` won't solve this problem. The test will still be failing on Arch. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar created this revision. grimar added reviewers: LLDB, clayborg, aprantl, dblaikie, probinson. Herald added a subscriber: JDevlieghere. DWARF5 spec describes single file split dwarf case (when .dwo sections are in the .o files). Problem is that LLDB does not work correctly in that case. The

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Posting my mail here for the record: I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the test suit. Anyway, the actual issue is related Python 3: Arch Linux (and probably some other distributions that "already" upgraded

[Lldb-commits] [PATCH] D52406: Make DIE_IS_BEING_PARSED local to the current thread.

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a subscriber: mgorny. JDevlieghere edited the summary of this revision. This is an attempt to realize Pavel's suggestion from https://reviews.llvm.org/D48393 In https://reviews.llvm.org/D48393#1139327, @labat

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added subscribers: aprantl, apolyakov. teemperor added a comment. > AFAIR, adding an exit(...) to ConnectToRemote won't solve this problem. The > test will still be failing on Arch. I was more hoping it would at least turn the deadlock into a fail, this way I could at least run the tes

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

JDevlieghere added a comment. In https://reviews.llvm.org/D48393#1139327, @labath wrote: > It's even more complicated than that, in case you really have reference > cycles, you can have multiple threads starting parsing from different points > in that cycle, and getting deadlocked waiting for t

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

JDevlieghere added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:430 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, true); if (num_r

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. If so, we can try to run the script with python2.x. @teemperor can you try to modify `target-select-so-path.test` this way: change `# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s` to `# RUN: python2 %p/inputs/target-select-so-path.py "

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

labath added a comment. I believe you should be able to use `lldb-test` to write this kind of a test. I am thinking of a sequence like: yaml2obj %p/Inputs/test.yaml > %t/test.yaml yaml2obj %p/Inputs/test.o.yaml > %t/test.o.yaml lldb-test breakpoint %t/test.yaml %s | FileCheck %s b main

[Lldb-commits] [PATCH] D52152: Add NativeProcessProtocol unit tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB342875: Add NativeProcessProtocol unit tests (authored by labath, committed by ). Changed prior to commit: https://r

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

clayborg added a comment. So the main questions is: do we need a new section enum called eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I would prefer adding a new enum. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp:68 -if (aut

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

teemperor added a comment. Yeah, explicitly typing python2 is what I did to fix it. Not sure if that breaks other OSs though (e.g. if a system has no `python2` binary, but only `python`). Also, that fix should be its own revision. It's not connected to the idea behind this revision from what I

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166698. sgraenitz added a comment. Address Jonas' feedback + minor additions https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp sour

[Lldb-commits] [PATCH] D52406: Make DIE_IS_BEING_PARSED local to the current thread.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A little background might help here: The lldb_private::Module lock is used to prevent multiple queries into the DWARF from stomping on each other. Multi-threaded DWARF parsing wa

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz updated this revision to Diff 166699. sgraenitz added a comment. Address Jonas' feedback #2 https://reviews.llvm.org/D52375 Files: include/lldb/Symbol/Symtab.h source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp source/Plugins/Symb

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

clayborg added a comment. A little background might help here: The lldb_private::Module lock is used to prevent multiple queries into the DWARF from stomping on each other. Multi-threaded DWARF parsing was primarily added to speed up indexing and the only place it is used. Is that not true? Ind

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

sgraenitz added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166714. apolyakov added a comment. Reduced timer from 120 to 30 seconds. https://reviews.llvm.org/D52139 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: lit/tools/lldb-mi/target/inputs/target-select-so-path.py ==

[Lldb-commits] [PATCH] D52376: [Swig] Merge typemaps with same bodies

tatyana-krasnukha updated this revision to Diff 166719. tatyana-krasnukha retitled this revision from "[API][Swig] Overloaded functions for SBTarget" to "[Swig] Merge typemaps with same bodies". tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha removed a reviewer: spyffe. ta

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. A lot of tests are failing with Python 3, at least on CentOS. So, I agree the problem doesn't block this review. https://reviews.llvm.org/D52139 _

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

This revision was automatically updated to reflect the committed changes. Closed by commit rL342915: [lldb-mi] Fix hanging of target-select-so-path.test (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52139?vs=1

[Lldb-commits] [PATCH] D43647: Generate most of the target properties from a central specification.

aprantl abandoned this revision. aprantl added a comment. A Repository: rL LLVM https://reviews.llvm.org/D43647 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp:298-306 +static uint32_t GetOSOSymbolFlags() { + // When a mach-o symbol is encoded, the n_type field is encoded in bits + // 23:16, and the n_desc field is encoded in bits 1

[Lldb-commits] [PATCH] D52376: [Swig] Merge typemaps with same bodies

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Nice, thanks! Repository: rLLDB LLDB https://reviews.llvm.org/D52376 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

clayborg added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:431 const size_t num_ranges = -die->GetAttributeAddressRanges(dwarf, this, ranges, false); +die->GetAttributeAddressRanges(dwarf, this, ranges, check_hi_lo_pc); if

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

JDevlieghere added a comment. Thanks for the information, Greg! In https://reviews.llvm.org/D48393#1243588, @clayborg wrote: > A little background might help here: The lldb_private::Module lock is used to > prevent multiple queries into the DWARF from stomping on each other. > > Multi-threaded

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for all the comments! In https://reviews.llvm.org/D52403#1243127, @clayborg wrote: > So the main questions is: do we need a new section enum called > eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I > would prefer adding a new enum. Yeah

[Lldb-commits] [PATCH] D48393: Make DWARFParsing more thread-safe

labath added a comment. In https://reviews.llvm.org/D48393#1243195, @JDevlieghere wrote: > In https://reviews.llvm.org/D48393#1139327, @labath wrote: > > > The only sane algorithm I can come up right now is to make the list of > > parsed dies local to each thread/parsing entity (e.g. via a "visi

<    4   5   6   7   8   9   10   11   12   13   >