Abpostelnicu marked an inline comment as done.
Abpostelnicu added inline comments.
================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.h:58
const lldb_private::FileSpecList *module_search_paths_ptr,
- lldb::ModuleSP *old_module_sp_ptr,
+ llvm::SmallVectorImpl<lldb::ModuleSP> *old_module,
bool *did_create_ptr) override;
----------------
JosephTremoulet wrote:
> D89156 pluralized the name (`old_modules` with an s) in all the places it
> made this change, since it's now a collection. IMO it would make sense to do
> the same in this change.
Thanks, it makes sense to be pluralized.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95683/new/
https://reviews.llvm.org/D95683
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
