[Lldb-commits] [lldb] r342875 - Add NativeProcessProtocol unit tests

Author: labath Date: Mon Sep 24 05:11:04 2018 New Revision: 342875 URL: http://llvm.org/viewvc/llvm-project?rev=342875&view=rev Log: Add NativeProcessProtocol unit tests Summary: NativeProcessProtocol is an abstract class, but it still contains a significant amount of code. Some of that code is t

[Lldb-commits] [lldb] r343016 - XFAIL some tests in TestTargetCreateDeps on linux

Author: labath Date: Tue Sep 25 12:52:04 2018 New Revision: 343016 URL: http://llvm.org/viewvc/llvm-project?rev=343016&view=rev Log: XFAIL some tests in TestTargetCreateDeps on linux On linux, we do not support automatic loading of dependent modules, so the module list will always contain just on

[Lldb-commits] [lldb] r343076 - Fix a memory read bug in lldb-server

Author: labath Date: Wed Sep 26 00:31:41 2018 New Revision: 343076 URL: http://llvm.org/viewvc/llvm-project?rev=343076&view=rev Log: Fix a memory read bug in lldb-server NativeProcessProtocol::ReadMemoryWithoutTrap had a bug, where it failed to properly remove inserted breakpoint opcodes if the m

Re: [Lldb-commits] [lldb] r343087 - [unittest] Fix NativeProcessProtocolTest.cpp (NFC)

Thanks. On 26/09/18 12:09, Jonas Devlieghere via lldb-commits wrote: > Author: jdevlieghere > Date: Wed Sep 26 03:09:44 2018 > New Revision: 343087 > > URL: http://llvm.org/viewvc/llvm-project?rev=343087&view=rev > Log: > [unittest] Fix NativeProcessProtocolTest.cpp (NFC) > > Cast std::min's sec

[Lldb-commits] [lldb] r343409 - Pull GetSoftwareBreakpointPCOffset into base class

Author: labath Date: Sun Sep 30 08:58:52 2018 New Revision: 343409 URL: http://llvm.org/viewvc/llvm-project?rev=343409&view=rev Log: Pull GetSoftwareBreakpointPCOffset into base class Summary: This function encodes the knowledge of whether the PC points to the breakpoint instruction of the one fo

[Lldb-commits] [lldb] r343411 - Fix NetBSD build for r343409

Author: labath Date: Sun Sep 30 09:12:09 2018 New Revision: 343411 URL: http://llvm.org/viewvc/llvm-project?rev=343411&view=rev Log: Fix NetBSD build for r343409 Forgot to remove the method declaration from the header. Modified: lldb/trunk/source/Plugins/Process/NetBSD/NativeProcessNetBSD.h

[Lldb-commits] [lldb] r343683 - Pull FixupBreakpointPCAsNeeded into base class

Author: labath Date: Wed Oct 3 05:29:33 2018 New Revision: 343683 URL: http://llvm.org/viewvc/llvm-project?rev=343683&view=rev Log: Pull FixupBreakpointPCAsNeeded into base class Summary: This function existed (with identical code) in both NativeProcessLinux and NativeProcessNetBSD, and it is li

Re: [Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

On 26/10/18 18:34, Zachary Turner wrote: > I was thinking about this some more and I’m not sure simple > substitutions will suffice. > > We can provide substitutions to abstract away the command line, but that > doesn’t doesn’t really address the issue that we still need to have a > way to then ru

Re: [Lldb-commits] [PATCH] D52618: [Windows] A basic implementation of memory allocations in a debuggee process

On 29/10/18 15:06, Zachary Turner wrote: > Even in this exact case we have the multiple variants situation. If we > use the substitutions method we would reduce the test coverage by half, > which doesn’t seem like a good idea. Which variants do you have in mind? This patch creates two tests: one w

[Lldb-commits] [lldb] r346093 - NativeProcessProtocol: Simplify breakpoint setting code

Author: labath Date: Sun Nov 4 02:58:08 2018 New Revision: 346093 URL: http://llvm.org/viewvc/llvm-project?rev=346093&view=rev Log: NativeProcessProtocol: Simplify breakpoint setting code Summary: A fairly simple operation as setting a breakpoint (writing a breakpoint opcode) at a given address

[Lldb-commits] [lldb] r346094 - Fix log statement in r346093

Author: labath Date: Sun Nov 4 04:54:29 2018 New Revision: 346094 URL: http://llvm.org/viewvc/llvm-project?rev=346094&view=rev Log: Fix log statement in r346093 Thanks to Dávid Bolvanský for pointing that out. Modified: lldb/trunk/source/Host/common/NativeProcessProtocol.cpp Modified: lldb

[Lldb-commits] [lldb] r346233 - CPlusPlusLanguage: Use new demangler API to implement type substitution

Author: labath Date: Tue Nov 6 07:41:37 2018 New Revision: 346233 URL: http://llvm.org/viewvc/llvm-project?rev=346233&view=rev Log: CPlusPlusLanguage: Use new demangler API to implement type substitution Summary: Now that llvm demangler supports more generic customization, we can implement type

Re: [Lldb-commits] [lldb] r346466 - Revert "[FileSystem] Make use of FS in TildeExpressionResolver"

I think the right way to resolve this would be to move "StandardTildeExpressionResolver" into the host module. The non-standard TildeExpressionResolver is just an abstract class, so it does not need the filesystem. This way, anyone wanting to use the resolver can just depend on the interface, and t

[Lldb-commits] [lldb] r346849 - Fix a crash when parsing incorrect DWARF

Author: labath Date: Wed Nov 14 03:12:40 2018 New Revision: 346849 URL: http://llvm.org/viewvc/llvm-project?rev=346849&view=rev Log: Fix a crash when parsing incorrect DWARF Summary: While parsing a childless compile unit DIE we could crash if the DIE was followed by any extra data (such as a sup

[Lldb-commits] [lldb] r346867 - Move DataExtractorTest to unittests/Utility

Author: labath Date: Wed Nov 14 06:58:36 2018 New Revision: 346867 URL: http://llvm.org/viewvc/llvm-project?rev=346867&view=rev Log: Move DataExtractorTest to unittests/Utility The DataExtractor class itself was moved to Utility some time ago, but it seems this was not reflected in the location o

Re: [Lldb-commits] [lldb] r347125 - Just don't even attempt to invoke sed on Windows.

On 17/11/2018 02:27, Adrian Prantl via lldb-commits wrote: Author: adrian Date: Fri Nov 16 17:27:47 2018 New Revision: 347125 URL: http://llvm.org/viewvc/llvm-project?rev=347125&view=rev Log: Just don't even attempt to invoke sed on Windows. Modified: lldb/trunk/packages/Python/lldbsuite/t

Re: [Lldb-commits] [lldb] r347615 - [FileSystem] Ignore nanoseconds when comparing oso_mod_time

Was it necessary to modify FileSystem to achieve this. It looks like you could have just as easily made the time_point_cast in SymbolFileDWARFDebugMap (next to a comment explaining why that was needed). The extra nanosecond_precision argument looks fairly odd, and diverges from how the llvm in

[Lldb-commits] [lldb] r347846 - Remove getopt includes from the driver

Author: labath Date: Thu Nov 29 02:45:41 2018 New Revision: 347846 URL: http://llvm.org/viewvc/llvm-project?rev=347846&view=rev Log: Remove getopt includes from the driver They are not needed now that we use LLVMOption for command-line parsing thank you, Jonas). This also allows us to avoid link

[Lldb-commits] [lldb] r347855 - Fix windows build broken by r347846

Author: labath Date: Thu Nov 29 03:53:12 2018 New Revision: 347855 URL: http://llvm.org/viewvc/llvm-project?rev=347855&view=rev Log: Fix windows build broken by r347846 The changed order of includes caused compile errors on MSVC due to snprintf macro definition. snprintf should available since VS

Re: [Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

On 29/11/2018 23:34, Greg Clayton wrote: On Nov 29, 2018, at 10:55 AM, Pavel Labath via Phabricator wrote: labath added a comment. I've recently started looking at adding a new symbol file format (breakpad symbols). While researching the best way to achieve that, I started comparing the

Re: [Lldb-commits] [lldb] r348186 - Skip TestDriverOptions on Windows

On 03/12/2018 21:55, Jonas Devlieghere via lldb-commits wrote: That wouldn't work because we try to create the directory which would succeeded in the temp dir. I'd have to be something you don't have access to, like the root or some network drive. How about we change the behavior to only cre

[Lldb-commits] [lldb] r348261 - Fix lldb-server unit tests for the MonitoringProcessLauncher refactor

Author: labath Date: Tue Dec 4 06:04:27 2018 New Revision: 348261 URL: http://llvm.org/viewvc/llvm-project?rev=348261&view=rev Log: Fix lldb-server unit tests for the MonitoringProcessLauncher refactor We now need to initialize the filesystem in these tests. Modified: lldb/trunk/unittests/t

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

On 05/12/2018 00:56, Zachary Turner via lldb-commits wrote: Author: zturner Date: Tue Dec 4 15:56:25 2018 New Revision: 348319 URL: http://llvm.org/viewvc/llvm-project?rev=348319&view=rev Log: [build.py] Disable tests on non-Windows. This won't work until we get the GCC / clang builder impleme

Re: [Lldb-commits] [lldb] r348319 - [build.py] Disable tests on non-Windows.

On 05/12/2018 16:03, Zachary Turner wrote: If you can commit the same fix I did for the other two that would be great, otherwise I’ll get to it when i get into the office in ~2 hours The thing is, I'm not sure if that's the right fix here. I mean, this script should be able to compile with cl

Re: [Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

On 06/12/2018 09:25, Aleksandr Urakov via lldb-commits wrote: I thought about what Stella have said, and it seems that I have found a good solution for this. We can use something like `tempfile` (https://docs.python.org/3.7/library/tempfile.html) for every internally generated file of the scr

[Lldb-commits] [lldb] r348474 - disable toolchain-clang-cl.test on non-windows

Author: labath Date: Thu Dec 6 01:39:09 2018 New Revision: 348474 URL: http://llvm.org/viewvc/llvm-project?rev=348474&view=rev Log: disable toolchain-clang-cl.test on non-windows The recently added test fail on non-windows platforms. Modified: lldb/trunk/lit/BuildScript/toolchain-clang-cl.t

[Lldb-commits] [lldb] r348476 - Remove REQUIRES: darwin from a couple of MachO tests

Author: labath Date: Thu Dec 6 01:41:50 2018 New Revision: 348476 URL: http://llvm.org/viewvc/llvm-project?rev=348476&view=rev Log: Remove REQUIRES: darwin from a couple of MachO tests lldb is able to parse MachO files also on other platforms nowadays. Modified: lldb/trunk/lit/Modules/lc_bu

[Lldb-commits] [lldb] r348479 - Make scripts/analyzer-project-deps compatible with python3

Author: labath Date: Thu Dec 6 02:27:38 2018 New Revision: 348479 URL: http://llvm.org/viewvc/llvm-project?rev=348479&view=rev Log: Make scripts/analyzer-project-deps compatible with python3 Modified: lldb/trunk/scripts/analyze-project-deps.py Modified: lldb/trunk/scripts/analyze-project-de

[Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

Author: labath Date: Fri Dec 7 06:20:27 2018 New Revision: 348592 URL: http://llvm.org/viewvc/llvm-project?rev=348592&view=rev Log: Introduce ObjectFileBreakpad Summary: This patch adds the scaffolding necessary for lldb to recognise symbol files generated by breakpad. These (textual) files cont

Re: [Lldb-commits] [lldb] r348592 - Introduce ObjectFileBreakpad

On 07/12/2018 19:39, Davide Italiano wrote: Pavel, this broke the MacOS lldb cmake bot. In particular, this test started failing. lldb-Suite.macosx/function-starts.TestFunctionStarts.py http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/ May I ask you to take a look? That's interesting.

[Lldb-commits] [lldb] r348773 - Re-commit "Introduce ObjectFileBreakpad"

Author: labath Date: Mon Dec 10 09:16:38 2018 New Revision: 348773 URL: http://llvm.org/viewvc/llvm-project?rev=348773&view=rev Log: Re-commit "Introduce ObjectFileBreakpad" This re-commits r348592, which was reverted due to a failing test on macos. The issue was that I was passing a null pointe

[Lldb-commits] [lldb] r348780 - Fix r348773

Author: labath Date: Mon Dec 10 10:17:53 2018 New Revision: 348780 URL: http://llvm.org/viewvc/llvm-project?rev=348780&view=rev Log: Fix r348773 It's not sufficient to implement the CreateMemoryInstance function, one has to use it too. Modified: lldb/trunk/source/Plugins/ObjectFile/Breakpad/

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

On 11/12/2018 01:08, Greg Clayton wrote: On Dec 10, 2018, at 3:11 PM, Leonard Mosescu > wrote: I can see how this works for the PDB, no-module-binary case. What about the PDB & module-binary case? That would work fine because the symbol vendor will make an object

[Lldb-commits] [lldb] r348849 - Rename ObjectFile::GetHeaderAddress to GetBaseAddress

Author: labath Date: Tue Dec 11 07:21:15 2018 New Revision: 348849 URL: http://llvm.org/viewvc/llvm-project?rev=348849&view=rev Log: Rename ObjectFile::GetHeaderAddress to GetBaseAddress Summary: This function was named such because in the case of MachO files, the mach header is located at this a

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

On 11/12/2018 19:17, Jim Ingham wrote: It the section isn't in the target's SectionLoadList, then GetLoadAddress should return LLDB_INVALID_ADDRESS. I.e. this bit from Section::GetLoadBaseAddress: load_base_addr = target->GetSectionLoadList().GetSectionLoadAddress( const_cast(th

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

On 11/12/2018 20:10, Jim Ingham via Phabricator wrote: jingham added a comment. In D55356#1327280 , @clayborg wrote: In D55356#1327242 , @labath wrote: In D55356#1327224

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

On 11/12/2018 20:39, Jim Ingham wrote: Sections can have parents. In MachO the text and data sections are actually contained in the TEXT and DATA segments respectively. LLDB represents this by having an lldb_private::Section for the segment, and then all the sections in that segment are chil

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

On 11/12/2018 20:34, Zachary Turner wrote: I meant the location of the minidump.  So if you have C:\A\B\C\foo.dmp which is the dump file for bar.exe which crashed on another machine, then it would look for C:\A\B\C\bar.pdb.  That actually seems like fairly intuitive behavior to me, but maybe I'

[Lldb-commits] [lldb] r348918 - build.py: Implement "gcc" builder

Author: labath Date: Wed Dec 12 00:54:14 2018 New Revision: 348918 URL: http://llvm.org/viewvc/llvm-project?rev=348918&view=rev Log: build.py: Implement "gcc" builder Summary: This implements the gcc builder in build.py script to allow it to compile host executables when running on a non-windows

Re: [Lldb-commits] [PATCH] D55356: Add a method to get the "base" file address of an object file

On 11/12/2018 23:54, Zachary Turner wrote: On Tue, Dec 11, 2018 at 11:57 AM Pavel Labath > wrote: The part I know nothing about is whether something similar could be done for PE/COFF files (and I'll need something like that there too). Adrian, Zacha

[Lldb-commits] [lldb] r348924 - lldb-test: Add ability to dump subsections

Author: labath Date: Wed Dec 12 04:35:25 2018 New Revision: 348924 URL: http://llvm.org/viewvc/llvm-project?rev=348924&view=rev Log: lldb-test: Add ability to dump subsections Previously, lldb-test would only print top-level sections. However, in lldb, sections can contain other sections. This te

[Lldb-commits] [lldb] r348928 - ELF: Simplify program header iteration

Author: labath Date: Wed Dec 12 06:20:28 2018 New Revision: 348928 URL: http://llvm.org/viewvc/llvm-project?rev=348928&view=rev Log: ELF: Simplify program header iteration Instead of GetProgramHeaderCount+GetProgramHeaderByIndex, expose an ArrayRef of all program headers, to enable range-based it

[Lldb-commits] [lldb] r348936 - ELF: Clean up section type computation

Author: labath Date: Wed Dec 12 07:46:18 2018 New Revision: 348936 URL: http://llvm.org/viewvc/llvm-project?rev=348936&view=rev Log: ELF: Clean up section type computation Move code into a separate function, and replace the if-else chain with llvm::StringSwitch. A slight behavioral change is tha

[Lldb-commits] [lldb] r349027 - Classify tests in lit/Modules

Author: labath Date: Thu Dec 13 04:13:29 2018 New Revision: 349027 URL: http://llvm.org/viewvc/llvm-project?rev=349027&view=rev Log: Classify tests in lit/Modules We've recently developed a convention where the tests are placed into subfolders according to the object file type. This applies that

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

On 13/12/2018 19:32, Leonard Mosescu wrote: What's the consensus? Personally I think that, even considering the potential issue that Paval pointed out, the "target symbols add ..." is the most conservative approach in terms of introducing new behavior. I'm fine with the current directory look

Re: [Lldb-commits] [PATCH] D55142: Minidump debugging using the native PDB reader

On 13/12/2018 23:19, Zachary Turner wrote: The permanent solution would be figuring out what to do about the ObjectFile situation (e.g. do we want to make an ObjectFilePDB or do we want to live in a world where SymbolFiles need not be backed by ObjectFiles?), and then regardless of what we deci

[Lldb-commits] [lldb] r349149 - Mark Permissions as a bitmask enum

Author: labath Date: Fri Dec 14 05:51:20 2018 New Revision: 349149 URL: http://llvm.org/viewvc/llvm-project?rev=349149&view=rev Log: Mark Permissions as a bitmask enum this allows one to use bitwise operators on the variables of this type without complicated casting. The gotcha here is that the

[Lldb-commits] [lldb] r349153 - Fix build with older (<3.0) swigs

Author: labath Date: Fri Dec 14 06:25:20 2018 New Revision: 349153 URL: http://llvm.org/viewvc/llvm-project?rev=349153&view=rev Log: Fix build with older (<3.0) swigs It turns out it wasn't the compilers, but swig who had issues with my previous patch -- older versions do not recognise the "const

[Lldb-commits] [lldb] r349154 - Fix minidump unit test failures from r349062

Author: labath Date: Fri Dec 14 06:41:04 2018 New Revision: 349154 URL: http://llvm.org/viewvc/llvm-project?rev=349154&view=rev Log: Fix minidump unit test failures from r349062 This commit added new test inputs, but it did not add them to the cmake files. This caused the test to fail at runtime.

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

On 14/12/2018 19:43, Zachary Turner via lldb-commits wrote: Author: zturner Date: Fri Dec 14 10:43:42 2018 New Revision: 349175 URL: http://llvm.org/viewvc/llvm-project?rev=349175&view=rev Log: [NativePDB] Fix local-variables.cpp test. Since we're actually running an executable on the host now,

Re: [Lldb-commits] [lldb] r349175 - [NativePDB] Fix local-variables.cpp test.

On 14/12/2018 19:52, Zachary Turner wrote: I don't know if there's a good way to do that.  Because debuggers need to be able to see across multiple translation units, this is implemented internally as constructing one giant AST that contains everything for the entire program.  LLDB has no notio

Re: [Lldb-commits] [PATCH] D55430: build.py: Implement "gcc" builder

On 14/12/2018 20:32, Stella Stamenova via Phabricator wrote: stella.stamenova added a comment. I am trying to use the new builder to build the lldb-mi tests, so that they can start consistently passing on Windows, so they're now using the gcc builder on Linux and failing: Interesting. Can yo

[Lldb-commits] [lldb] r349267 - Remove /proc/pid/maps parsing code from NativeProcessLinux

Author: labath Date: Sat Dec 15 05:38:16 2018 New Revision: 349267 URL: http://llvm.org/viewvc/llvm-project?rev=349267&view=rev Log: Remove /proc/pid/maps parsing code from NativeProcessLinux A utility function doing this was added in r349182, so use that instead. Modified: lldb/trunk/source

[Lldb-commits] [lldb] r349268 - ELF: more section creation cleanup

Author: labath Date: Sat Dec 15 05:45:38 2018 New Revision: 349268 URL: http://llvm.org/viewvc/llvm-project?rev=349268&view=rev Log: ELF: more section creation cleanup Summary: This patch attempts to move as much code as possible out of the CreateSections function to make room for future improvem

[Lldb-commits] [lldb] r349269 - lldb-test: Improve newline handling

Author: labath Date: Sat Dec 15 05:49:25 2018 New Revision: 349269 URL: http://llvm.org/viewvc/llvm-project?rev=349269&view=rev Log: lldb-test: Improve newline handling Summary: Previously lldb-test's LinePrinter would output the indentation spaces even on completely empty lines. This is not nice

Re: [Lldb-commits] [lldb] r349397 - Remove sleep() synchronisation from teststcase and

Not that I want to defend the use of sleep, but my expectation is that this will the test even more flaky. The only thing that test does after attaching is verifying the process backtrace to check that it contains the "main" function. If the test doesn't sleep, it increases the likelyhood tha

[Lldb-commits] [lldb] r349461 - build.py: inherit environment in the gcc builder

Author: labath Date: Tue Dec 18 01:07:21 2018 New Revision: 349461 URL: http://llvm.org/viewvc/llvm-project?rev=349461&view=rev Log: build.py: inherit environment in the gcc builder Summary: This should enable the compiler to find the system linker for the link step. Reviewers: stella.stamenova,

[Lldb-commits] [lldb] r349478 - Un-XFAIL TestNamespaceLookup for linux

Author: labath Date: Tue Dec 18 04:55:30 2018 New Revision: 349478 URL: http://llvm.org/viewvc/llvm-project?rev=349478&view=rev Log: Un-XFAIL TestNamespaceLookup for linux These tests are now passing on linux, at least with top-of-tree clang, clang-6 and gcc-7.3. It's possible it may still be fai

[Lldb-commits] [lldb] r349479 - Un-XFAIL TestExitDuringBreak.py for linux

Author: labath Date: Tue Dec 18 05:12:36 2018 New Revision: 349479 URL: http://llvm.org/viewvc/llvm-project?rev=349479&view=rev Log: Un-XFAIL TestExitDuringBreak.py for linux This test is passing now on linux, and probably has been passing since r282993. Modified: lldb/trunk/packages/Python

[Lldb-commits] [lldb] r349482 - Un-XFail TestThreadStates.test_process_interrupt

Author: labath Date: Tue Dec 18 05:32:42 2018 New Revision: 349482 URL: http://llvm.org/viewvc/llvm-project?rev=349482&view=rev Log: Un-XFail TestThreadStates.test_process_interrupt This test is passing now on linux. The same test is claimed to be flaky on darwin, so it's possible that's true on

[Lldb-commits] [lldb] r349485 - Un-XFail TestYMMRegister on linux

Author: labath Date: Tue Dec 18 05:50:38 2018 New Revision: 349485 URL: http://llvm.org/viewvc/llvm-project?rev=349485&view=rev Log: Un-XFail TestYMMRegister on linux This test was disabled in r326756 as a part of "upstreaming debugserver support for AVX-512 (zmm register set)". This looks like a

[Lldb-commits] [lldb] r349487 - Skip TestMultithreaded.test_sb_api_listener_resume on linux

Author: labath Date: Tue Dec 18 06:24:55 2018 New Revision: 349487 URL: http://llvm.org/viewvc/llvm-project?rev=349487&view=rev Log: Skip TestMultithreaded.test_sb_api_listener_resume on linux The test still fails occasionally (1/100 runs). Upgrade the xfail to skip. Modified: lldb/trunk/pa

[Lldb-commits] [lldb] r349491 - de-flake TestThreadStates.test_process_interrupt

Author: labath Date: Tue Dec 18 07:15:02 2018 New Revision: 349491 URL: http://llvm.org/viewvc/llvm-project?rev=349491&view=rev Log: de-flake TestThreadStates.test_process_interrupt the "self.assertEqual(thread.GetStopReason(), lldb.eStopReasonSignal)" was occasionally failing because the stop re

[Lldb-commits] [lldb] r349495 - Fix the "dangerous use of tempnam" warning in Host/SocketTest.cpp

Author: labath Date: Tue Dec 18 07:33:50 2018 New Revision: 349495 URL: http://llvm.org/viewvc/llvm-project?rev=349495&view=rev Log: Fix the "dangerous use of tempnam" warning in Host/SocketTest.cpp instead, create a unique temporary directory, and place the socket file there. Modified: lldb

Re: [Lldb-commits] [lldb] r349401 - [lit] Detect unexpected passes in lldbtest.

On 17/12/2018 22:40, Jonas Devlieghere via lldb-commits wrote: Author: jdevlieghere Date: Mon Dec 17 13:40:37 2018 New Revision: 349401 URL: http://llvm.org/viewvc/llvm-project?rev=349401&view=rev Log: [lit] Detect unexpected passes in lldbtest. This patch will have lit report unexpected passes

[Lldb-commits] [lldb] r349498 - ELF: Don't create sections for section header index 0

Author: labath Date: Tue Dec 18 07:56:45 2018 New Revision: 349498 URL: http://llvm.org/viewvc/llvm-project?rev=349498&view=rev Log: ELF: Don't create sections for section header index 0 Summary: The first section header does not define a real section. Instead it is used for various elf extension

[Lldb-commits] [lldb] r350086 - DWARF: Fix a bug in array size computation

Author: labath Date: Thu Dec 27 01:25:34 2018 New Revision: 350086 URL: http://llvm.org/viewvc/llvm-project?rev=350086&view=rev Log: DWARF: Fix a bug in array size computation Summary: r346165 introduced a bug, where we would fail to parse the size of an array if that size happened to match an ex

[Lldb-commits] [lldb] r350087 - lldb-test ir-memory-map: Use IntervalMap::contains

Author: labath Date: Thu Dec 27 01:32:04 2018 New Revision: 350087 URL: http://llvm.org/viewvc/llvm-project?rev=350087&view=rev Log: lldb-test ir-memory-map: Use IntervalMap::contains Summary: Simplify the code by using the contains implementation in IntervalMap. There is a slight change of beha

[Lldb-commits] [lldb] r350089 - Fix "default argument for lambda parameter" (-Wpedantic) warning

Author: labath Date: Thu Dec 27 01:44:32 2018 New Revision: 350089 URL: http://llvm.org/viewvc/llvm-project?rev=350089&view=rev Log: Fix "default argument for lambda parameter" (-Wpedantic) warning Modified: lldb/trunk/source/Plugins/Process/minidump/ProcessMinidump.cpp Modified: lldb/trunk/

[Lldb-commits] [lldb] r350088 - Delete lldb_utility::Range

Author: labath Date: Thu Dec 27 01:44:27 2018 New Revision: 350088 URL: http://llvm.org/viewvc/llvm-project?rev=350088&view=rev Log: Delete lldb_utility::Range This class is unused, and there is already a lldb_private::Range (defined in lldb/Core/RangeMap.h), which has similar functionality. Rem

[Lldb-commits] [lldb] r350091 - Fix assertion failure in NativeProcessProtocolTest

Author: labath Date: Thu Dec 27 05:45:55 2018 New Revision: 350091 URL: http://llvm.org/viewvc/llvm-project?rev=350091&view=rev Log: Fix assertion failure in NativeProcessProtocolTest The assertion fired (with a debug visual studio STL) because we tried to dereference the end of a vector (althoug

[Lldb-commits] [lldb] r350094 - Reduce indentation in ObjectFilePECOFF::CreateSections via an early return

Author: labath Date: Thu Dec 27 07:16:44 2018 New Revision: 350094 URL: http://llvm.org/viewvc/llvm-project?rev=350094&view=rev Log: Reduce indentation in ObjectFilePECOFF::CreateSections via an early return Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Modified:

[Lldb-commits] [lldb] r350093 - Fix tests for python 3.7

Author: labath Date: Thu Dec 27 07:16:37 2018 New Revision: 350093 URL: http://llvm.org/viewvc/llvm-project?rev=350093&view=rev Log: Fix tests for python 3.7 python 3.7 removes re._pattern_type. Fix the one place where we were depending on the type of regular expressions to compute the type dynam

[Lldb-commits] [lldb] r350122 - Fix signed-unsigned comparisons in MinidumpParserTest

Author: labath Date: Fri Dec 28 05:34:50 2018 New Revision: 350122 URL: http://llvm.org/viewvc/llvm-project?rev=350122&view=rev Log: Fix signed-unsigned comparisons in MinidumpParserTest Modified: lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp Modified: lldb/trunk/unittests/Pro

[Lldb-commits] [lldb] r350121 - Remove unused variable from ClangASTContext

Author: labath Date: Fri Dec 28 05:34:44 2018 New Revision: 350121 URL: http://llvm.org/viewvc/llvm-project?rev=350121&view=rev Log: Remove unused variable from ClangASTContext Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp URL:

Re: [Lldb-commits] [lldb] r350160 - [test] Remove flakiness decorator from TestObjCDynamicSBType

BTW, the flakiness decorators have no effect when using lit as the test runner. They relied on passing a message from the test to the test framework, which caused the latter to re-run the test. Of course, lit has no idea what to do with these messages. On 30/12/2018 17:24, Davide Italiano via

[Lldb-commits] [lldb] r350209 - NativeProcessProtocolTest: fix -Winconsistent-missing-override warning

Author: labath Date: Wed Jan 2 02:37:38 2019 New Revision: 350209 URL: http://llvm.org/viewvc/llvm-project?rev=350209&view=rev Log: NativeProcessProtocolTest: fix -Winconsistent-missing-override warning The warning comes from the fact that the MOCK_METHOD macros don't use the override keyword in

Re: [Lldb-commits] [PATCH] D56173: Introduce SymbolFileBreakpad and use it to fill symtab

On 02/01/2019 18:32, Zachary Turner wrote: Just to be sure, this new test will fail without your Symtab changes right?  I'm not in a state where I can look at code right now, and you say anything that symbolicates an address *can* use the symtab, but I don't know if you really meant *must* use

Re: [Lldb-commits] [PATCH] D56233: [lldb-server] Add initial support for building lldb-server on Windows

On 03/01/2019 02:08, Zachary Turner via lldb-commits wrote: Very excited to see this.  I'm technically on vacation so I might not be able to review it immediately, but I'm looking forward to getting to it soon. I am also very excited. Unlike PDBs, I think I actually know a thing or two abou

[Lldb-commits] [lldb] r350291 - Simplify ObjectFile::GetArchitecture

Author: labath Date: Thu Jan 3 02:37:19 2019 New Revision: 350291 URL: http://llvm.org/viewvc/llvm-project?rev=350291&view=rev Log: Simplify ObjectFile::GetArchitecture Summary: instead of returning the architecture through by-ref argument and a boolean value indicating success, we can just retu

[Lldb-commits] [lldb] r350294 - Fix some -Wreorder warnings introduced in r350274

Author: labath Date: Thu Jan 3 03:31:50 2019 New Revision: 350294 URL: http://llvm.org/viewvc/llvm-project?rev=350294&view=rev Log: Fix some -Wreorder warnings introduced in r350274 Modified: lldb/trunk/include/lldb/Symbol/LineTable.h Modified: lldb/trunk/include/lldb/Symbol/LineTable.h URL

[Lldb-commits] [lldb] r350298 - PECOFF: Remove tabs introduced accidentally in r350094

Author: labath Date: Thu Jan 3 04:07:38 2019 New Revision: 350298 URL: http://llvm.org/viewvc/llvm-project?rev=350298&view=rev Log: PECOFF: Remove tabs introduced accidentally in r350094 Modified: lldb/trunk/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp Modified: lldb/trunk/source/P

[Lldb-commits] [lldb] r350380 - RangeMap.h: merge RangeDataArray and RangeDataVector

Author: labath Date: Thu Jan 3 23:14:17 2019 New Revision: 350380 URL: http://llvm.org/viewvc/llvm-project?rev=350380&view=rev Log: RangeMap.h: merge RangeDataArray and RangeDataVector Summary: The main difference between the classes was supposed to be the fact that one is backed by llvm::SmallV

[Lldb-commits] [lldb] r350384 - Symtab: Remove one copy of symbol size computation code

Author: labath Date: Fri Jan 4 02:11:25 2019 New Revision: 350384 URL: http://llvm.org/viewvc/llvm-project?rev=350384&view=rev Log: Symtab: Remove one copy of symbol size computation code Summary: The implementation in CalculateSymbolSizes has been made redundant in D19004, as this patch added a

Re: [Lldb-commits] [PATCH] D56315: Add a verbose mode to "image dump line-table" and use it to write a .debug_line test

On 04/01/2019 17:53, Zachary Turner wrote: It seems like this test could be made to work with non dwarf debug info by compiling a real source file. WDYT? Well.. I could write a test by compiling a real source, but it wouldn't be *this* test. The idea here was to validate the parsing of the deb

Re: [Lldb-commits] [PATCH] D56293: Use the minidump exception record if present

On 04/01/2019 17:48, Zachary Turner wrote: For those kinds of cases, we could use obj2yaml and check in yaml right? Fwiw I tried to round-trip an exe through obj->yaml->obj recently and the resulting exe was incorrect but it was close, so I think there’s only some small fixes needed. I agre

[Lldb-commits] [lldb] r350510 - ProcessLaunchInfo: remove Debugger reference

Author: labath Date: Mon Jan 7 02:59:57 2019 New Revision: 350510 URL: http://llvm.org/viewvc/llvm-project?rev=350510&view=rev Log: ProcessLaunchInfo: remove Debugger reference Summary: The Debuffer object was being used in "GetListenerForProcess" to provide a default listener object if one was

[Lldb-commits] [lldb] r350511 - ObjectFileBreakpad: Implement sections

Author: labath Date: Mon Jan 7 03:14:08 2019 New Revision: 350511 URL: http://llvm.org/viewvc/llvm-project?rev=350511&view=rev Log: ObjectFileBreakpad: Implement sections Summary: This patch allows ObjectFileBreakpad to parse the contents of Breakpad files into sections. This sounds slightly odd

Re: [Lldb-commits] [PATCH] D56418: Change lldb-test to use ParseAllDebugSymbols instead of ParseDeclsForContext

On 08/01/2019 11:45, Zachary Turner wrote: The same plugin is being used in both cases, the patch only touches the nonnative PDB reader. The followup changes to the plugin itself are necessary because the results were not identical (another reason i want to de-support ParseDeclsForContext at gl

[Lldb-commits] [lldb] r350617 - ProcessLaunchInfo: Remove Target reference

Author: labath Date: Tue Jan 8 03:55:19 2019 New Revision: 350617 URL: http://llvm.org/viewvc/llvm-project?rev=350617&view=rev Log: ProcessLaunchInfo: Remove Target reference Summary: The target was being used in FinalizeFileActions to provide default values for stdin/out/err. Also, most of the

[Lldb-commits] [lldb] r331966 - CPlusPlusLanguage: Add unit tests for the FindAlternateFunctionManglings method

Author: labath Date: Thu May 10 01:59:17 2018 New Revision: 331966 URL: http://llvm.org/viewvc/llvm-project?rev=331966&view=rev Log: CPlusPlusLanguage: Add unit tests for the FindAlternateFunctionManglings method I was considering modifying this function, so I wrote some tests to make sure I don'

[Lldb-commits] [lldb] r331970 - Convert all RunShellCommand functions to use the Timeout class

Author: labath Date: Thu May 10 03:46:03 2018 New Revision: 331970 URL: http://llvm.org/viewvc/llvm-project?rev=331970&view=rev Log: Convert all RunShellCommand functions to use the Timeout class this completes the Timeout migration started in r331880 with the Predicate class. Modified: lldb

[Lldb-commits] [lldb] r331974 - Fix windows&mac builds broken by r331970 (RunShellCommand/Timeout) refactor

Author: labath Date: Thu May 10 04:27:43 2018 New Revision: 331974 URL: http://llvm.org/viewvc/llvm-project?rev=331974&view=rev Log: Fix windows&mac builds broken by r331970 (RunShellCommand/Timeout) refactor Modified: lldb/trunk/source/Host/macosx/Symbols.cpp lldb/trunk/source/Host/windo

[Lldb-commits] [lldb] r331977 - Fix one more RunShellcommand occurence in mac code

Author: labath Date: Thu May 10 05:02:24 2018 New Revision: 331977 URL: http://llvm.org/viewvc/llvm-project?rev=331977&view=rev Log: Fix one more RunShellcommand occurence in mac code Modified: lldb/trunk/source/Host/macosx/Host.mm Modified: lldb/trunk/source/Host/macosx/Host.mm URL: http:/

Re: [Lldb-commits] [RFC] Type lookup for template types is broken...

On Thu, 10 May 2018 at 16:19, wrote: > > Anyway, the issue is that the PS4 targets don't emit DW_AT_linkage_name > > attributes in the debug info, but we are still emitting an index entry > > with > > the mangled names. This caused the verifier to complain. > > > > Two interesting questions follo

[Lldb-commits] [lldb] r332088 - Remove custom path manipulation functions from FileSpec

Author: labath Date: Fri May 11 04:55:34 2018 New Revision: 332088 URL: http://llvm.org/viewvc/llvm-project?rev=332088&view=rev Log: Remove custom path manipulation functions from FileSpec Summary: now that llvm supports host-agnostic path manipulation functions (and most of their kinks have been

Re: [Lldb-commits] [lldb] r332162 - [LLDB] Support GNU-style compressed debug sections (.zdebug)

I would suggest testing this the way we have started testing all other ObjectFile changes -- yaml2obj + lldb-test (see tests in lit/Modules). A full-scale integration test is interesting, but I would consider it optional, as this patch touches no files outside the object layer. On Sat, 12 May 2018

Re: [Lldb-commits] [PATCH] D46810: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

On Mon, 14 May 2018 at 15:24, Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added a comment. > In https://reviews.llvm.org/D46810#1097829, @labath wrote: > > I am not sure it's that simple. I've found at least one case (`SymbolFileDWARF::ParseImportedModuleswh

[Lldb-commits] [lldb] r332247 - FileSpec: Remove PathSyntax enum and use llvm version instead

Author: labath Date: Mon May 14 07:52:47 2018 New Revision: 332247 URL: http://llvm.org/viewvc/llvm-project?rev=332247&view=rev Log: FileSpec: Remove PathSyntax enum and use llvm version instead Summary: The llvm version of the enum has the same enumerators, with stlightly different names, so thi

[Lldb-commits] [lldb] r332250 - Remove Process references from the Host module

Author: labath Date: Mon May 14 08:13:13 2018 New Revision: 332250 URL: http://llvm.org/viewvc/llvm-project?rev=332250&view=rev Log: Remove Process references from the Host module The Process class was only being referenced because of the last-ditch effort in the process launchers to set a proces

  1   2   3   4   5   6   7   8   9   10   >