On 29/10/18 15:06, Zachary Turner wrote: > Even in this exact case we have the multiple variants situation. If we > use the substitutions method we would reduce the test coverage by half, > which doesn’t seem like a good idea.
Which variants do you have in mind? This patch creates two tests: one which has REQUIRES: windows, and another which has UNSUPPORTED: windows. With the substitution we would have just one test, which runs everywhere (but tests slightly different things). > > Similarly, in the target variables tests i added to the native pdb > plugin Jim was asking if I could also enable that exact same test for > other platforms. But it’s not possible without a way to run multiple > variants. And for tests where no running process is required I think > it’s a worthy goal to try to do that. I certainly don't disagree with that, but I think there may be room for both approaches. _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
