Author: labath
Date: Fri Dec 28 05:34:50 2018
New Revision: 350122
URL: http://llvm.org/viewvc/llvm-project?rev=350122&view=rev
Log:
Fix signed-unsigned comparisons in MinidumpParserTest
Modified:
lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
Modified: lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp
URL:
http://llvm.org/viewvc/llvm-project/lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp?rev=350122&r1=350121&r2=350122&view=diff
==============================================================================
--- lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp (original)
+++ lldb/trunk/unittests/Process/minidump/MinidumpParserTest.cpp Fri Dec 28
05:34:50 2018
@@ -636,8 +636,8 @@ TEST_F(MinidumpParserTest, MinidumpDupli
// one time, we pick the one with the lowest base_of_image.
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
- EXPECT_EQ(1, filtered_modules.size());
- EXPECT_EQ(0x0000000000001000, filtered_modules[0]->base_of_image);
+ EXPECT_EQ(1u, filtered_modules.size());
+ EXPECT_EQ(0x0000000000001000u, filtered_modules[0]->base_of_image);
}
TEST_F(MinidumpParserTest, MinidumpModuleOrder) {
@@ -652,12 +652,12 @@ TEST_F(MinidumpParserTest, MinidumpModul
std::vector<const MinidumpModule *> filtered_modules =
parser->GetFilteredModuleList();
llvm::Optional<std::string> name;
- EXPECT_EQ(2, filtered_modules.size());
- EXPECT_EQ(0x0000000000002000, filtered_modules[0]->base_of_image);
+ EXPECT_EQ(2u, filtered_modules.size());
+ EXPECT_EQ(0x0000000000002000u, filtered_modules[0]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[0]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/a"), *name);
- EXPECT_EQ(0x0000000000001000, filtered_modules[1]->base_of_image);
+ EXPECT_EQ(0x0000000000001000u, filtered_modules[1]->base_of_image);
name = parser->GetMinidumpString(filtered_modules[1]->module_name_rva);
ASSERT_TRUE((bool)name);
EXPECT_EQ(std::string("/tmp/b"), *name);
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
